[PATCH] D67877: [analyzer] Conditionnaly include clang Analysis examples with cmake.

2019-09-28 Thread Jean-Bapiste Lepesme via Phabricator via cfe-commits
Jiboo abandoned this revision. Jiboo added a comment. Superseded by D68172 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67877/new/ https://reviews.llvm.org/D67877 __

[PATCH] D67877: [analyzer] Conditionnaly include clang Analysis examples with cmake.

2019-09-28 Thread Jean-Bapiste Lepesme via Phabricator via cfe-commits
Jiboo added a comment. @aaronpuchert thanks, that looks like a better fix than mine for PR43430, although I'm not sure D68172 obsoletes this patch. @Szelethus could you confirm that thus examples shouldn't be built when CLANG_BUILD_EXAMPLES is OFF, and that thi

[PATCH] D67877: [analyzer] Conditionnaly include clang Analysis examples with cmake.

2019-09-24 Thread Jean-Bapiste Lepesme via Phabricator via cfe-commits
Jiboo added a comment. Here you go: https://bugs.llvm.org/show_bug.cgi?id=43430 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67877/new/ https://reviews.llvm.org/D67877 ___ cfe-commits mailing list cfe

[PATCH] D67877: [analyzer] Conditionnaly include clang Analysis examples with cmake.

2019-09-21 Thread Jean-Bapiste Lepesme via Phabricator via cfe-commits
Jiboo added a comment. @Szelethus take your time, I'm surprised to be the first with the problem (couldn't find reference on google or llvm bug tracker), I wouldn't be surprised if I fucked up somewhere and that this patch isn't really necessary. Repository: rC Clang CHANGES SINCE LAST ACTI

[PATCH] D67877: Conditionnaly include clang Analysis examples with cmake.

2019-09-21 Thread Jean-Bapiste Lepesme via Phabricator via cfe-commits
Jiboo added inline comments. Comment at: clang/lib/Analysis/plugins/CMakeLists.txt:1-2 -if(CLANG_ENABLE_STATIC_ANALYZER AND LLVM_ENABLE_PLUGINS) +if(CLANG_ENABLE_STATIC_ANALYZER AND LLVM_ENABLE_PLUGINS AND CLANG_BUILD_EXAMPLES) add_subdirectory(SampleAnalyzer) add_subdirec

[PATCH] D67877: Conditionnaly include clang Analysis examples with cmake.

2019-09-21 Thread Jean-Bapiste Lepesme via Phabricator via cfe-commits
Jiboo updated this revision to Diff 221181. Jiboo marked 3 inline comments as done. Jiboo added a comment. Update to add -U99, although dunno why I don't get more context on clang/lib/Analysis/plugins/CMakeLists.txt. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D67877: Conditionnaly include clang Analysis examples with cmake.

2019-09-21 Thread Jean-Bapiste Lepesme via Phabricator via cfe-commits
Jiboo created this revision. Jiboo added a reviewer: chandlerc. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Without this patch, the clang Analysis plugin examples (in clang/lib/Analysis/plugins) are always built and installed even if CLANG_BUILD_EXAMPLES is OFF.