[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

Javier-varez added a comment. Thanks for taking care of this Roy and helping me out through the process! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127593/new/ https://reviews.llvm.org/D127593 ___ cfe

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

Javier-varez added a comment. For referente, I run the tests without this change on commit: commit 94d1692aa155adf3b69609d142762b8c696e0710 (upstream/main, upstream/HEAD) Author: Fangrui Song Date: Tue Jun 14 21:25:56 2022 -0700 [MC] Remove unused MCStreamer::SwitchSection

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

Javier-varez added a comment. I had the same failures with and without this change. It looks like these tests are already broken upstream. Without this patch: Unsupported: 15 Passed : 50 Failed : 232 With this patch: Unsupported: 15 Passed : 50 Failed : 232 R

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

Javier-varez added a comment. I did try this locally and the built test binaries seem to crash with a segmentation fault. I run one of them in lldb to check the error and I got this backtrace: llvm-project/build on  fix-trivially-copyable-check [?⇕] via △ v3.22.3 took 3s ❯ lldb /Users/javi

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

Javier-varez updated this revision to Diff 437033. Javier-varez added a comment. Rebase on main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127593/new/ https://reviews.llvm.org/D127593 Files: clang-tools-extra/test/clang-tidy/checkers/moderniz

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

Javier-varez added a comment. Thanks again for having another look at the changes! I do not have commit access since this is my first change to LLVM. I would appreciate if you could merge it. here's my username and email: Javier Alvarez And let me know if there's anything else you'd like to mo

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

Javier-varez updated this revision to Diff 436871. Javier-varez marked 2 inline comments as done. Javier-varez added a comment. Address review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127593/new/ https://reviews.llvm.org/D127593 File

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

Javier-varez added a comment. Thanks for the review! Indeed this looks like it implements the defect report dr2171. I didn't realize there was a defect report about this, thanks for bringing it up. I am not sure If this behavior should also change for move constructors, but clang currently cann

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

Javier-varez updated this revision to Diff 436516. Javier-varez added a comment. - Preseve ABI when clang is invoked with -fclang-abi-compat <= 14. - Add test for defect report in `clang/test/CXX/drs/dr21xx.cpp`. - Refactor ConstArg to remove if condition. Repository: rG LLVM Github Monorepo

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

Javier-varez updated this revision to Diff 436207. Javier-varez added a comment. Herald added a project: clang-tools-extra. Fix clang-tidy tests and run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127593/new/ https://reviews.llvm.org

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

Javier-varez created this revision. Herald added a project: All. Javier-varez requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. >From [class.copy.ctor]: A non-template constructor for class X is a copy constructor if its first parameter