[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

jankratochvil abandoned this revision. jankratochvil added a comment. Thanks for the reminder, I have todolisted it now for myself but for now I am abandoning it as I cannot promise anything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71707/new/

[PATCH] D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr

jankratochvil updated this revision to Diff 350900. jankratochvil edited the summary of this revision. jankratochvil added a comment. This patch now requires: D101236 , D103910 and D103966 .

[PATCH] D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr

jankratochvil added a comment. [Dwarf-Discuss] How to map [[no_unique_address]] into DWARF: http://lists.dwarfstd.org/pipermail/dwarf-discuss-dwarfstd.org/2021-June/004825.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101237/new/ https://revi

[PATCH] D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr

jankratochvil added inline comments. Comment at: llvm/include/llvm/IR/DebugInfoFlags.def:62 +// FIXME: Move it to ReservedBit4? +HANDLE_DI_FLAG((1 << 30), IsZeroSize) This would need to be handled better if approved. Repository: rG LLVM Github Monorepo CHA

[PATCH] D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr

jankratochvil updated this revision to Diff 350361. jankratochvil added a comment. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, sstefan1, martong, hiraditya. Herald added a reviewer: shafik. Herald added a reviewer: jdoerfert. Herald added a reviewer: shafik. Herald added proje

[PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

jankratochvil updated this revision to Diff 347478. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101236/new/ https://reviews.llvm.org/D101236 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST/ASTImporterTest.cpp lldb/source/Plugins/Typ

[PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

jankratochvil added a comment. cat >1.cpp < struct DWrapper {}; typedef DWrapper DW; struct B { DW spd; } b; struct E { B &b_ref = b; static DW f() { return {}; } } e; EOH $ (set -ex;./bin/clang -c -o 1.o 1.cpp -Wall -g;./bin/lldb -b ./1.o -o 'p E' -o 'p e') (lldb) p

[PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

jankratochvil updated this revision to Diff 347475. jankratochvil added a comment. Update of the testcase but it still does not reproduce the LLDB problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101236/new/ https://reviews.llvm.org/D101236

[PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

jankratochvil added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3684 + return ToAttrOrErr.takeError(); +#if 0 +RecordType *FromRT = It is still not working. The testcase either PASSes despite this `#if 0` or it FAILs even if it is `#if 1`

[PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

jankratochvil updated this revision to Diff 347315. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101236/new/ https://reviews.llvm.org/D101236 Files: clang/lib/AST/ASTImporter.

[PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

jankratochvil abandoned this revision. jankratochvil added a comment. IIUC it will get replaced by D101950 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101236/new/ https://reviews.llvm.org/D101236 _

[PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

jankratochvil added a comment. In D101236#2716317 , @martong wrote: > You can create a similar descendant class, but with the MinimalImport flag > set to true. Then you could call `ImportDefinition` subsequently after an > `Import` call. Perhaps that co

[PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

jankratochvil updated this revision to Diff 342249. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101236/new/ https://reviews.llvm.org/D101236 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST/ASTImporterTest.cpp Index: clang/unittests/A

[PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

jankratochvil planned changes to this revision. jankratochvil added a comment. In D101236#2716286 , @teemperor wrote: > Not sure what the backtrace is for the `clang::FieldDecl::isZeroSize` crash > but what might relevant: That happens only with half of

[PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

jankratochvil updated this revision to Diff 340340. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101236/new/ https://reviews.llvm.org/D101236 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST/ASTImporterTest.cpp Index: clang/unittests/

[PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

jankratochvil created this revision. jankratochvil added reviewers: teemperor, shafik, dblaikie. jankratochvil added a project: clang. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. jankratochvil requested review of this revision. When LLDB needs to use `[[no_unique_addres

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

jankratochvil marked 8 inline comments as done. jankratochvil added a comment. In D71707#1796671 , @aaron.ballman wrote: > I agree that restricting casts to `intptr_t` is too restrictive. Permitted `intptr_t`. But then implemented also checking a cast o

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

jankratochvil updated this revision to Diff 238260. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71707/new/ https://reviews.llvm.org/D71707 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp clang-tools-extra/clang-tidy/bugpron

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

jankratochvil marked 3 inline comments as done. jankratochvil added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:100 + + Check for cast of a pointer to wider (even unsigned) integer. This will + sign-extend the pointer which happens on 32-bit hosts for 6

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

jankratochvil updated this revision to Diff 234787. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71707/new/ https://reviews.llvm.org/D71707 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp clang-tools-extra/clang-tidy/bugpron

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

jankratochvil updated this revision to Diff 234772. jankratochvil added a comment. Wrote the documentation and Release Notes entry, thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71707/new/ https://reviews.llvm.org/D71707 Fil

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

jankratochvil added a subscriber: labath. jankratochvil added a comment. In D71707#1791280 , @labath wrote: > - disallowing casts to intptr_t seems too restrictive -- I doubt many people > are doing that, but I guess this type exists for a reason, and sin

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

jankratochvil added a comment. Example output: PATH="$PWD/bin:$PATH" ~/redhat/llvm-monorepo/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py -checks='-*,bugprone-pointer-cast-widening' /home/jkratoch/redhat/llvm-monorepo/lldb/source/ Enabled checks: bugprone-pointer-cast-wideni

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

jankratochvil created this revision. jankratochvil added reviewers: labath, alexfh, lebedev.ri. jankratochvil added a project: clang-tools-extra. Herald added subscribers: cfe-commits, kristof.beyls, mgorny. Herald added a project: clang. Check for cast of a pointer to wider (even unsigned) intege

[PATCH] D54535: cmake: z3: Remove EXACT from 4.7.1 after being compatible with 4.8.1

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC347152: cmake: z3: Remove EXACT from 4.7.1 after being compatible with 4.8.1 (authored by jankratochvil, committed by ).

[PATCH] D54535: cmake: z3: Remove EXACT from 4.7.1 after being compatible with 4.8.1

jankratochvil created this revision. jankratochvil added a reviewer: mikhail.ramalho. jankratochvil added a project: clang. Herald added subscribers: cfe-commits, mgorny. D54391 comment by @mikhail.ramalho says: > Since we're supporting version 4.8.1 now

[PATCH] D54391: Fix compatibility with z3-4.8.1

This revision was automatically updated to reflect the committed changes. Closed by commit rL346635: Fix compatibility with z3-4.8.1 (authored by jankratochvil, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D54391?vs=173555&id=173618#

[PATCH] D54391: Fix compatibility with z3-4.8.1

jankratochvil created this revision. jankratochvil added a reviewer: clang. jankratochvil added a project: clang. With `z3-4.8.1` as found in Fedora Rawhide (future Fedora 30) as `z3-devel-4.8.1-1.fc30.x86_64`: ../tools/clang/lib/StaticAnalyzer/Core/Z3ConstraintManager.cpp: In function 'void