[PATCH] D105263: [X86] AVX512FP16 instructions enabling 1/6

vtjnash added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. I was tracking back a recent ABI break (also failing now in gcc 12, so maybe this irregularity is intentional), and was concerned that this commit is observed to cause the platform ABI to change dependin

[PATCH] D120301: clang-tools-extra: Make test dependency on LLVMHello optional

vtjnash added a subscriber: MaskRay. vtjnash added a comment. Seems extra complexity, and less desirable to lose test coverage, when it seems the option may already be unreliable and soon to be deprecated by https://reviews.llvm.org/D119383. @MaskRay is that accurate? Repository: rG LLVM Git

[PATCH] D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests

vtjnash added a comment. Is that a bug in clang or in MSVC2019? We expected that CLANG_PLUGIN_SUPPORT=ON can expose problems with the Windows linker, and we add new tests here for verifying that configuration is functioning as expected. You might need to disable CLANG_PLUGIN_SUPPORT on that tar

[PATCH] D111100: enable plugins for clang-tidy

vtjnash added inline comments. Comment at: clang-tools-extra/test/CMakeLists.txt:91 + if(TARGET CTTestTidyModule) + list(APPEND CLANG_TOOLS_TEST_DEPS CTTestTidyModule LLVMHello) + target_include_directories(CTTestTidyModule PUBLIC BEFORE "${CLANG_TOOLS_SOURCE_DIR}") -

[PATCH] D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d59cfc67ead: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also (authored by vtjnash). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119591/new/ https

[PATCH] D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also

vtjnash added a comment. Okay, this should work now for those cases! Sorry, I kept thinking it was clang/examples that was broken, and missed that it was clang/test that was failing, so I failed to see what I needed to fix there too, so that we were not trying to build the tests in configuratio

[PATCH] D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also

vtjnash updated this revision to Diff 409241. vtjnash added a comment. add one more missing case to check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119591/new/ https://reviews.llvm.org/D119591 Files: clang/CMakeLists.txt clang/examples/Ann

[PATCH] D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also

vtjnash updated this revision to Diff 408498. vtjnash added a comment. fixup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119591/new/ https://reviews.llvm.org/D119591 Files: clang/CMakeLists.txt clang/examples/AnnotateFunctions/CMakeLists.txt

[PATCH] D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also

vtjnash added a comment. We are not going to start exporting plugin support if the user explicitly disabled it with CLANG_PLUGIN_SUPPORT=OFF, but why is it trying to read that directory at all, when it should be disallowed by this PR unless CLANG_PLUGIN_SUPPORT=ON Repository: rG LLVM Github

[PATCH] D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also

vtjnash updated this revision to Diff 408491. vtjnash added a comment. cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119591/new/ https://reviews.llvm.org/D119591 Files: clang/CMakeLists.txt clang/examples/AnnotateFunctions/CMakeLists.t

[PATCH] D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also

vtjnash created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware, mgorny. vtjnash requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The clang-analyzer plugins are not

[PATCH] D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests

vtjnash added a comment. Thanks, if you encounter more issues next week, let me know, and I will continue trying to adjust it to work for all config option combinations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119199/new/ https://reviews.llv

[PATCH] D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG76cad51ba700: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests (authored by vtjnash). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119199/

[PATCH] D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests

vtjnash added a comment. @cristian.adam Is this good now? You are blocking merging this, but I think it is ready to land, and I would like to not hold it up for other people if it is fixing their issues (and the issues you discovered too) Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests

vtjnash updated this revision to Diff 406856. vtjnash added a comment. ensure CLANG_PLUGIN_SUPPORT setting is compatible with llvm_add_library Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119199/new/ https://reviews.llvm.org/D119199 Files: cl

[PATCH] D111100: enable plugins for clang-tidy

vtjnash accepted this revision. vtjnash added a comment. Fixed by D119199 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 ___

[PATCH] D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests

vtjnash created this revision. Herald added a subscriber: mgorny. vtjnash requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Fixes an issue noted in D00 . Repository: rG LLVM Github M

[PATCH] D111100: enable plugins for clang-tidy

vtjnash added a comment. Ah, this looks annoying: there are apparently two flags, CLANG_PLUGIN_SUPPORT and LLVM_ENABLE_PLUGINS, but the existing build for clang uses CLANG_PLUGIN_SUPPORT to turn off the build support and LLVM_ENABLE_PLUGINS to turn off the tests (you might not have noticed this

[PATCH] D111100: enable plugins for clang-tidy

vtjnash added a comment. It is a somewhat worthless test IMO, and might belong better in LLVM itself (where this functionality is defined), but there does not appear to be any other like it currently, and it was requested by a previous reviewer. Comparing to the code in LLVMTestingSupport, does

[PATCH] D111100: enable plugins for clang-tidy

vtjnash closed this revision. vtjnash added a comment. Closed by rG84f137a590e7de25c4105303e5938c40566c2dfb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://rev

[PATCH] D111100: enable plugins for clang-tidy

vtjnash updated this revision to Diff 405105. vtjnash added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 Files: clang-tools-extra/clang-tidy/tool/CMakeLists.txt clang-tools-extra/

[PATCH] D111100: enable plugins for clang-tidy

vtjnash added a comment. I decided it made the most sense to me to go with option 3, so this should be ready to land again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 ___

[PATCH] D111100: enable plugins for clang-tidy

vtjnash updated this revision to Diff 404993. vtjnash added a comment. - Reland "enable plugins for clang-tidy" - fixup! Reland "enable plugins for clang-tidy": Disable the test if the user has disabled support for building it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111100: enable plugins for clang-tidy

vtjnash added a comment. It looks like this is probably the first time that a test was written for a PLUGIN_TOOL, outside of the docs, so we are likely in new territory here :/ There seem to be a couple of paths forward: 1. disable the PLUGIN_TOOL option in cmake if the user has disabled the he

[PATCH] D111100: enable plugins for clang-tidy

vtjnash added a comment. Yes, please push a revert so I can look later. Do you have a link to the buildbot configuration, so I can reproduce that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00

[PATCH] D111100: enable plugins for clang-tidy

This revision was automatically updated to reflect the committed changes. Closed by commit rG36892727e4f1: enable plugins for clang-tidy (authored by vtjnash). Changed prior to commit: https://reviews.llvm.org/D00?vs=401997&id=404294#toc Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D111100: enable plugins for clang-tidy

vtjnash added a comment. @aaron.ballman I think I incorporated all of your feedback. Is this okay for me to merge to main? I would like to get it in before the feature branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://revie

[PATCH] D117895: address review feedback

vtjnash abandoned this revision. vtjnash added a comment. arc error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117895/new/ https://reviews.llvm.org/D117895 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D111100: enable plugins for clang-tidy

vtjnash updated this revision to Diff 401997. vtjnash added a comment. address review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 Files: clang-tools-extra/clang-tidy/tool/CMakeLists.txt c

[PATCH] D117895: address review feedback

vtjnash created this revision. Herald added subscribers: carlosgalvezp, arphaman, mgorny. vtjnash requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D117895 Files:

[PATCH] D111100: enable plugins for clang-tidy

vtjnash added a comment. Thanks! I will work on making those changes Comment at: clang-tools-extra/test/clang-tidy/CTTestTidyModule.cpp:24-25 + + //void registerMatchers(ast_matchers::MatchFinder *Finder) override; + //void check(const ast_matchers::MatchFinder::MatchResult &

[PATCH] D111100: enable plugins for clang-tidy

vtjnash updated this revision to Diff 392835. vtjnash added a comment. fix cmake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 Files: clang-tools-extra/clang-tidy/tool/CMakeLists.txt clang-tools-e

[PATCH] D111100: enable plugins for clang-tidy

vtjnash added a comment. There is clearly some more work to do to get the cmake file to be correct, but was hoping to check this looked like the direction you thought looked right for adding this test, since there isn't an obvious example to follow. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D111100: enable plugins for clang-tidy

vtjnash added a comment. This is probably just a draft, but please let me know what you think Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 ___ cfe-commits ma

[PATCH] D111100: enable plugins for clang-tidy

vtjnash updated this revision to Diff 389658. vtjnash added a comment. enable help Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 Files: clang-tools-extra/clang-tidy/tool/CMakeLists.txt clang-tools-e

[PATCH] D111100: enable plugins for clang-tidy

vtjnash updated this revision to Diff 389656. vtjnash added a comment. oops Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 Files: clang-tools-extra/clang-tidy/tool/CMakeLists.txt clang-tools-extra/cl

[PATCH] D111100: enable plugins for clang-tidy

vtjnash updated this revision to Diff 389655. vtjnash added a comment. oops Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 Files: clang-tools-extra/docs/ReleaseNotes.rst clang-tools-extra/docs/clang-

[PATCH] D111100: enable plugins for clang-tidy

vtjnash updated this revision to Diff 389653. vtjnash added a comment. add release notes, docs mention, and test example Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 Files: clang-tools-extra/clang-ti

[PATCH] D111100: enable plugins for clang-tidy

vtjnash updated this revision to Diff 389652. vtjnash added a comment. Herald added a subscriber: arphaman. add release notes, docs mention, and test example Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00

[PATCH] D114571: add release notes, docs mention, and test example

vtjnash created this revision. Herald added subscribers: arphaman, mgorny. vtjnash requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114571 Files: clang-tools-ext

[PATCH] D111100: enable plugins for clang-tidy

vtjnash added a comment. Yes, this header does everything Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D111100: enable plugins for clang-tidy

vtjnash added a comment. bump? tagging some more people who seemed like possible reviewers. I realized my original list of candidates might have mostly been inactive people. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews

[PATCH] D111100: enable plugins for clang-tidy

vtjnash added a comment. bump? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D111100: enable plugins for clang-tidy

vtjnash added a comment. bump? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D111100: enable plugins for clang-tidy

vtjnash created this revision. Herald added a subscriber: mgorny. vtjnash requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fixes 32739 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D00 Files: clang-tool

[PATCH] D88138: [NPM] Add target specific hook to add passes for New Pass Manager

vtjnash added a comment. I think this, and similar recent commits, are causing the shared library builds to fail some tests if this code gets linked into libLLVM.so: https://bugs.llvm.org/show_bug.cgi?id=48181. I assume it might actually a bug in ld (GNU Binutils for Ubuntu 2.34), as I don't un