Re: [PATCH] D21303: [clang-tidy] Adds performance-returning-type check.

2016-06-21 Thread Jakub Staroń via cfe-commits
staronj removed rL LLVM as the repository for this revision. staronj updated this revision to Diff 61402. staronj marked 8 inline comments as done. staronj added a comment. 1. Name changed to return-value-copy. 2. Changed warning message. 3. Fixed check description. http://reviews.llvm.org/D2130

Re: [PATCH] D21303: [clang-tidy] Adds performance-returning-type check.

2016-06-21 Thread Jakub Staroń via cfe-commits
staronj added inline comments. Comment at: clang-tidy/performance/ReturningTypeCheck.cpp:132 @@ +131,3 @@ + // "constructedType" + auto HasTypeSameAsConstructed = hasType(hasCanonicalType( + ignoringRefsAndConsts(equalsBoundNode("constructedType"; Praze

[PATCH] D21303: [clang-tidy] Adds performance-returning-type check.

2016-06-13 Thread Jakub Staroń via cfe-commits
staronj created this revision. staronj added reviewers: Prazek, alex. staronj added a subscriber: cfe-commits. Adds performance-returning-type check. This check is trying to find places, where one is returning different type than function returning type and when returned object is being copied i

Re: [PATCH] D18745: [clang-tidy] Adds modernize-use-bool-literals check.

2016-05-06 Thread Jakub Staroń via cfe-commits
staronj added inline comments. Comment at: clang-tidy/modernize/UseBoolLiteralsCheck.cpp:56 @@ +55,3 @@ + "converting integer literal to " + "bool%select{| inside a macro}0, use bool literal instead"); + alexfh wrote: > Can you

Re: [PATCH] D18745: [clang-tidy] Adds modernize-use-bool-literals check.

2016-05-06 Thread Jakub Staroń via cfe-commits
staronj updated this revision to Diff 56395. staronj marked 3 inline comments as done. http://reviews.llvm.org/D18745 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseBoolLiteralsCheck.cpp clang-tidy/modernize/UseBoolLiteralsC

Re: [PATCH] D18745: [clang-tidy] Adds modernize-use-bool-literals check.

2016-04-19 Thread Jakub Staroń via cfe-commits
staronj marked 5 inline comments as done. staronj added a comment. http://reviews.llvm.org/D18745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18745: [clang-tidy] Adds modernize-use-bool-literals check.

2016-04-16 Thread Jakub Staroń via cfe-commits
staronj updated the summary for this revision. staronj updated this revision to Diff 53984. staronj added a comment. Check now finds implicit and explicit conversions from integer literal to bool. http://reviews.llvm.org/D18745 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize

Re: [PATCH] D18919: Add check "modernize use using"

2016-04-09 Thread Jakub Staroń via cfe-commits
staronj added inline comments. Comment at: clang-tidy/modernize/UseUsingCheck.h:19 @@ +18,3 @@ + +/// FIXME: Write a short description. +/// Fix the FIXME. Comment at: test/clang-tidy/modernize-use-using.cpp:76 @@ +75,1 @@ +// CHECK-FIXES: using

Re: [PATCH] D18745: [clang-tidy] Adds modernize-use-bool-literals check.

2016-04-06 Thread Jakub Staroń via cfe-commits
staronj updated this revision to Diff 52843. staronj added a comment. 1. Adds newline at the end of modernize-use-bool-literals.rst file. 2. Change names in check test for better readability. 3. Adds some new test cases. http://reviews.llvm.org/D18745 Files: clang-tidy/modernize/CMakeLists.tx

Re: [PATCH] D18745: [clang-tidy] Adds modernize-use-bool-literals check.

2016-04-05 Thread Jakub Staroń via cfe-commits
staronj retitled this revision from "[clang-tidy] Adds misc-use-bool-literals check." to "[clang-tidy] Adds modernize-use-bool-literals check.". staronj updated this revision to Diff 52739. staronj added a comment. 1. Name changed from misc-use-bool-literals to modernize-use-bool-literals. 2. Cod