[clang] [clang] Use range constructors of *Set (NFC) (PR #137574)

2025-04-27 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/137574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ASTMatchers] Simplify isDefaultedHelper (NFC) (PR #137571)

2025-04-27 Thread Jakub Kuderski via cfe-commits
@@ -871,14 +871,11 @@ IteratorT matchesFirstInPointerRange(const MatcherT &Matcher, IteratorT Start, return End; } -template ::value> - * = nullptr> -inline bool isDefaultedHelper(const T *) { +template inline bool isDefaultedHelper(const T *FD) {

[clang] [ASTMatchers] Simplify isDefaultedHelper (NFC) (PR #137571)

2025-04-27 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/137571 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Analysis] Remove has_arg_iterator_range (NFC) (PR #137568)

2025-04-27 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/137568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ASTMatchers] Use llvm::is_detected (NFC) (PR #137560)

2025-04-27 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/137560 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [AMDGPU] Add a new amdgcn.load.to.lds intrinsic (PR #137425)

2025-04-27 Thread Jakub Kuderski via cfe-commits
kuhar wrote: > High level question: I don't understand why you call this a "gather" > operation. What do you mean by that? Isn't it semantically just a memcpy, or > a (global/buffer) load followed by a (LDS) store? This is more like a subgroup operation because the destination offset is unifo

[clang] [lld] [llvm] [mlir] [NFC] Use more isa and isa_and_nonnull instead dyn_cast for predicates (PR #137393)

2025-04-25 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/137393 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] DO NOT MERGE: Identify places that need reserve. (PR #136543)

2025-04-24 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar edited https://github.com/llvm/llvm-project/pull/136543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] DO NOT MERGE: Identify places that need reserve. (PR #136543)

2025-04-24 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar edited https://github.com/llvm/llvm-project/pull/136543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] DO NOT MERGE: Identify places that need reserve. (PR #136543)

2025-04-24 Thread Jakub Kuderski via cfe-commits
@@ -2113,12 +2113,63 @@ void erase(Container &C, ValueType V) { C.erase(std::remove(C.begin(), C.end(), V), C.end()); } +namespace detail { +template +using check_has_member_iterator_category_t = +typename decltype(std::declval().begin())::iterator_category; + +template

[clang] [llvm] DO NOT MERGE: Identify places that need reserve. (PR #136543)

2025-04-24 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar commented: > I understand that you are working on improving the performance of > llvm::append_range. I'm interested and attempted to, but I have very few cycles these days (mostly weekends/holidays). The biggest blocker for me is setting up something I can quickly tes

[clang] [llvm] DO NOT MERGE: Identify places that need reserve. (PR #136543)

2025-04-24 Thread Jakub Kuderski via cfe-commits
@@ -2113,12 +2113,63 @@ void erase(Container &C, ValueType V) { C.erase(std::remove(C.begin(), C.end(), V), C.end()); } +namespace detail { +template +using check_has_member_iterator_category_t = +typename decltype(std::declval().begin())::iterator_category; + +template

[clang] [llvm] DO NOT MERGE: Identify places that need reserve. (PR #136543)

2025-04-24 Thread Jakub Kuderski via cfe-commits
@@ -2113,12 +2113,63 @@ void erase(Container &C, ValueType V) { C.erase(std::remove(C.begin(), C.end(), V), C.end()); } +namespace detail { +template +using check_has_member_iterator_category_t = +typename decltype(std::declval().begin())::iterator_category; + +template

[clang-tools-extra] [clangd] Call hash_combine_range with a range (NFC) (PR #136526)

2025-04-20 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/136526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Call hash_combine_range with a range (NFC) (PR #136525)

2025-04-20 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/136525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tools-extra] Use llvm::unique (NFC) (PR #136514)

2025-04-20 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/136514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Use llvm::unique (NFC) (PR #136469)

2025-04-19 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/136469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Use llvm::unique (NFC) (PR #136470)

2025-04-19 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/136470 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Use llvm::SmallVector::pop_back_val (NFC) (PR #136451)

2025-04-19 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/136451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Use llvm::append_range (NFC) (PR #136448)

2025-04-19 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/136448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] llvm::append_range (NFC) (PR #136440)

2025-04-19 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/136440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Use llvm::less_second (NFC) (PR #136396)

2025-04-18 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/136396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Serialization] Use llvm::map_range (NFC) (PR #135990)

2025-04-16 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/135990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Frontend] Use StringRef::ends_with (NFC) (PR #135988)

2025-04-16 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/135988 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Serialization] Use llvm::map_range (NFC) (PR #135990)

2025-04-16 Thread Jakub Kuderski via cfe-commits
@@ -103,11 +103,9 @@ template class MultiOnDiskHashTable { /// The current set of on-disk tables. table_range tables() { -auto Begin = Tables.begin(), End = Tables.end(); -if (getMergedTable()) - ++Begin; -return llvm::make_range(llvm::map_iterator(Begin,

[clang] [Sema] Use llvm::erase_if (NFC) (PR #135574)

2025-04-13 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/135574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Use llvm::erase_if (NFC) (PR #134017)

2025-04-01 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/134017 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Use DenseMap::insert_range (NFC) (PR #133844)

2025-03-31 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/133844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Use DenseMap::insert_range (NFC) (PR #133655)

2025-03-30 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/133655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Basic] Use SmallSet::insert_range (NFC) (PR #133594)

2025-03-29 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/133594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tools-extra] Use *Set::insert_range (NFC) (PR #133589)

2025-03-29 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/133589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Use llvm::reverse (NFC) (PR #133550)

2025-03-28 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/133550 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Format] Use a range constructor of DenseSet (NFC) (PR #133382)

2025-03-28 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/133382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ADT] Remove old range constructors of SmallSet and StringSet (PR #133205)

2025-03-27 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/133205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] Fix typo "tranpose" (PR #124929)

2025-01-29 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/124929 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Separate parsing of modulemaps (PR #119740)

2025-01-10 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar dismissed https://github.com/llvm/llvm-project/pull/119740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] Remove `StringLiteral` in favor of `StringRef` (PR #122366)

2025-01-09 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar commented: Note that now we also have a new type for string tables: https://github.com/llvm/llvm-project/pull/119488 which doesn't result in relocations https://github.com/llvm/llvm-project/pull/122366 ___ cfe-commits mailing

[clang] [llvm] [clang][modules] Separate parsing of modulemaps (PR #119740)

2024-12-12 Thread Jakub Kuderski via cfe-commits
@@ -2596,6 +2596,15 @@ template using has_sizeof = decltype(sizeof(T)); template constexpr bool is_incomplete_v = !is_detected::value; +//===--===// +// Extra additions to +//===---

[clang] [llvm] [clang][modules] Separate parsing of modulemaps (PR #119740)

2024-12-12 Thread Jakub Kuderski via cfe-commits
@@ -2596,6 +2596,15 @@ template using has_sizeof = decltype(sizeof(T)); template constexpr bool is_incomplete_v = !is_detected::value; +//===--===// +// Extra additions to +//===---

[clang] [llvm] [clang][modules] Separate parsing of modulemaps (PR #119740)

2024-12-12 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar requested changes to this pull request. https://github.com/llvm/llvm-project/pull/119740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][modules] Separate parsing of modulemaps (PR #119740)

2024-12-12 Thread Jakub Kuderski via cfe-commits
@@ -2596,6 +2596,15 @@ template using has_sizeof = decltype(sizeof(T)); template constexpr bool is_incomplete_v = !is_detected::value; +//===--===// +// Extra additions to +//===---

[clang] [clang] Prefer StringRef::substr(0, N) to slice(0, N) (NFC) (PR #113784)

2024-10-27 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/113784 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NFC] Replace more DenseMaps with SmallDenseMaps (PR #111836)

2024-10-10 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar commented: Could you open a separate PR the code formatting changes? This will make it easier to review. https://github.com/llvm/llvm-project/pull/111836 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] [llvm] [ADT] Simplify SmallSet (PR #109412)

2024-09-20 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. LGTM. Could you also add [NFC] to the PR title? https://github.com/llvm/llvm-project/pull/109412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[clang-tools-extra] [mlir] [NFC] Fix some typos (PR #108355)

2024-09-12 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar requested changes to this pull request. I think this will be easier to review / merge if you split the PR into a few smaller ones, e.g., by project (clang, mlir, llvm, etc.). We could further split it down by stuff that's clearly safe to land (e.g., comments), and thing

[clang-tools-extra] [mlir] [NFC] Fix some typos (PR #108355)

2024-09-12 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar edited https://github.com/llvm/llvm-project/pull/108355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [mlir] [NFC] Fix some typos (PR #108355)

2024-09-12 Thread Jakub Kuderski via cfe-commits
@@ -24,7 +24,7 @@ "eq" "ne" "oeq" - "olt" + "old" kuhar wrote: also here https://github.com/llvm/llvm-project/pull/108355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang-tools-extra] [mlir] [NFC] Fix some typos (PR #108355)

2024-09-12 Thread Jakub Kuderski via cfe-commits
@@ -101,7 +101,7 @@ module.exports = { // $predicate `,` $lhs `,` $rhs attr-dict `:` type($lhs) seq(choice('arith.cmpi', 'arith.cmpf'), field('predicate', - choice('eq', 'ne', 'oeq', 'o

[clang] [flang] [llvm] [mlir] [ADT] Deprecate DenseMap::getOrInsertDefault (PR #107040)

2024-09-03 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/107040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [APFloat] Add APFloat support for FP4 data type (PR #95392)

2024-06-13 Thread Jakub Kuderski via cfe-commits
@@ -6907,6 +7028,42 @@ TEST(APFloatTest, ConvertE2M3FToE3M2F) { EXPECT_EQ(status, APFloat::opInexact); } +TEST(APFloatTest, ConvertDoubleToE2M1F) { + bool losesInfo; kuhar wrote: It's an output parameter in `.convert`, so shouldn't matter either way? http

[clang] [llvm] Intrinsic: introduce minimumnum and maximumnum (PR #93841)

2024-06-10 Thread Jakub Kuderski via cfe-commits
@@ -1449,6 +1449,16 @@ inline APFloat minimum(const APFloat &A, const APFloat &B) { return A.isNegative() ? A : B; return B < A ? B : A; } +LLVM_READONLY kuhar wrote: Please add and an empty line before this function and document its semantics. https:/

[clang] [llvm] Intrinsic: introduce minimumnum and maximumnum (PR #93841)

2024-06-10 Thread Jakub Kuderski via cfe-commits
@@ -1462,6 +1472,16 @@ inline APFloat maximum(const APFloat &A, const APFloat &B) { return A.isNegative() ? B : A; return A < B ? B : A; } +LLVM_READONLY kuhar wrote: also here https://github.com/llvm/llvm-project/pull/93841 ___

[clang] [llvm] [APFloat] Add APFloat support for FP6 data types (PR #94735)

2024-06-07 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar edited https://github.com/llvm/llvm-project/pull/94735 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [APFloat] Add APFloat support for FP6 data types (PR #94735)

2024-06-07 Thread Jakub Kuderski via cfe-commits
@@ -68,6 +68,10 @@ enum class fltNonfiniteBehavior { // `fltNanEncoding` enum. We treat all NaNs as quiet, as the available // encodings do not distinguish between signalling and quiet NaN. NanOnly, + + // This behavior is present in Float6E3M2FN and Float6E2M3FN types.

[clang] [llvm] [APFloat] Add APFloat support for FP6 data types (PR #94735)

2024-06-07 Thread Jakub Kuderski via cfe-commits
@@ -1499,16 +1521,18 @@ static void tcSetLeastSignificantBits(APInt::WordType *dst, unsigned parts, /* Handle overflow. Sign is preserved. We either become infinity or the largest finite number. */ IEEEFloat::opStatus IEEEFloat::handleOverflow(roundingMode rounding_mode)

[clang] [llvm] [APFloat] Add APFloat support for FP6 data types (PR #94735)

2024-06-07 Thread Jakub Kuderski via cfe-commits
@@ -68,6 +68,10 @@ enum class fltNonfiniteBehavior { // `fltNanEncoding` enum. We treat all NaNs as quiet, as the available // encodings do not distinguish between signalling and quiet NaN. NanOnly, + + // This behavior is present in Float6E3M2FN and Float6E2M3FN types.

[clang] [llvm] [APFloat] Add APFloat support for FP6 data types (PR #94735)

2024-06-07 Thread Jakub Kuderski via cfe-commits
@@ -878,6 +896,10 @@ void IEEEFloat::copySignificand(const IEEEFloat &rhs) { for the significand. If double or longer, this is a signalling NaN, which may not be ideal. If float, this is QNaN(0). */ void IEEEFloat::makeNaN(bool SNaN, bool Negative, const APInt *fill) {

[clang] [llvm] [AArch64] Add support for Qualcomm Oryon processor (PR #91022)

2024-05-29 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar updated https://github.com/llvm/llvm-project/pull/91022 >From 8aebe46d7fdd15f02a9716718f53b03056ef0d19 Mon Sep 17 00:00:00 2001 From: Wei Zhao Date: Fri, 3 May 2024 22:01:58 + Subject: [PATCH 1/3] [AArch64] Add support for Qualcomm Oryon processor --- clang/test/Dr

[clang-tools-extra] [flang] [lld] [llvm] Use StringRef::operator== instead of StringRef::equals (NFC) (PR #91864)

2024-05-12 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/91864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [clang-tools-extra] [llvm] [mlir][ArithToAMDGPU] Add option for saturating truncation to fp8 (PR #74153)

2024-01-22 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/74153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [mlir] [llvm] [clang] [libcxx] [flang] [clang-tools-extra] [libc] Make SmallVectorImpl destructor protected (PR #71439)

2023-11-07 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. I think we have reached consensus that this is the preferred direction. `SerializeToHsaco` is a tiny detail in the grand scheme of things, and because this PR doesn't make it any worse, I don't think we should be blocked by it. https://githu

[flang] [compiler-rt] [libc] [libcxx] [clang-tools-extra] [llvm] [clang] [mlir] Make SmallVectorImpl destructor protected (PR #71439)

2023-11-06 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar edited https://github.com/llvm/llvm-project/pull/71439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [mlir] [compiler-rt] [clang-tools-extra] [flang] [llvm] [libc] Make SmallVectorImpl destructor protected (PR #71439)

2023-11-06 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar commented: Overall I think this makes sense, but the `SerializeToHsaco` changes look suboptimal https://github.com/llvm/llvm-project/pull/71439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[flang] [compiler-rt] [libc] [libcxx] [clang-tools-extra] [llvm] [clang] [mlir] Make SmallVectorImpl destructor protected (PR #71439)

2023-11-06 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar edited https://github.com/llvm/llvm-project/pull/71439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [libcxx] [libc] [compiler-rt] [llvm] [clang-tools-extra] [clang] [mlir] Make SmallVectorImpl destructor protected (PR #71439)

2023-11-06 Thread Jakub Kuderski via cfe-commits
@@ -95,7 +95,7 @@ class SerializeToHsacoPass std::unique_ptr> serializeISA(const std::string &isa) override; - std::unique_ptr> assembleIsa(const std::string &isa); + std::unique_ptr> assembleIsa(const std::string &isa); kuhar wrote: IMO this should eit

[clang] [Support] Deprecate system_endianness (PR #68279)

2023-10-05 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. nit: typos in the commit/PR message: bit --> big code lgtm https://github.com/llvm/llvm-project/pull/68279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang] Avoid need for SLocEntryLoaded BitVector (PR #67960)

2023-10-03 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar commented: The ADT change looks good to me, I'm not familiar with the clang code though. https://github.com/llvm/llvm-project/pull/67960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] Avoid need for SLocEntryLoaded BitVector (PR #67960)

2023-10-02 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar edited https://github.com/llvm/llvm-project/pull/67960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Avoid need for SLocEntryLoaded BitVector (PR #67960)

2023-10-02 Thread Jakub Kuderski via cfe-commits
@@ -180,6 +180,20 @@ TEST(PagedVectorTest, FillNonTrivialConstructor) { EXPECT_EQ(std::distance(V.materialized_begin(), V.materialized_end()), 10LL); } +// Test that isMaterialized returns true for all the elements +// of the page, not only the one that was accessed. +TEST(P

[clang] Avoid need for SLocEntryLoaded BitVector (PR #67960)

2023-10-02 Thread Jakub Kuderski via cfe-commits
@@ -103,6 +103,14 @@ template class PagedVector { /// Return the size of the vector. [[nodiscard]] size_t size() const { return Size; } + /// @return true in case the element at index @a Index belongs to a page which + /// was already materialised. ku

[clang] Avoid need for SLocEntryLoaded BitVector (PR #67960)

2023-10-02 Thread Jakub Kuderski via cfe-commits
@@ -103,6 +103,12 @@ template class PagedVector { /// Return the size of the vector. [[nodiscard]] size_t size() const { return Size; } + [[nodiscard]] bool isMaterialized(size_t Index) const { kuhar wrote: Could you add a documentation comment above?

[clang] Avoid need for SLocEntryLoaded BitVector (PR #67960)

2023-10-02 Thread Jakub Kuderski via cfe-commits
@@ -103,6 +103,12 @@ template class PagedVector { /// Return the size of the vector. [[nodiscard]] size_t size() const { return Size; } + [[nodiscard]] bool isMaterialized(size_t Index) const { +assert(Index < Size); +assert(Index / PageSize < PageToDataPtrs.siz

[clang] Introduce paged vector (PR #66430)

2023-09-30 Thread Jakub Kuderski via cfe-commits
kuhar wrote: @vgvassilev > I find the use of the macro I proposed cleaner though. Ideally, I think we could have an llvm-specific macro that combines the guard and the check (say `LLVM_EXPECT_DEATH`), so that it's less of a footgun. In any case, the failures should be resolved now, and we can

[clang] Introduce paged vector (PR #66430)

2023-09-30 Thread Jakub Kuderski via cfe-commits
kuhar wrote: Also, don't use have to guard that with `#ifdef EXPECT_DEBUG_DEATH`? https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-30 Thread Jakub Kuderski via cfe-commits
kuhar wrote: @vgvassilev I've seen other tests use the pattern from my fix. Feel free to overwrite with your version if that's preferred. https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[clang] Introduce paged vector (PR #66430)

2023-09-30 Thread Jakub Kuderski via cfe-commits
kuhar wrote: @vvereschaka I submitted a fix for death tests in https://github.com/llvm/llvm-project/commit/8580010672e9ff37b0744927296ca00dbcbef5be https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Introduce paged vector (PR #66430)

2023-09-29 Thread Jakub Kuderski via cfe-commits
@@ -0,0 +1,266 @@ +//===- llvm/ADT/PagedVector.h - 'Lazily allocated' vectors --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-

[clang] Introduce paged vector (PR #66430)

2023-09-29 Thread Jakub Kuderski via cfe-commits
@@ -0,0 +1,266 @@ +//===- llvm/ADT/PagedVector.h - 'Lazily allocated' vectors --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-

[clang] Introduce paged vector (PR #66430)

2023-09-29 Thread Jakub Kuderski via cfe-commits
@@ -0,0 +1,266 @@ +//===- llvm/ADT/PagedVector.h - 'Lazily allocated' vectors --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-

[clang] Introduce paged vector (PR #66430)

2023-09-29 Thread Jakub Kuderski via cfe-commits
@@ -0,0 +1,266 @@ +//===- llvm/ADT/PagedVector.h - 'Lazily allocated' vectors --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-

[clang] Introduce paged vector (PR #66430)

2023-09-29 Thread Jakub Kuderski via cfe-commits
@@ -0,0 +1,266 @@ +//===- llvm/ADT/PagedVector.h - 'Lazily allocated' vectors --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-

[clang] Introduce paged vector (PR #66430)

2023-09-25 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. Thanks for all the changes, LGTM. Please wait for a second approval before submitting if you can. https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang] Introduce paged vector (PR #66430)

2023-09-21 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-21 Thread Jakub Kuderski via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-20 Thread Jakub Kuderski via cfe-commits
@@ -0,0 +1,303 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-19 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-19 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-19 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-19 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Jakub Kuderski via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Jakub Kuderski via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Jakub Kuderski via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Jakub Kuderski via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Jakub Kuderski via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar commented: Thanks for all the fixes, this is looking very good. Did another pass and left some local suggestions. https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Jakub Kuderski via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Jakub Kuderski via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Jakub Kuderski via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Jakub Kuderski via cfe-commits
@@ -1625,6 +1625,38 @@ SmallVector has grown a few other minor advantages over std::vector, causing and is no longer "private to the implementation". A name like ``SmallVectorHeader`` might be more appropriate. +.. _dss_pagedvector: + +llvm/ADT/PagedVector.h +^^

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >