[PATCH] D135466: [clang-format] Add support to remove unnecessary semicolons after function definition

2022-10-07 Thread Jakub Klinkovský via Phabricator via cfe-commits
lahwaacz added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:963 nextToken(/*LevelDifference=*/-AddLevels); HandleVerilogBlockLabel(); owenpan wrote: > The `while` loop would address > https://reviews.llvm.org/D135466#inline-13063

[PATCH] D135466: [clang-format] Add support to remove unnecessary semicolons after function definition

2022-10-07 Thread Jakub Klinkovský via Phabricator via cfe-commits
lahwaacz added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3769 + care should be taken to review code changes made by this option. + NOTE: + Setting this to false will not add `;` where they were missing Nit: the note should probably

[PATCH] D46993: [CUDA] Make std::min/max work when compiling in C++14 mode with a C++11 stdlib.

2018-06-08 Thread Jakub Klinkovský via Phabricator via cfe-commits
lahwaacz added a comment. This revision does not do the right thing because it makes it impossible to use the std::min and std::max functions in __host__ __device__ functions under C++14: https://bugs.llvm.org/show_bug.cgi?id=37753 Repository: rC Clang https://reviews.llvm.org/D46993 ___