[PATCH] D82562: Implement AVX ABI Warning/error

2022-11-01 Thread Jake Li via Phabricator via cfe-commits
jajadude added a comment. Herald added subscribers: StephenFan, pengfei. Herald added a project: All. if (Callee->getReturnType()->isVectorType() && CGM.getContext().getTypeSize(Callee->getReturnType()) > 128) { } I think this condition will make features like ext_vector_type to be warnings

[PATCH] D49303: [CodeGen][ObjC] Treat non-escaping blocks as global blocks to make copy/dispose a no-op

2022-07-25 Thread Jake Li via Phabricator via cfe-commits
jajadude added a comment. Herald added a project: All. @ahatanak @rjmccall What if a block is marked with `noescape` and captures some variables at the same time? Wouldn't that cause problem If the compiler continues to optimize it to `NSConcreteGlobal` type anyway? Repository: rL LLVM CH