[PATCH] D130161: Added command-line options to exclude functions from function instrumentation output.

jlegare abandoned this revision. jlegare added a comment. I appear to have butchered something in trying to apply a patch. I will revisit and resubmit later when I've straightened things out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130161/new

[PATCH] D130161: Added command-line options to exclude functions from function instrumentation output.

jlegare added a comment. @hans To address your concern about loose matching: I went with this approach because it fit my use-case. Do you think that an exact match would be more appropriate? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130161/new

[PATCH] D130161: Added command-line options to exclude functions from function instrumentation output.

jlegare updated this revision to Diff 446210. jlegare added a comment. Addressing review comments. - Dropped argument to ShouldInstrumentFunction(). - Added file name based exclusion, which had accidentally been left out of previous commit. - Added demangler. - Applied git clang-format. Reposi

[PATCH] D130186: Addressing review comments.

jlegare abandoned this revision. jlegare added a comment. This was not supposed to be committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130186/new/ https://reviews.llvm.org/D130186 ___ cfe-commits

[PATCH] D130186: Addressing review comments.

jlegare created this revision. Herald added a project: All. jlegare requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Eliminated the (newly introduced) llvm::Function argument of ShouldInstrumentFunction() and used CurFuncDecl instead. Added

[PATCH] D130161: Added command-line options to exclude functions from function instrumentation output.

jlegare added a comment. @Hans However, to answer your question: the user may not be in a position to change the source where the troublesome functions are located, in order to add the attribute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13016

[PATCH] D130161: Added command-line options to exclude functions from function instrumentation output.

jlegare added a comment. @jhenderson Thanks for the information, I appreciate it. @Hans Thank you for the comments. I'll be looking to address them later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130161/new/ https://reviews.llvm.org/D130161

[PATCH] D130161: Added command-line options to exclude functions from function instrumentation output.

jlegare added a subscriber: jhenderson. jlegare added a comment. @jhenderson Apologies, I'm new to the process here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130161/new/ https://reviews.llvm.org/D130161 ___

[PATCH] D130161: Added command-line options to exclude functions from function instrumentation output.

jlegare created this revision. Herald added a project: All. jlegare requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Two options have been added: -finstrument-functions-exclude-function-list and -finstrument-functions-exclude-file-l