[PATCH] D158582: [AMDGPU] Prepend --no-undefined option for linker instead of append

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0661533e4168: [AMDGPU] Prepend --no-undefined option for linker instead of append (authored by lamb-j). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D158582: [AMDGPU] Prepend --no-undefined option for linker instead of append

lamb-j updated this revision to Diff 552803. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158582/new/ https://reviews.llvm.org/D158582 Files: clang/lib/Driver/ToolChains/AMDGPU.cpp clang/test/Driver/amdgpu-toolchain-opencl.cl clang/test/Drive

[PATCH] D158582: [AMDGPU] Prepend --no-undefined option for linker instead of append

lamb-j retitled this revision from "[AMDGPU] Respect unresolved symbol option if forwarded to linker" to "[AMDGPU] Prepend --no-undefined option for linker instead of append". lamb-j updated this revision to Diff 552777. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D158582: [AMDGPU] Respect unresolved symbol option if forwarded to linker

lamb-j retitled this revision from "WIP: [AMDGPU] Respect unresolved symbol option if forwarded to linker" to "[AMDGPU] Respect unresolved symbol option if forwarded to linker". lamb-j updated this revision to Diff 552775. lamb-j requested review of this revision. Repository: rG LLVM Github Mo

[PATCH] D158582: WIP: [AMDGPU] Respect unresolved symbol option if forwarded to linker

lamb-j retitled this revision from "[AMDGPU] Respect unresolved symbol option if forwarded to linker" to "WIP: [AMDGPU] Respect unresolved symbol option if forwarded to linker". lamb-j edited the summary of this revision. lamb-j updated this revision to Diff 552773. lamb-j planned changes to this

[PATCH] D158582: [AMDGPU] Respect unresolved symbol option if forwarded to linker

lamb-j added a comment. Is void amdgpu::Linker::ConstructJob() constructing a job for the host linker or the device linker? Or both? > The `-Wl` and `-Xlinker` options are intended for the host linker and we > intentionally do not pass them to the device linker. In the example I'm testing, bot

[PATCH] D158582: WIP: [AMDGPU] Respect unresolved symbol option if forwarded to linker

lamb-j created this revision. Herald added subscribers: cfe-commits, kerbowa, tpr, dstuttard, yaxunl, jvesely, kzhuravl. Herald added projects: clang, All. lamb-j requested review of this revision. Herald added subscribers: MaskRay, wdng. Previously, for linking in amdgpu contexts, we always supp

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

lamb-j added inline comments. Comment at: clang/docs/AMDGPUSupport.rst:20 + +Clang supports OpenCL, HIP and OpenMP on amdgpu target. + arsenm wrote: > "on amdgpu target" doesn't sound grammatical "for the //amdgpu// target"? or "on AMD GPU targets?" ==

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

lamb-j added a comment. In D145770#4220246 , @mdtoguchi wrote: > @lamb-j - is it expected for any bundled objects created before your change > without the explicit env field to be able to be unbundled? Newly generated > bundles work as expected given s

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

lamb-j added a comment. Herald added a subscriber: jplehr. Needed to update this after landing with two quick patch fixes: [clang-offload-bundler] Fix test failures and document typo (65fb636bd462) [clang-offload-bundler] Fix error with regex in bundler test (f3b991202689) There were also

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

This revision was automatically updated to reflect the committed changes. Closed by commit rGe48ae0dbd80d: [clang-offload-bundler] Standardize TargetID field for bundler (authored by lamb-j). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145770/new/

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

lamb-j updated this revision to Diff 505227. lamb-j added a comment. Updating commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145770/new/ https://reviews.llvm.org/D145770 Files: clang/docs/ClangOffloadBundler.rst clang/lib/Driver/

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

lamb-j added a comment. In D145770#4190901 , @scott.linder wrote: > Is there a corresponding document update to go along with this? If consumers > of the bundles will begin to rely on this it should be documented that it is > guaranteed by the producer

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

lamb-j updated this revision to Diff 504893. lamb-j added a comment. Adding note to documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145770/new/ https://reviews.llvm.org/D145770 Files: clang/docs/ClangOffloadBundler.rst clang/lib/Dr

[PATCH] D145833: Switch ABI references to env/environment

This revision was automatically updated to reflect the committed changes. Closed by commit rGb47d4df25c69: Switch ABI references to env/environment (authored by lamb-j). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145833/new/ https://reviews.llvm.

[PATCH] D145833: Switch ABI references to env/environment

lamb-j created this revision. Herald added a project: All. lamb-j requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. To be consistent with Triple.h, we update references to the optional fourth triple field from ABI to env or enviornment Repo

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

lamb-j marked an inline comment as done. lamb-j added inline comments. Comment at: clang/test/Driver/clang-offload-bundler.c:2 // REQUIRES: x86-registered-target -// REQUIRES: powerpc-registered-target // UNSUPPORTED: target={{.*}}-darwin{{.*}}, target={{.*}}-aix{{.*}}

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

lamb-j updated this revision to Diff 504310. lamb-j added a comment. Herald added a reviewer: alexander-shaposhnikov. Adding another test, updating existing large test, and switching from ABI to env Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1457

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

lamb-j added a comment. In D145770#4186142 , @yaxunl wrote: > In D145770#4185658 , @lamb-j wrote: > >> In D145770#4184996 , @yaxunl wrote: >> >>> The description needs fix

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

lamb-j added a comment. In D145770#4184996 , @yaxunl wrote: > The description needs fix. "ABI field" should be "environment component". > > Also, we need a clang-offload-bundler test which bundles with a non-canonical > triple and unbundles with a canoni

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

lamb-j created this revision. Herald added a subscriber: kosarev. Herald added a project: All. lamb-j requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a reviewer: jdoerfert. Herald added a project: clang. The bundler accepts both of the foll

[PATCH] D141551: Require input target triples to have Environment field

lamb-j abandoned this revision. lamb-j added a comment. We're ok with env field being blank, so this doesn't accomplish what we need Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141551/new/ https://reviews.llvm.org/D141551 ___

[PATCH] D141551: Require input target triples to have Environment field

lamb-j created this revision. Herald added a project: All. lamb-j requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D141551 Files: clang/lib/Driver/OffloadBundler.cpp

[PATCH] D137275: [Driver][test] Fix test by creating empty archive instead of empty file

lamb-j added a comment. @thakis thanks for reverting that, sorry I didn't see your request sooner! I've switched the patch to use "llvm-ar" instead of "ar", which should solve the issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137275/new/ h

[PATCH] D137275: [Driver][test] Fix test by creating empty archive instead of empty file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b992bcce0c5: [Driver][test] Fix test by creating empty archive instead of empty file (authored by lamb-j). Repository: rG LLVM Github Monorepo C

[PATCH] D137275: [Driver][test] Fix test by creating empty archive instead of empty file

lamb-j created this revision. lamb-j added a reviewer: yaxunl. Herald added a project: All. lamb-j requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D137275 Files: clang/test/

[PATCH] D137175: [Driver][test] Remove one more obselete REQUIRES: clang-driver

lamb-j created this revision. Herald added a project: All. lamb-j requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These were globally removed by 63fbc77 but this one wa

[PATCH] D129873: [clang-offload-bundler] Library-ize ClangOffloadBundler

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0f3f357e26cf: [clang-offload-bundler] Library-ize ClangOffloadBundler (authored by lamb-j). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D129873: [clang-offload-bundler] Library-ize ClangOffloadBundler

lamb-j updated this revision to Diff 447894. lamb-j added a comment. Updating driver cmake to correctly build shared library Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129873/new/ https://reviews.llvm.org/D129873 Files: clang/include/clang/Dr

[PATCH] D129873: [clang-offload-bundler] Library-ize ClangOffloadBundler

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8348c4095600: [clang-offload-bundler] Library-ize ClangOffloadBundler (authored by lamb-j). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D129873: [clang-offload-bundler] Library-ize ClangOffloadBundler

lamb-j updated this revision to Diff 447531. lamb-j added a comment. Removing trailing whitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129873/new/ https://reviews.llvm.org/D129873 Files: clang/include/clang/Driver/OffloadBundler.h cla

[PATCH] D129873: [clang-offload-bundler] Library-ize ClangOffloadBundler

lamb-j updated this revision to Diff 446946. lamb-j added a comment. Fixing header typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129873/new/ https://reviews.llvm.org/D129873 Files: clang/include/clang/Driver/OffloadBundler.h clang/lib/Dri

[PATCH] D129873: [clang-offload-bundler] Library-ize ClangOffloadBundler

lamb-j updated this revision to Diff 446945. lamb-j added a comment. Switching pointers to references, adding namespace comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129873/new/ https://reviews.llvm.org/D129873 Files: clang/include/clang

[PATCH] D129873: [clang-offload-bundler] Library-ize ClangOffloadBundler

lamb-j updated this revision to Diff 445865. lamb-j added a comment. Bug fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129873/new/ https://reviews.llvm.org/D129873 Files: clang/include/clang/Driver/OffloadBundler.h clang/lib/Driver/CMakeLi

[PATCH] D129873: [clang-offload-bundler] Library-ize ClangOffloadBundler

lamb-j updated this revision to Diff 445863. lamb-j added a comment. Moving classes into clang namespace, more specific name for config class Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129873/new/ https://reviews.llvm.org/D129873 Files: clang

[PATCH] D129305: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (4/4)

lamb-j abandoned this revision. lamb-j added a comment. Abandoned in favor of combined patch: https://reviews.llvm.org/D129873 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129305/new/ https://reviews.llvm.org/D129305 _

[PATCH] D129304: [clang-offload-bundler] Library-ize ClangOffloadBundler (3/4)

lamb-j abandoned this revision. lamb-j added a comment. Abandoned in favor of combined patch: https://reviews.llvm.org/D129873 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129304/new/ https://reviews.llvm.org/D129304 _

[PATCH] D129303: [clang-offload-bundler] Library-ize ClangOffloadBundler (2/4)

lamb-j abandoned this revision. lamb-j added a comment. Abandoned in favor of combined patch: https://reviews.llvm.org/D129873 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129303/new/ https://reviews.llvm.org/D129303 _

[PATCH] D129301: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (1/4)

lamb-j abandoned this revision. lamb-j added a comment. Abandoned in favor of combined patch: https://reviews.llvm.org/D129873 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129301/new/ https://reviews.llvm.org/D129301 _

[PATCH] D129873: [clang-offload-bundler] Library-ize ClangOffloadBundler

lamb-j created this revision. Herald added a subscriber: mgorny. Herald added a reviewer: alexander-shaposhnikov. Herald added a project: All. lamb-j requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a reviewer: jdoerfert. Herald added a proje

[PATCH] D129301: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (1/4)

lamb-j added a comment. @yaxunl Are you recommending I combine all 4 patches down into 1 patch? Or combine a subset of patches? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129301/new/ https://reviews.llvm.org/D129301 ___

[PATCH] D129305: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (4/4)

lamb-j created this revision. lamb-j added reviewers: kzhuravl, scott.linder, yaxunl. Herald added a subscriber: mgorny. Herald added a project: All. lamb-j requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Lifting the core functional

[PATCH] D129304: [clang-offload-bundler] Library-ize ClangOffloadBundler (3/4)

lamb-j created this revision. lamb-j added reviewers: kzhuravl, scott.linder, yaxunl. Herald added a reviewer: alexander-shaposhnikov. Herald added a project: All. lamb-j requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Lifting the core func

[PATCH] D129303: [clang-offload-bundler] Library-ize ClangOffloadBundler (2/4)

lamb-j created this revision. lamb-j added reviewers: kzhuravl, scott.linder, yaxunl. Herald added a reviewer: alexander-shaposhnikov. Herald added a project: All. lamb-j requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Lifting the core func

[PATCH] D129301: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (1/4)

lamb-j updated this revision to Diff 442945. lamb-j added a comment. Adding clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129301/new/ https://reviews.llvm.org/D129301 Files: clang/tools/clang-offload-bundler/CMakeLists.txt clang/t

[PATCH] D129301: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (1/4)

lamb-j created this revision. lamb-j added reviewers: kzhuravl, scott.linder, yaxunl. Herald added a subscriber: mgorny. Herald added a reviewer: alexander-shaposhnikov. Herald added a project: All. lamb-j requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribe

[PATCH] D129300: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (4/4)

lamb-j created this revision. lamb-j added reviewers: kzhuravl, scott.linder, yaxunl. Herald added a subscriber: mgorny. Herald added a project: All. lamb-j requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Lifting the core functional

[PATCH] D129258: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (4/4)

lamb-j created this revision. Herald added a subscriber: mgorny. Herald added a project: All. lamb-j requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Lifting the core functionalities of the clang-offload-bundler into a user-facing li

[PATCH] D124151: [clang][HIP] Updating driver to enable archive/bitcode to bitcode linking when targeting HIPAMD toolchain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGafcc6baac52f: [clang][HIP] Updating driver to enable archive/bitcode to bitcode linking when… (authored by lamb-j). Repository: rG LLVM Github Mon

[PATCH] D124151: [clang][HIP] Updating driver to enable archive/bitcode to bitcode linking when targeting HIPAMD toolchain

lamb-j updated this revision to Diff 424111. lamb-j added a comment. Adding clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124151/new/ https://reviews.llvm.org/D124151 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains/

[PATCH] D124151: [clang][HIP] Updating driver to enable archive/bitcode to bitcode linking when targeting HIPAMD toolchain

lamb-j updated this revision to Diff 424110. lamb-j added a comment. Adding clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124151/new/ https://reviews.llvm.org/D124151 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains/

[PATCH] D124151: [clang][HIP] Updating driver to enable archive/bitcode to bitcode linking when targeting HIPAMD toolchain

lamb-j created this revision. lamb-j added reviewers: yaxunl, kzhuravl. Herald added a project: All. lamb-j requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a reviewer: jdoerfert. Herald added a project: clang. Repository: rG LLVM Github M