[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

2022-08-14 Thread Isuru Fernando via Phabricator via cfe-commits
isuruf added a comment. > Could you elaborate on this? Sure. If an application links to `libclang.so` when the application is being built, the application will hardcode `libclang.so.13` in it and will look for it. When the SONAME changes to `libclang.so.15` in LLVM 15, the application will not

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

2022-08-11 Thread Isuru Fernando via Phabricator via cfe-commits
isuruf added a comment. Maybe this should be a cmake option that is off by default and I can turn it for my builds? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129160/new/ https://reviews.llvm.org/D129160 ___

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

2022-08-11 Thread Isuru Fernando via Phabricator via cfe-commits
isuruf added a comment. As a downstream packager of libclang, I really like the SONAME not changing in libclang. It makes it possible for us to package things like qt that depend on libclang, but not have to rebuild qt for every major revision of LLVM. It's not clear to me what the reason for re

[PATCH] D85562: [clang] Allow cross-compiling in standalone builds

2020-08-07 Thread Isuru Fernando via Phabricator via cfe-commits
isuruf created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. isuruf requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85562 Files: clang/CMakeLists.txt Index: clang/CMakeLists.txt

[PATCH] D53476: [clang-cl] Allowed -fopenmp work and link openmp library from per-runtime library directory

2019-08-21 Thread Isuru Fernando via Phabricator via cfe-commits
isuruf added a comment. Herald added a reviewer: jdoerfert. Herald added a project: clang. Was this patch merged in clang? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53476/new/ https://reviews.llvm.org/D53476 ___

[PATCH] D66393: Set version for libclang

2019-08-18 Thread Isuru Fernando via Phabricator via cfe-commits
isuruf updated this revision to Diff 215782. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66393/new/ https://reviews.llvm.org/D66393 Files: tools/libclang/CMakeLists.txt Index: tools/libclang/CMakeLists.txt === --- tool

[PATCH] D66393: Set version for libclang

2019-08-18 Thread Isuru Fernando via Phabricator via cfe-commits
isuruf created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. isuruf added a reviewer: clang. isuruf updated this revision to Diff 215782. This sets the compatibility version to major version and current version to the full version and also creates sym