[clang-tools-extra] [clang-tidy] Rename `google-readability-casting` to `modernize-avoid-c-style-cast` (PR #171058)

2025-12-11 Thread Islam Imad via cfe-commits
Islam-Imad wrote: > > First of all, sorry about these failure and errors. I am wondering why such > > errors weren't triggered on my local machine ? After some updates i rebuild > > and run the tests . I will investigate more in this problem :) > > The latter comment about failure seems outdat

[clang-tools-extra] [clang-tidy] Rename `google-readability-casting` to `modernize-avoid-c-style-cast` (PR #171058)

2025-12-11 Thread Islam Imad via cfe-commits
Islam-Imad wrote: > No worries! As for why it happens in CI but not locally: are you maybe on > Windows and using Microsoft's toolchain? CI uses Linux, so that could be the > source of the difference (just a guess though). I use Ubuntu 24 :) llvm project consumes around 32 G The tests take aro

[clang-tools-extra] [clang-tidy] Rename `google-readability-casting` to `modernize-avoid-c-style-cast` (PR #171058)

2025-12-11 Thread Islam Imad via cfe-commits
Islam-Imad wrote: First of all, sorry about these failure and errors. I am wondering why such errors weren't triggered on my local machine ? After some updates i rebuild and run the tests . I will investigate more in this problem :) https://github.com/llvm/llvm-project/pull/171058 _

[clang-tools-extra] [clang-tidy] Fix documentation in `modernize-avoid-c-style-cast` (PR #171413)

2025-12-09 Thread Islam Imad via cfe-commits
Islam-Imad wrote: > Related discussion: [#171058 > (comment)](https://github.com/llvm/llvm-project/pull/171058#discussion_r2602100364) Sorry about that 😐 but I only moved the requested lines from past review https://github.com/llvm/llvm-project/pull/171413 ___

[clang-tools-extra] [clang-tidy] Rename `google-readability-casting` to `modernize-avoid-c-style-cast` (PR #171058)

2025-12-09 Thread Islam Imad via cfe-commits
Islam-Imad wrote: > I'll help merge this PR later, thanks for the fix :) Thanks for your time :) https://github.com/llvm/llvm-project/pull/171058 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang-tools-extra] [clang-tidy] Rename `google-readability-casting` to `modernize-avoid-c-style-cast` (PR #171058)

2025-12-09 Thread Islam Imad via cfe-commits
@@ -0,0 +1,35 @@ +.. title:: clang-tidy - modernize-avoid-c-style-cast + +modernize-avoid-c-style-cast + + +This check is similar to `-Wold-style-cast`, but it suggests automated fixes +in some cases. The reported locations should not be different from

[clang-tools-extra] [clang-tidy] Rename `google-readability-casting` to `modernize-avoid-c-style-cast` (PR #171058)

2025-12-09 Thread Islam Imad via cfe-commits
https://github.com/Islam-Imad updated https://github.com/llvm/llvm-project/pull/171058 >From b0e4d736d9085f0db54a9267883ce7fdbd118ce6 Mon Sep 17 00:00:00 2001 From: Islam-Imad Date: Sun, 7 Dec 2025 23:28:22 +0200 Subject: [PATCH 1/7] [clang-tidy] Rename google-readability-casting to modernize-

[clang-tools-extra] [clang-tidy] Rename google-readability-casting to modernize-avoid-c-style-cast (PR #171058)

2025-12-08 Thread Islam Imad via cfe-commits
@@ -0,0 +1,35 @@ +.. title:: clang-tidy - modernize-avoid-c-style-cast + +modernize-avoid-c-style-cast + + +This check is similar to ``-Wold-style-cast``, but it suggests automated fixes Islam-Imad wrote: Both Fixed :) https://github.

[clang-tools-extra] [clang-tidy] Rename google-readability-casting to modernize-avoid-c-style-cast (PR #171058)

2025-12-08 Thread Islam Imad via cfe-commits
https://github.com/Islam-Imad updated https://github.com/llvm/llvm-project/pull/171058 >From b0e4d736d9085f0db54a9267883ce7fdbd118ce6 Mon Sep 17 00:00:00 2001 From: Islam-Imad Date: Sun, 7 Dec 2025 23:28:22 +0200 Subject: [PATCH 1/6] [clang-tidy] Rename google-readability-casting to modernize-

[clang-tools-extra] [clang-tidy] Rename google-readability-casting to modernize-avoid-c-style-cast (PR #171058)

2025-12-08 Thread Islam Imad via cfe-commits
https://github.com/Islam-Imad updated https://github.com/llvm/llvm-project/pull/171058 >From b0e4d736d9085f0db54a9267883ce7fdbd118ce6 Mon Sep 17 00:00:00 2001 From: Islam-Imad Date: Sun, 7 Dec 2025 23:28:22 +0200 Subject: [PATCH 1/5] [clang-tidy] Rename google-readability-casting to modernize-

[clang-tools-extra] [clang-tidy] Rename google-readability-casting to modernize-avoid-c-style-cast (PR #171058)

2025-12-08 Thread Islam Imad via cfe-commits
https://github.com/Islam-Imad updated https://github.com/llvm/llvm-project/pull/171058 >From b0e4d736d9085f0db54a9267883ce7fdbd118ce6 Mon Sep 17 00:00:00 2001 From: Islam-Imad Date: Sun, 7 Dec 2025 23:28:22 +0200 Subject: [PATCH 1/4] [clang-tidy] Rename google-readability-casting to modernize-

[clang-tools-extra] [clang-tidy] Rename google-readability-casting to modernize-avoid-c-style-cast (PR #171058)

2025-12-08 Thread Islam Imad via cfe-commits
@@ -0,0 +1,14 @@ +.. title:: clang-tidy - modernize-avoid-c-style-cast + +modernize-avoid-c-style-cast + + +Finds usages of C-style casts. + +https://google.github.io/styleguide/cppguide.html#Casting Islam-Imad wrote: for the descripti

[clang-tools-extra] [clang-tidy] Rename google-readability-casting to modernize-avoid-c-style-cast (PR #171058)

2025-12-08 Thread Islam Imad via cfe-commits
Islam-Imad wrote: i changed it. should i also change the class name ? https://github.com/llvm/llvm-project/pull/171058 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/lis

[clang-tools-extra] [clang-tidy] Rename google-readability-casting to modernize-avoid-c-style-cast (PR #171058)

2025-12-08 Thread Islam Imad via cfe-commits
@@ -3,12 +3,4 @@ google-readability-casting == -Finds usages of C-style casts. - -https://google.github.io/styleguide/cppguide.html#Casting - -Corresponding cpplint.py check name: `readability/casting`. - -This check is similar to ``-Wold-style-cast``,

[clang-tools-extra] [clang-tidy] Rename google-readability-casting to modernize-avoid-c-style-cast (PR #171058)

2025-12-08 Thread Islam Imad via cfe-commits
https://github.com/Islam-Imad updated https://github.com/llvm/llvm-project/pull/171058 >From b0e4d736d9085f0db54a9267883ce7fdbd118ce6 Mon Sep 17 00:00:00 2001 From: Islam-Imad Date: Sun, 7 Dec 2025 23:28:22 +0200 Subject: [PATCH 1/3] [clang-tidy] Rename google-readability-casting to modernize-

[clang-tools-extra] [clang-tidy] Rename google-readability-casting to modernize-avoid-c-style-cast (PR #171058)

2025-12-07 Thread Islam Imad via cfe-commits
https://github.com/Islam-Imad updated https://github.com/llvm/llvm-project/pull/171058 >From b0e4d736d9085f0db54a9267883ce7fdbd118ce6 Mon Sep 17 00:00:00 2001 From: Islam-Imad Date: Sun, 7 Dec 2025 23:28:22 +0200 Subject: [PATCH 1/2] [clang-tidy] Rename google-readability-casting to modernize-

[clang-tools-extra] [clang-tidy] Rename google-readability-casting to modernize-avoid-c-style-cast (PR #171058)

2025-12-07 Thread Islam Imad via cfe-commits
https://github.com/Islam-Imad created https://github.com/llvm/llvm-project/pull/171058 [clang-tidy] Rename google-readability-casting to modernize-avoid-c-style-cast The old name is kept as an alias for backward compatibility. Fixes #170978 >From b0e4d736d9085f0db54a9267883ce7fdbd118ce6 Mon S

[clang] [clang][bytecode] Unify elementwise integer builtins using callback pattern (PR #169957)

2025-11-29 Thread Islam Imad via cfe-commits
Islam-Imad wrote: Hi @RKSimon , I hope you're doing well. I noticed the buildbot reported some failures after my PR was merged. Could you help me understand how these are related to my changes? Thank you for your time! https://github.com/llvm/llvm-project/pull/169957

[clang] [clang][bytecode] Unify elementwise integer builtins using callback pattern (PR #169957)

2025-11-29 Thread Islam Imad via cfe-commits
https://github.com/Islam-Imad updated https://github.com/llvm/llvm-project/pull/169957 >From a9630d7ab31a6312b6940e22b0097b0e544e2512 Mon Sep 17 00:00:00 2001 From: Islam-Imad Date: Fri, 28 Nov 2025 22:22:44 +0200 Subject: [PATCH] [clang][bytecode] Unify elementwise integer builtins using call

[clang] [clang][bytecode] Unify elementwise integer builtins using callback pattern (PR #169957)

2025-11-28 Thread Islam Imad via cfe-commits
https://github.com/Islam-Imad created https://github.com/llvm/llvm-project/pull/169957 This patch refactors the handling of elementwise integer unary operations to use a unified callback-based approach, eliminating code duplication. Changes: - Extended interp__builtin_elementwise_int_unaryop t

[clang] [clang][bytecode] Unify elementwise integer builtins using callback pattern (PR #169957)

2025-11-28 Thread Islam Imad via cfe-commits
https://github.com/Islam-Imad updated https://github.com/llvm/llvm-project/pull/169957 >From a9630d7ab31a6312b6940e22b0097b0e544e2512 Mon Sep 17 00:00:00 2001 From: Islam-Imad Date: Fri, 28 Nov 2025 22:22:44 +0200 Subject: [PATCH] [clang][bytecode] Unify elementwise integer builtins using call