ilya-palachev updated this revision to Diff 123558.
ilya-palachev added a comment.
Ok, I agree, this test file is rather better.
https://reviews.llvm.org/D40073
Files:
lib/Analysis/CFG.cpp
test/Analysis/cfg-indirect-goto-determinism.cpp
Index: test/Analysis/cfg-indirect-goto-determinism.cp
ilya-palachev updated this revision to Diff 123016.
ilya-palachev added a comment.
Slightly changed the number of max-nodes, since previous one was maximum
possible on my local branch, and it doesn't work for upstream. The behavior
with number 500 seems more stable. With it, we have 4 different
ilya-palachev created this revision.
Herald added subscribers: szepet, xazax.hun.
Current CFG is built in non-deterministic order due to the fact that indirect
goto labels' declarations (LabelDecl's) are stored in the llvm::SmallSet
container. LabelDecl's are pointers, whose order is not determi
ilya-palachev added a comment.
Hi! Thanks for this patch.
We're building Android6 with Clang (in order to apply static analyzer on it),
and without this patch we've 613 build failures. This patch helps to get rid of
521 of those build failures (85%).
"Works for me".
Comment
ilya-palachev abandoned this revision.
ilya-palachev added a comment.
Ok, then, if you see no problem in dual edges, I'm abandoning this revision.
Repository:
rL LLVM
https://reviews.llvm.org/D27710
___
cfe-commits mailing list
cfe-commits@lists.
ilya-palachev added a comment.
Thanks for review!
> As Artem points out, the checkers in tree do not create a node for every bug
> reported - there is no reason to do that.
Yes... But why does `generateNonFatalErrorNode` return `nullptr` in case when
the node already exists? Isn't it designed
ilya-palachev added a comment.
In https://reviews.llvm.org/D27710#628069, @zaks.anna wrote:
> Are there any negative effects from having the duplicates in edges?
Yes, you're right; in current implementation there seems to be no negative
effects from this, since duplicate edges are quite rare,
ilya-palachev removed rL LLVM as the repository for this revision.
ilya-palachev updated this revision to Diff 81221.
ilya-palachev added a comment.
Fixed a typo
https://reviews.llvm.org/D27710
Files:
lib/StaticAnalyzer/Core/CoreEngine.cpp
lib/StaticAnalyzer/Core/ExplodedGraph.cpp
Index:
ilya-palachev created this revision.
ilya-palachev added reviewers: NoQ, zaks.anna, dcoughlin.
ilya-palachev added subscribers: cfe-commits, a.sidorin, ilya-palachev.
ilya-palachev set the repository for this revision to rL LLVM.
Current implementation doesn't take care about the duplicates in edg
