[PATCH] D148596: [KMSAN] Enable on SystemZ

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa3e56a8792ff: [KMSAN] Enable on SystemZ (authored by iii). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D148596: [KMSAN] Enable on SystemZ

iii updated this revision to Diff 516926. iii added a comment. Herald added a subscriber: hoy. - Fixed an issue with copyRegSaveArea() overwriting shadow of caller's locals. The problem was that the kernel is compiled with "packed-stack", so register save areas may be smaller than 160 bytes. Sin

[PATCH] D148596: [KMSAN] Enable on SystemZ

iii updated this revision to Diff 515661. iii added a comment. - (unsigned)0 -> 0u (0 doesn't work, because the overload becomes ambiguous). - Improve matching in the testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148596/new/ https://revie

[PATCH] D148596: [KMSAN] Enable on SystemZ

iii updated this revision to Diff 515266. iii added a comment. - Add a comment to getOrInsertMsanMetadataFunction(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148596/new/ https://reviews.llvm.org/D148596 Files: clang/lib/Driver/ToolChains/Li

[PATCH] D148596: [KMSAN] Enable on SystemZ

iii updated this revision to Diff 514692. iii added a comment. - Better explain the ABI situation. - Extend the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148596/new/ https://reviews.llvm.org/D148596 Files: clang/lib/Driver/ToolChains/L

[PATCH] D148596: [KMSAN] Enable on SystemZ

iii added a comment. The kernel patch is currently WIP; I'm trying to get rid of false positives. Just some examples of the findings so far: - s390x always uses separate address spaces for kernel and userspace, so we need to skip the `addr < TASK_SIZE` check in `is_bad_asm_addr()`. - There is a

[PATCH] D148596: [KMSAN] Enable on SystemZ

iii created this revision. iii added reviewers: eugenis, vitalybuka, glider, uweigand, jonpa. Herald added subscribers: Enna1, pengfei, hiraditya. Herald added a project: All. iii requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects:

[PATCH] D78644: [LSan] Enable for SystemZ

iii added a comment. I guess the intention is dropping the special case? The following patch passes regtests: --- a/compiler-rt/lib/lsan/lsan_allocator.h +++ b/compiler-rt/lib/lsan/lsan_allocator.h @@ -68,9 +68,6 @@ using PrimaryAllocator = PrimaryAllocatorASVT; # if SANITIZER_FUCHSIA

[PATCH] D78644: [LSan] Enable for SystemZ

iii added a comment. That's where the mappings normally end. Example: $ cat /proc/self/maps 2aa-2aa2000 r--p 5e:01 668061 /usr/bin/cat 2aa2000-2aa6000 r-xp 2000 5e:01 668061 /usr/bin/cat 2aa6000-2aa8000

[PATCH] D105629: [TSan] Add SystemZ support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGacf0a6428681: [sanitizer] Fix __sanitizer_kernel_sigset_t endianness issue (authored by iii). Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D105629: [TSan] Add SystemZ support

iii updated this revision to Diff 358431. iii added a comment. - Fix style issues (seems like arc diff is linting only the top commit?). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105629/new/ https://reviews.llvm.org/D105629 Files: clang/lib/

[PATCH] D105629: [TSan] Add SystemZ support

iii updated this revision to Diff 358363. iii added a comment. Based on Ulrich's feedback I tested the series on RHEL7, which, in addition to an old kernel, contains an old glibc and an old toolchain. This uncovered a few extra issues, which are fixed here: - Call __tls_get_offset() in order to f

[PATCH] D105629: [TSan] Add SystemZ support

iii added inline comments. Comment at: compiler-rt/lib/tsan/rtl/tsan_platform_posix.cpp:123 +#if defined(__s390x__) + ProtectRange(HiAppMemEnd(), 0xf000ull); +#endif uweigand wrote: > iii wrote: > > uweigand wrote: > > > Did you test this on older ke

[PATCH] D105629: [TSan] Add SystemZ support

iii added inline comments. Comment at: compiler-rt/lib/tsan/rtl/tsan_platform_posix.cpp:123 +#if defined(__s390x__) + ProtectRange(HiAppMemEnd(), 0xf000ull); +#endif uweigand wrote: > Did you test this on older kernels without 5-level page table supp

[PATCH] D105629: [TSan] Add SystemZ support

iii marked an inline comment as done. iii added a comment. Regarding the openmp test failures: I tried check-openmp on a x86_64 machine, and they occur both with and without this patch series, so must be unrelated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D105629: [TSan] Add SystemZ support

iii marked an inline comment as done. iii added inline comments. Comment at: compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp:781 + // TSAN. Act as if we ran out of memory. + internal_munmap(res, sz); + errno = errno_ENOMEM; dvyukov wrote: > TS

[PATCH] D105629: [TSan] Add SystemZ support

iii updated this revision to Diff 357889. iii added a comment. - Fix a local variable naming issue CheckAndProtect(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105629/new/ https://reviews.llvm.org/D105629 Files: clang/lib/Driver/ToolChains/L

[PATCH] D105629: [TSan] Add SystemZ support

iii updated this revision to Diff 357471. iii added a comment. - Reserve the address space "tail" in the "[TSan] Define C/C++ address ranges for SystemZ" patch. - Drop the "[TSan] Simulate OOM in mmap_interceptor()" patch. - Group "[TSan] Use zeroext for function parameters" with the common code

[PATCH] D105629: [TSan] Add SystemZ support

iii created this revision. iii added reviewers: kcc, dvyukov, uweigand. Herald added subscribers: jfb, hiraditya, mgorny. iii requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. This patch series implem

[PATCH] D78644: [LSan] Enable for SystemZ

This revision was automatically updated to reflect the committed changes. Closed by commit rGccd8b7b10347: [LSan] Enable for SystemZ (authored by iii). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78644/new/ https://reviews.llvm.org/D78644 Files:

[PATCH] D78644: [LSan] Enable for SystemZ

iii updated this revision to Diff 270771. iii added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78644/new/ https://reviews.llvm.org/D78644 Files: clang/lib/Driver/ToolChains/Linux.cpp compiler-rt/cmake/config-ix.cmake c

[PATCH] D78644: [LSan] Enable for SystemZ

iii created this revision. iii added reviewers: vitalybuka, eugenis, uweigand, jonpa. Herald added subscribers: Sanitizers, cfe-commits, mgorny. Herald added projects: clang, Sanitizers. Add runtime support, adjust the tests and enable LSan. Repository: rG LLVM Github Monorepo https://reviews