[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev added a comment. Hi, I am very glad for your help. :) Author name: `Ilya Kuteev` email: `ilyakut...@icloud.com` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 _

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev added a comment. Hello everyone, can somebody please help me commit this patch to trunk? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 ___ cfe-comm

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev added a comment. @rsmith can you please help with committing patch to trunk? Do not sure if I have correct rights to do it. Were are several failing tests, seems like it is caused by bugs in pre-merge checks (For example this one on win: https://github.com/google/llvm-premerge-checks

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev updated this revision to Diff 375272. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTWriter.cpp clang/test/M

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev updated this revision to Diff 375187. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTWriter.cpp clang/test/Modules/Inputs/AddRemoveIrrelevantModule

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev updated this revision to Diff 374173. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTWriter.cpp clang/test/Modules/Inputs/AddRemoveIrrelevantModule

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev updated this revision to Diff 374156. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTWriter.cpp clang/test/Modules/Inputs/AddRemoveIrrelevantModule

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev updated this revision to Diff 373957. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTWriter.cpp clang/test/Modules/Inputs/AddRemoveIrrelevantModule

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev updated this revision to Diff 373936. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTWriter.cpp clang/test/Modules/Inputs/AddRemoveIrrelevantModule

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev updated this revision to Diff 373862. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTWriter.cpp clang/test/Modules/Inputs/AddRemoveIrrelevantModule

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev updated this revision to Diff 373861. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTWriter.cpp clang/test/Modules/Inputs/AddRemoveIrrelevantModule

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev updated this revision to Diff 373859. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTWriter.cpp clang/test/Modules/Inputs/AddRemoveIrrelevantModule

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev added a comment. Hello everyone! Ping :), need more approves for this patch. @rsmith Thank you for your helpful tips. Can you please review the latest change? I fixed some tests and applied clang format suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev updated this revision to Diff 373179. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTWriter.cpp clang/test/Modules/Inputs/AddRemoveIrrelevantModule

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev updated this revision to Diff 373076. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTWriter.cpp clang/test/Modules/Inputs/AddRemoveIrrelevantModule

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev updated this revision to Diff 373048. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTWriter.cpp clang/test/Modules/Inputs/AddRemoveIrrelevantModule

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev updated this revision to Diff 372989. ilyakuteev marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTWriter.cpp clang/

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev updated this revision to Diff 372563. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTWriter.cpp clang/test/Modules/Inputs/AddRemoveIrrelevantModule

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev added a comment. Hello everyone! We have very slow remote compilations without this patch. :(. I'll be very grateful for your review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 ___

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev added a comment. @rsmith Can you please check is this a correct way to add headers known to preprocessor? (Lines 173-191) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 ___ cfe-commits m

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev added a comment. Added modules for headers known to HeadersSearch, including textual ones. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev updated this revision to Diff 365969. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTWriter.cpp Index: clang/lib/Serialization/ASTWriter.cpp ===

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev updated this revision to Diff 365968. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Lex/HeaderSearch.h clang/include/clang/Serialization/ASTWriter.h clang/lib/S

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev updated this revision to Diff 365381. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTWriter.cpp Index: clang/

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev updated this revision to Diff 362348. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTWriter.cpp Index: clang/

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev created this revision. ilyakuteev added reviewers: aprantl, dblaikie, rsmith, dexonsmith. ilyakuteev requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Problem: PCM file includes references to all module maps used in compilation whi

[PATCH] D97850: Fix PCM read from ModuleCache for ext4 filesystem

ilyakuteev added a comment. If a fix will be in ModuleManager and only for ModuleCache the problem with symlinks and path will not affect it as ModuleCache is managed by clang and we can rely on it. I agree that using `FileMgr.getBypassFile` is not the best way to solve this problem, we need to

[PATCH] D97850: Fix PCM read from ModuleCache for ext4 filesystem

ilyakuteev added a comment. @teemperor 's test shows the problem correctly. In my case I am working on a dist-compilation system (similar to distcc) for objective-c with `-fmodules`. Our previous generation used tmpfs for module cache and was ephemeral (Unique temp module cache per compilation)

[PATCH] D97850: Fix PCM read from ModuleCache for ext4 filesystem

ilyakuteev created this revision. ilyakuteev requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D97850 Files: clang/lib/Serialization/ModuleManager.cpp Index: clang/lib/Seria