[PATCH] D141008: [Clang][SPIR-V] Emit target extension types for OpenCL types on SPIR-V.

iliya-diyachkov added inline comments. Comment at: clang/lib/CodeGen/CGOpenCLRuntime.cpp:100-112 +llvm::Type *CGOpenCLRuntime::getSamplerType(const Type *T) { + if (!SamplerTy) { +if (llvm::Type *TransTy = CGM.getTargetCodeGenInfo().getOpenCLType( +CGM, CGM.getCo

[PATCH] D130768: [OpenCL][SPIR-V] Add test for extern functions with a pointer

iliya-diyachkov accepted this revision. iliya-diyachkov added a comment. This revision is now accepted and ready to land. Looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130768/new/ https://reviews.llvm.org/D130768 ___ cfe-com

[PATCH] D130766: [SPIR-V] Disable opaque pointers in relese 15

iliya-diyachkov added a comment. Looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130766/new/ https://reviews.llvm.org/D130766 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D127579: [clang][WIP] add option to keep types of ptr args for non-kernel functions in metadata

iliya-diyachkov added a comment. In D127579#3585411 , @Anastasia wrote: > Also is there anything that we don't need from the metadata that are > currently emitted for the use case i.e. for example argument names? This > could reduce the number of metada

[PATCH] D127579: [clang][WIP] add option to keep types of ptr args for non-kernel functions in metadata

iliya-diyachkov created this revision. iliya-diyachkov added reviewers: Anastasia, bader, svenvh. Herald added a subscriber: Naghasan. Herald added a project: All. iliya-diyachkov requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. It's

[PATCH] D125679: [Clang] Added options for integrated backend only used for SPIR-V for now

iliya-diyachkov added a comment. I'm not an expert in clang, but overall the patch looks good to me. Comment at: clang/docs/UsersManual.rst:3640 +Clang also supports integrated generation of SPIR-V without use of ``llvm-spirv`` +tool as an exerimental feature when ``-fintegrat

[PATCH] D124776: [SPIR-V] Allow setting SPIR-V version via target triple

iliya-diyachkov added a comment. @Anastasia, when are you going to add support for v1.5? We would use it in the SPIR-V backend. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124776/new/ https://reviews.llvm.org/D124776 ___ cfe-commits mailin