sugak added a comment.
ping @rsmith
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112481/new/
https://reviews.llvm.org/D112481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.o
sugak updated this revision to Diff 382375.
sugak added a comment.
Updated following @bruno's suggestion, and fixed tests (thanks @weiwang)!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112481/new/
https://reviews.llvm.org/D112481
Files:
clang/
sugak added inline comments.
Comment at: clang/lib/AST/ASTContext.cpp:5640
+ DeducedTemplateSpecializationType::Profile(
+ ID, Template, DeducedType, IsDependent || Template.isDependent());
if (DeducedTemplateSpecializationType *DTST =
bruno wrote:
> Sho
sugak updated this revision to Diff 382109.
sugak added a comment.
apply clang-format suggestion
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112481/new/
https://reviews.llvm.org/D112481
Files:
clang/lib/AST/ASTContext.cpp
Index: clang/lib/AS
sugak created this revision.
sugak added a reviewer: rsmith.
Herald added a subscriber: mgrang.
sugak requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
`DeducedTemplateSpecializationTypes` is a
`llvm::FoldingSet` [1], where
`FoldingSetNod
sugak added subscribers: weiwang, sugak.
sugak added a comment.
Herald added a subscriber: sstefan1.
Hi @yaxunl! I'm working on upgrading a large codebase from LLVM-9 to LLVM-12. I
noticed on average 10% compilation speed regression that seems to be caused
this change. We use Clang modules and h
sugak created this revision.
sugak added reviewers: modocache, sammccall, arthur.j.odwyer.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
sugak edited the summary of this revision.
// Before:
co_yield* x;
co_return* x;
// After:
co_yield *x;
co_return *x;
Add u
sugak added a comment.
@djasper: no, I do not.
https://reviews.llvm.org/D39478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sugak added a comment.
@djasper: ping :)
https://reviews.llvm.org/D39478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sugak added a comment.
@djasper: would you accept and push this for me :)
https://reviews.llvm.org/D39587
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sugak created this revision.
Before:
int operator++(int)noexcept;
After:
int operator++(int) noexcept;
https://reviews.llvm.org/D39587
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
===
sugak updated this revision to Diff 121165.
sugak marked 3 inline comments as done.
sugak added a comment.
Updated per comments.
@djasper : Thank you for the review! Would you commit this for me?
https://reviews.llvm.org/D39478
Files:
lib/Format/UsingDeclarationsSorter.cpp
unittests/Format
sugak added inline comments.
Comment at: lib/Format/UsingDeclarationsSorter.cpp:50
std::string computeUsingDeclarationLabel(const FormatToken *UsingTok) {
assert(UsingTok && UsingTok->is(tok::kw_using) && "Expecting a using token");
std::string Label;
and
sugak created this revision.
This fixes clang-format internal assertion for the following code:
/* override */ using std::string;
Added add a unit test.
https://reviews.llvm.org/D39478
Files:
lib/Format/UsingDeclarationsSorter.cpp
unittests/Format/UsingDeclarationsSorterTest.cpp
Index
14 matches
Mail list logo
