[PATCH] D158371: [clang-tidy] Fix DanglingHandleCheck to work in C++17 and later mode

2023-09-10 Thread Ignat Loskutov via Phabricator via cfe-commits
loskutov added a comment. In D158371#4642758 , @PiotrZSL wrote: > Name / Email (to be used as author) ? Ignat Loskutov Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158371/new/ https://reviews.llvm.org/D

[PATCH] D158371: [clang-tidy] Fix DanglingHandleCheck to work in C++17 and later mode

2023-09-07 Thread Ignat Loskutov via Phabricator via cfe-commits
loskutov added a comment. In D158371#4619348 , @PiotrZSL wrote: > Please wait like 2 weeks before pushing this, so someone else could be able > to verify this if they need. It's been 2 weeks, so I guess nothing prevents from getting this change merged.

[PATCH] D158371: [clang-tidy] Fix DanglingHandleCheck to work in C++17 and later mode

2023-08-21 Thread Ignat Loskutov via Phabricator via cfe-commits
loskutov updated this revision to Diff 552164. loskutov added a comment. git clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158371/new/ https://reviews.llvm.org/D158371 Files: clang-tools-extra/clang-tidy/bugprone/DanglingHandleCheck

[PATCH] D158371: [clang-tidy] Fix DanglingHandleCheck to work in C++17 and later mode

2023-08-20 Thread Ignat Loskutov via Phabricator via cfe-commits
loskutov created this revision. loskutov added reviewers: sbenza, PiotrZSL. loskutov added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. loskutov requested review of this revision. Herald added a sub

[PATCH] D56992: [clang] Mark lambda-to-function-pointer conversion as noexcept

2019-01-21 Thread Ignat Loskutov via Phabricator via cfe-commits
loskutov marked an inline comment as done. loskutov added a comment. Yes, I'm not able to commit by myself, so it would be nice if you did that. Apache 2.0 with LLVM Exceptions is fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56992/new/ https://reviews.llvm.org/D56992

[PATCH] D56992: [clang] Mark lambda-to-function-pointer conversion as noexcept

2019-01-21 Thread Ignat Loskutov via Phabricator via cfe-commits
loskutov updated this revision to Diff 182792. loskutov edited the summary of this revision. loskutov added a comment. Reflected the change in cxx_dr_status.html and specified `-std=c++17` for the test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56992/new/ https://reviews.llvm.org/D

[PATCH] D56992: [clang] Mark lambda-to-function-pointer conversion as noexcept

2019-01-21 Thread Ignat Loskutov via Phabricator via cfe-commits
loskutov updated this revision to Diff 182783. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56992/new/ https://reviews.llvm.org/D56992 Files: clang/lib/Sema/SemaLambda.cpp clang/test/AST/ast-dump-expr.cpp clang/test/CXX/expr/expr.prim/expr.prim.lambda/p9.cpp Index: clang/test/CX

[PATCH] D56992: [clang] Mark lambda-to-function-pointer conversion as noexcept

2019-01-21 Thread Ignat Loskutov via Phabricator via cfe-commits
loskutov updated this revision to Diff 182782. loskutov marked an inline comment as done. loskutov added a comment. Uploaded an updated diff instead of a diff-from-previous-diff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56992/new/ https://reviews.llvm.org/D56992 Files: clang/lib/

[PATCH] D56992: [clang] Mark lambda-to-function-pointer conversion as noexcept

2019-01-21 Thread Ignat Loskutov via Phabricator via cfe-commits
loskutov updated this revision to Diff 182779. loskutov added a comment. Fixed the comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56992/new/ https://reviews.llvm.org/D56992 Files: clang/lib/Sema/SemaLambda.cpp Index: clang/lib/Sema/SemaLambda.cpp ===

[PATCH] D56992: Mark lambda-to-function-pointer conversion as noexcept

2019-01-20 Thread Ignat Loskutov via Phabricator via cfe-commits
loskutov created this revision. loskutov added reviewers: llvm-commits, aaron.ballman, doug.gregor. Herald added a subscriber: cfe-commits. Starting from C++17, [expr.prim.lambda.closure]p9 requires that "The [lambda to function pointer] conversion function [...] has a non-throwing exception spe