[clang-tools-extra] [clang-tidy] support query based custom check (PR #131804)

2025-04-05 Thread Ibraim Ganiev via cfe-commits
olologin wrote: @carlosgalvezp Hi, I tried to explain everything here: https://github.com/llvm/llvm-project/issues/107680 https://github.com/llvm/llvm-project/pull/131804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang-tools-extra] [clang-tidy] support query based custom check (PR #131804)

2025-04-05 Thread Ibraim Ganiev via cfe-commits
olologin wrote: >it sounds like the goal is somewhat less about clang-tidy checks and more >about running code transformations more easily. Original goal was to have just clang-tidy checks. We use it on our CI to guard main branch from people accidentally merging prohibited stuff. If CI informs

[clang-tools-extra] [clang-tidy] support query based custom check (PR #131804)

2025-03-26 Thread Ibraim Ganiev via cfe-commits
olologin wrote: > It would feel safer if the custom check was passed via command-line instead, > similar to --config But then you will not be able to properly disable such checks for subfolders (modules) of some huge project, right? https://github.com/llvm/llvm-project/pull/131804

[clang-tools-extra] [clang-tidy] support query based custom check (PR #131804)

2025-03-19 Thread Ibraim Ganiev via cfe-commits
olologin wrote: Splitting config to multiple files is potentially bad because caching wrappers need to be adjusted to take into account this new type of input file (they only know about .clang-tidy file). https://github.com/llvm/llvm-project/pull/131804

[clang-tools-extra] [clang-tidy] support query based custom check (PR #131804)

2025-03-19 Thread Ibraim Ganiev via cfe-commits
olologin wrote: I like it if it does not break anything :) One small nitpick: Maybe word "custom" is too broad for this. Maybe something that mentions "clang-query" is more specific. But it is just my opinion and I am not related to clang-tidy, so whatever you guys decide. https://github.com/l

[clang-tools-extra] [clang-tidy] Add ClangQueryChecks config option (PR #123734)

2025-03-17 Thread Ibraim Ganiev via cfe-commits
olologin wrote: Just FYI: I have tested @DeNiCoN on our codebase in the company we work with him together (~8k Translation units), and it seems to work fine. `NOLINT(check-name)` works, .clang-tidy config inheritance works (In case some subfolders want to disable particular matchers). Very use