itessier added a comment.
Thanks for the detailed info! I will try to get something out when I get some
free cycles.
Repository:
rC Clang
https://reviews.llvm.org/D52440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
itessier added a comment.
> This is problematic because we're not necessarily in a scope that usefully
> limits the duration of cleanups — we don't push full-expression scopes when
> emitting an arbitrary statement. Probably we should, but we don't.
> If you'd like to take a look at solving t
itessier created this revision.
itessier added a reviewer: rjmccall.
Herald added a subscriber: cfe-commits.
Clang is not emitting lifetime markers for temporary function parameters, so
more stack space is potentially being allocated than necessary.
A new parameter is added to the CreateAggTemp
itessier added inline comments.
Comment at: clang-tidy/ClangTidyOptions.h:93
+ /// \brief Show color diagnostics.
+ llvm::Optional ShowColor;
+
alexfh wrote:
> This doesn't belong to ClangTidyOptions. It's specific to the CLI, but CLI is
> not the only fronten
itessier added a comment.
> That seems like a nice win and I like the convenience of this approach. That
> said I've just remembered that there's a thread on cfe-dev about this:
> [RFC] Suppress C++ static destructor registration
> I don't think a consensus was reached. From what I gather, some p
itessier marked an inline comment as done.
itessier added a comment.
> This patch is missing test coverage.
Done.
Comment at: clang-tidy/tool/ClangTidyMain.cpp:150-152
+Show color diagnostics. If not specified,
+defaults to on when a color-capable terminal
+is detected.)"),
--
itessier updated this revision to Diff 128652.
https://reviews.llvm.org/D41720
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidyOptions.cpp
clang-tidy/ClangTidyOptions.h
clang-tidy/tool/ClangTidyMain.cpp
test/clang-tidy/show-color.cpp
Index: test/clang-tidy/show-color.cpp
=
itessier created this revision.
itessier added a project: clang-tools-extra.
Herald added a subscriber: xazax.hun.
This change will allow enabling of colour diagnostics when not directly running
within a terminal, but colour output is possible. For example, if stdout is
being captured and redire
itessier added a comment.
Do you mind submitting this CL? I don't have access to SVN.
https://reviews.llvm.org/D37496
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
itessier added a comment.
In https://reviews.llvm.org/D37496#861746, @compnerd wrote:
> The change looks good. Can you please add some test cases for this? Or do
> existing test cases cover this already?
Should have added this to the description, but yes there are existing tests
that cover
itessier added a comment.
I don't have SVN access, can somebody commit this change for me?
https://reviews.llvm.org/D37493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
itessier created this revision.
The ToolChain class validates the -mthread-model flag in the constructor which
doesn't work correctly since the thread model methods are virtual methods. The
check is moved into Clang::ConstructJob() when constructing the internal
command line.
https://reviews.
itessier added a comment.
In https://reviews.llvm.org/D35338#809146, @vsk wrote:
> This is interesting. Do you have any results/metrics to share (e.g some any
> binary size reduction for projects you've looked at)?
I only tested this with Project Loon's avionics firmware which freed up ~1.2%
itessier created this revision.
The -fdestroy-globals flag can be used to disable global variable destructor
registration. It is intended to be used with embedded code that never exits.
Disabling registration allows the linker to garbage collect unused destructors
and vtables.
https://reviews.ll
14 matches
Mail list logo
