[clang] [C2y] Add stdcountof.h (PR #140890)

https://github.com/ian-twilightcoder approved this pull request. https://github.com/llvm/llvm-project/pull/140890 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #138234)

ian-twilightcoder wrote: That passes for me. I can't even figure out which unit test is failing, they all say `OK` and not `FAILED`. The one error in there looks like it's expected since its test still returns `OK`. Are we totally sure this isn't an infrastructure issue? https://github.com/ll

[clang] [clang][unittests] Fix a leak in SearchPathTest (PR #139335)

https://github.com/ian-twilightcoder created https://github.com/llvm/llvm-project/pull/139335 None >From 075cc877b9db1435c1d74bc476b807dd564b8fb9 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Fri, 9 May 2025 16:11:23 -0700 Subject: [PATCH] [clang][unittests] Fix a leak in SearchPathTest -

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #138234)

ian-twilightcoder wrote: Yeah that's the one, https://github.com/llvm/llvm-project/pull/139335. Hopefully that'll take care of the buildbot https://github.com/llvm/llvm-project/pull/138234 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #138234)

ian-twilightcoder wrote: I tried `GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=96 GTEST_SHARD_INDEX=67 ./AllClangUnitTests` and that also passes. There's a leak from the new `SearchPathTest`, maybe that's making the address sanitizer mad? https://github.com/llvm/llvm-project/pull/138234

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #138234)

ian-twilightcoder wrote: > This one is still broken > https://lab.llvm.org/buildbot/#/builders/55/builds/11054/steps/11/logs/stdio I can't figure how this change would affect that, but let me give BuildSyntaxTreeTest a try. https://github.com/llvm/llvm-project/pull/138234

[clang] [clang][Darwin] Minor args cleanup (PR #139142)

https://github.com/ian-twilightcoder closed https://github.com/llvm/llvm-project/pull/139142 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Darwin] Minor args cleanup (PR #139142)

https://github.com/ian-twilightcoder created https://github.com/llvm/llvm-project/pull/139142 I just realized that ArgList.hasArg takes multiple arguments. Consolidate the two calls into one. Rate limit · GitHub body { background-color: #f6f8fa;

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #138234)

https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/138234 >From ba40d11f56248850e07eb41b9bdebd407b09f83f Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Thu, 1 May 2025 22:44:52 -0700 Subject: [PATCH] [clang][Darwin] Remove legacy framework search path logi

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #138234)

ian-twilightcoder wrote: > LGTM. > > I would remove the newly added commented `/* static */` Alright well it's going to bother me that they don't match the other ones, so I'll get rid of them all. https://github.com/llvm/llvm-project/pull/138234 ___

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #138234)

@@ -2577,6 +2577,27 @@ void AppleMachO::AddClangSystemIncludeArgs( } } +void DarwinClang::AddClangSystemIncludeArgs( +const llvm::opt::ArgList &DriverArgs, +llvm::opt::ArgStringList &CC1Args) const { + AppleMachO::AddClangSystemIncludeArgs(DriverArgs, CC1Args); + +

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #138234)

https://github.com/ian-twilightcoder edited https://github.com/llvm/llvm-project/pull/138234 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #138234)

@@ -1,13 +0,0 @@ -// RUN: %clang -cc1 -fcuda-is-device -isysroot /var/empty \ ian-twilightcoder wrote: We don't need it because the `ignoring nonexistent directory` are no longer produced. Those paths get pruned before they reach the HeaderSearch now. The old c

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #138234)

@@ -1396,6 +1405,17 @@ void ToolChain::addExternCSystemIncludeIfExists(const ArgList &DriverArgs, addExternCSystemInclude(DriverArgs, CC1Args, Path); } +/// Utility function to add a list of system framework directories to CC1. +/*static*/ void ian-twilig

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #138234)

@@ -1366,6 +1366,15 @@ ToolChain::CXXStdlibType ToolChain::GetCXXStdlibType(const ArgList &Args) const{ return *cxxStdlibType; } +/// Utility function to add a system framework directory to CC1 arguments. +/*static*/ void ian-twilightcoder wrote: I copied

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #138234)

https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/138234 >From 6c5593932af9a1d99bec0cbba018aacad104faf4 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Thu, 1 May 2025 22:44:52 -0700 Subject: [PATCH] [clang][Darwin] Remove legacy framework search path logi

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #138234)

https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/138234 >From 59f8d68c6ebb1f16facb99c03376beef85b06fc0 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Thu, 1 May 2025 22:44:52 -0700 Subject: [PATCH] [clang][Darwin] Remove legacy framework search path logi

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

ian-twilightcoder wrote: > Unfortunately I don't have bandwidth to take this through the finish line. I > just spoke with @ian-twilightcoder who said he'd try to pick it up soon > (thanks a lot!). I'm not a maintainer so I can't update this PR. I ended up needing to tweak most of it, especial

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #138234)

ian-twilightcoder wrote: This is a takeover of https://github.com/llvm/llvm-project/pull/120149 because Louis is out, I'm not a maintainer so I can't push to his fork, and I redid most of it anyway. https://github.com/llvm/llvm-project/pull/138234 __

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #138234)

https://github.com/ian-twilightcoder created https://github.com/llvm/llvm-project/pull/138234 Move the Darwin framework search path logic from InitHeaderSearch::AddDefaultIncludePaths to DarwinClang::AddClangSystemIncludeArgs. Add a new -internal-iframework cc1 argument to support the tool ch

[clang] [clang][headers][Apple] Don't include_next float.h to avoid an unnecessary module dependency (PR #137432)

https://github.com/ian-twilightcoder closed https://github.com/llvm/llvm-project/pull/137432 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][headers][Apple] Don't include_next float.h to avoid an unnecessary module dependency (PR #137432)

ian-twilightcoder wrote: This was originally added in d93779d / d89a1eb (can't find either of these in Phabricator) for `_HAS_SUBNORM`, but that's since been obsoleted by . So including this header just causes an unnecessary include and module build of Apple's

[clang] [clang][headers][Apple] Don't include_next float.h to avoid an unnecessary module dependency (PR #137432)

https://github.com/ian-twilightcoder created https://github.com/llvm/llvm-project/pull/137432 float.h doesn't define anything in Apple's SDKs that the clang float.h doesn't undefine, so all the include_next does is add an unnecessary module dependency. Skip the include_next and completely shad

[clang] [clang][modules] Determine if the SDK supports builtin modules independent of the target (PR #134005)

ian-twilightcoder wrote: > LGTM. I was a bit worried about the fallout that other target triples using > the same sdks would now opt into this behavior but if that were the case > they'd already be running into modularization errors (e.g. > `found_incompatible_headers__check_search_paths`) Ot

[clang] [clang][modules] Determine if the SDK supports builtin modules independent of the target (PR #134005)

https://github.com/ian-twilightcoder closed https://github.com/llvm/llvm-project/pull/134005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Determine if the SDK supports builtin modules independent of the target (PR #134005)

https://github.com/ian-twilightcoder created https://github.com/llvm/llvm-project/pull/134005 Whether the SDK supports builtin modules is a property of the SDK itself, and really has nothing to do with the target. This was already worked around for Mac Catalyst, but there are some other more e

[clang] [clang][modules] Determine if the SDK supports builtin modules independent of the target (PR #134005)

https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/134005 >From c1af28f0af52b84938b8b06957f048bffd8104bb Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Tue, 1 Apr 2025 16:24:30 -0700 Subject: [PATCH] [clang][modules] Determine if the SDK supports builtin

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

ian-twilightcoder wrote: > The next release is a few days away from branching. Is this ready or does > this still need more work? I think we need to restore `-internal-iframework`. We might want to consider how it orders against the other flags as well. https://github.com/llvm/llvm-project/pu

[clang] [Darwin][Driver][clang] arm64-apple-none-macho is missing the Apple macros from arm-apple-none-macho (PR #122427)

ian-twilightcoder wrote: > LLVM Buildbot has detected a new failure on builder > `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building > `clang` at step 7 "Add check check-offload". > > Full details are available at: > https://lab.llvm.org/buildbot/#/builders/73/builds

[clang] [Darwin][Driver][clang] arm64-apple-none-macho is missing the Apple macros from arm-apple-none-macho (PR #122427)

https://github.com/ian-twilightcoder closed https://github.com/llvm/llvm-project/pull/122427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Darwin][Driver][clang] arm64-apple-none-macho is missing the Apple macros from arm-apple-none-macho (PR #122427)

@@ -243,6 +247,8 @@ std::unique_ptr AllocateTarget(const llvm::Triple &Triple, case llvm::Triple::thumbeb: ian-twilightcoder wrote: Yeah, that's why I was asking if we should just always use Darwin for MachO instead of inconsistently using Darwin for some ar

[clang] [Darwin][Driver][clang] arm64-apple-none-macho is missing the Apple macros from arm-apple-none-macho (PR #122427)

https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/122427 >From bda951a8a1d15d2f44ae65d8ddb39fbd68c4b7de Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Thu, 9 Jan 2025 22:50:52 -0800 Subject: [PATCH] [Darwin][Driver][clang] arm64-apple-none-macho is missin

[clang] [Darwin][Driver][clang] arm64-apple-none-macho is missing the Apple macros from arm-apple-none-macho (PR #122427)

@@ -243,6 +247,8 @@ std::unique_ptr AllocateTarget(const llvm::Triple &Triple, case llvm::Triple::thumbeb: ian-twilightcoder wrote: We would never hit the `else` case, `isAppleMachO()` is `(getVendor() == Triple::Apple) && isOSBinFormatMachO()`. So if `isOSB

[clang] [Darwin][Driver][clang] arm64-apple-none-macho is missing the Apple macros from arm-apple-none-macho (PR #122427)

https://github.com/ian-twilightcoder created https://github.com/llvm/llvm-project/pull/122427 arm-apple-none-macho uses DarwinTargetInfo which provides several Apple specific macros. arm64-apple-none-macho however just uses the generic AArch64leTargetInfo and doesn't get any of those macros. I

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

@@ -8265,6 +8265,11 @@ def internal_externc_isystem : Separate<["-"], "internal-externc-isystem">, "implicit extern \"C\" semantics; these are assumed to not be " "user-provided and are used to model system and standard headers' " "paths.">; +d

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

https://github.com/ian-twilightcoder edited https://github.com/llvm/llvm-project/pull/120149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

@@ -8265,6 +8265,11 @@ def internal_externc_isystem : Separate<["-"], "internal-externc-isystem">, "implicit extern \"C\" semantics; these are assumed to not be " "user-provided and are used to model system and standard headers' " "paths.">; +d

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

@@ -8265,6 +8265,11 @@ def internal_externc_isystem : Separate<["-"], "internal-externc-isystem">, "implicit extern \"C\" semantics; these are assumed to not be " "user-provided and are used to model system and standard headers' " "paths.">; +d

[clang] [test][Driver][clang] Fix darwin-embedded-search-paths.c when CLANG_DEFAULT_CXX_STDLIB is libc++ (PR #122145)

https://github.com/ian-twilightcoder closed https://github.com/llvm/llvm-project/pull/122145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [test][Driver][clang] Fix darwin-embedded-search-paths.c when CLANG_DEFAULT_CXX_STDLIB is libc++ (PR #122145)

https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/122145 >From 4bd9ce309935451900d7ebc13a111bedf91d12d0 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Wed, 8 Jan 2025 09:35:04 -0800 Subject: [PATCH] [test][Driver][clang] Fix darwin-embedded-search-paths.c

[clang] [test][Driver][clang] Fix darwin-embedded-search-paths.c when CLANG_DEFAULT_CXX_STDLIB is libc++ (PR #122145)

@@ -1,3 +1,4 @@ +// REQUIRES: default-cxx-stdlib=libstdc++ ian-twilightcoder wrote: Sometimes `default-cxx-stdlib` isn't set at all, and so the `REQUIRES` doesn't always work. `REQUIRES` doesn't have a `!=`, but you can do `!(a=b)`. You can also do `!a || a=b`,

[clang] [test][Driver][clang] Fix darwin-embedded-search-paths.c when CLANG_DEFAULT_CXX_STDLIB is libc++ (PR #122145)

@@ -1,3 +1,4 @@ +// REQUIRES: default-cxx-stdlib=libstdc++ ian-twilightcoder wrote: I guess if there was a different cxxlib we would want another version of the test to check its paths anyway https://github.com/llvm/llvm-project/pull/122145

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

@@ -8265,6 +8265,11 @@ def internal_externc_isystem : Separate<["-"], "internal-externc-isystem">, "implicit extern \"C\" semantics; these are assumed to not be " "user-provided and are used to model system and standard headers' " "paths.">; +d

[clang] [test][Driver][clang] Fix darwin-embedded-search-paths.c when CLANG_DEFAULT_CXX_STDLIB is libc++ (PR #122145)

@@ -1,3 +1,4 @@ +// REQUIRES: default-cxx-stdlib=libstdc++ ian-twilightcoder wrote: Maybe this should be `!=libc++` instead? https://github.com/llvm/llvm-project/pull/122145 ___ cfe-commits mailing list cfe-commits@lis

[clang] [test][Driver][clang] Fix darwin-embedded-search-paths.c when CLANG_DEFAULT_CXX_STDLIB is libc++ (PR #122145)

ian-twilightcoder wrote: Does anyone know a cleaner way of testing this besides just duplicating the test? https://github.com/llvm/llvm-project/pull/122145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [test][Driver][clang] Fix darwin-embedded-search-paths.c when CLANG_DEFAULT_CXX_STDLIB is libc++ (PR #122145)

https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/122145 >From c37b6e3e59f024f2070b740fb91f7ad3298a61e4 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Wed, 8 Jan 2025 09:35:04 -0800 Subject: [PATCH] [test][Driver][clang] Fix darwin-embedded-search-paths.c

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #122035)

ian-twilightcoder wrote: > > LLVM Buildbot has detected a new failure on builder `fuchsia-x86_64-linux` > > running on `fuchsia-debian-64-us-central1-a-1` while building `clang,llvm` > > at step 4 "annotate". > > Full details are available at: > > https://lab.llvm.org/buildbot/#/builders/11/bu

[clang] [test][Driver][clang] Fix darwin-embedded-search-paths.c when CLANG_DEFAULT_CXX_STDLIB is libc++ (PR #122145)

https://github.com/ian-twilightcoder created https://github.com/llvm/llvm-project/pull/122145 Split darwin-embedded-search-paths.c into two tests for the different values of CLANG_DEFAULT_CXX_STDLIB. >From 67d75753b9d03973374e278de0ce55b537f370f2 Mon Sep 17 00:00:00 2001 From: Ian Anderson Da

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #122035)

ian-twilightcoder wrote: tools/llvm-gsymutil/ARM_AArch64/macho-merged-funcs-dwarf.yaml shouldn't be related, it didn't fail in the original patch and the only difference in this one is https://github.com/llvm/llvm-project/pull/122035/files#diff-59f998dac7c93956bd206a4998cdc2180c26e9b8116af4e45

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #122035)

https://github.com/ian-twilightcoder closed https://github.com/llvm/llvm-project/pull/122035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #122035)

ian-twilightcoder wrote: Same thing as https://github.com/llvm/llvm-project/pull/120507, but with the added unit test fixed to accept libc++ being in the SDK or in the build directory. https://github.com/llvm/llvm-project/pull/122035 ___ cfe-commits

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #122035)

https://github.com/ian-twilightcoder created https://github.com/llvm/llvm-project/pull/122035 Embedded development often needs to use a different C standard library, replacing the existing one normally passed as -internal-externc-isystem. This works fine for an apple-macos target, but apple-no

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

@@ -8265,6 +8265,11 @@ def internal_externc_isystem : Separate<["-"], "internal-externc-isystem">, "implicit extern \"C\" semantics; these are assumed to not be " "user-provided and are used to model system and standard headers' " "paths.">; +d

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

@@ -8265,6 +8265,11 @@ def internal_externc_isystem : Separate<["-"], "internal-externc-isystem">, "implicit extern \"C\" semantics; these are assumed to not be " "user-provided and are used to model system and standard headers' " "paths.">; +d

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

https://github.com/ian-twilightcoder closed https://github.com/llvm/llvm-project/pull/120507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/120507 >From 543f1337efaa50ecc9ca4d264ba0e1ea94517ad2 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Wed, 18 Dec 2024 16:31:19 -0800 Subject: [PATCH] [Darwin][Driver][clang] apple-none-macho orders the res

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

ian-twilightcoder wrote: > > > as Swift expects all MachO targets to have that defined. > > > > > > can you elaborate on that expectation? > > [shims/Visibility.h](https://github.com/swiftlang/swift/blob/main/stdlib/public/SwiftShims/swift/shims/Visibility.h#L137) > uses `__MACH__` to figure

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

ian-twilightcoder wrote: > > as Swift expects all MachO targets to have that defined. > > can you elaborate on that expectation? [shims/Visibility.h](https://github.com/swiftlang/swift/blob/main/stdlib/public/SwiftShims/swift/shims/Visibility.h#L137) uses `__MACH__` to figure out how to config

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

ian-twilightcoder wrote: @TNorthover do you know if there was any specific reason to make sure that apple-none-macho doesn't define `__MACH__`? All of the uses I could find contrast that with `__ELF__` and take it to mean "producing a Mach object/using the Apple linker" and not "code that will

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/120507 >From 637a7b3dafdfdba107f8d5c8193fb6e10403a1e8 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Wed, 18 Dec 2024 16:31:19 -0800 Subject: [PATCH] [Darwin][Driver][clang] apple-none-macho orders the res

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

https://github.com/ian-twilightcoder edited https://github.com/llvm/llvm-project/pull/120507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

https://github.com/ian-twilightcoder edited https://github.com/llvm/llvm-project/pull/120507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/120507 >From b199530988c2bc6d83cd1e35b7a914dc7f1e9af6 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Wed, 18 Dec 2024 16:31:19 -0800 Subject: [PATCH] [Darwin][Driver][clang] apple-none-macho orders the res

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

https://github.com/ian-twilightcoder edited https://github.com/llvm/llvm-project/pull/120507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

@@ -0,0 +1,43 @@ +// UNSUPPORTED: system-windows +// Windows is unsupported because we use the Unix path separator `/` in the test. + +// Unlike the Darwin driver, the MachO driver doesn't add any framework search paths, +// only the normal header ones. +// RUN: %clang -x c -t

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/120507 >From 7aecf682c1d620d1b4f9480315f614df7473f40f Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Wed, 18 Dec 2024 16:31:19 -0800 Subject: [PATCH] [Darwin][Driver][clang] apple-none-macho orders the res

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

@@ -312,7 +312,8 @@ bool InitHeaderSearch::ShouldAddDefaultIncludePaths( break; case llvm::Triple::UnknownOS: -if (triple.isWasm()) +if (triple.isWasm() || ((triple.getVendor() == llvm::Triple::Apple) && +triple.isOSBinFormatMachO()))

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

@@ -0,0 +1,43 @@ +// UNSUPPORTED: system-windows +// Windows is unsupported because we use the Unix path separator `/` in the test. + +// Unlike the Darwin driver, the MachO driver doesn't add any framework search paths, +// only the normal header ones. +// RUN: %clang -x c -t

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/120507 >From 8a08bbd37f0350179b812d24ec686f06bcc9c152 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Wed, 18 Dec 2024 16:31:19 -0800 Subject: [PATCH] [Darwin][Driver][clang] apple-none-macho orders the res

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

https://github.com/ian-twilightcoder edited https://github.com/llvm/llvm-project/pull/120507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/120507 >From 7b549f36fb8a26360e9f69b114ddae80b2bbabc7 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Wed, 18 Dec 2024 16:31:19 -0800 Subject: [PATCH] [Darwin][Driver][clang] apple-none-macho orders the res

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

@@ -0,0 +1,43 @@ +// UNSUPPORTED: system-windows +// Windows is unsupported because we use the Unix path separator `/` in the test. + +// Unlike the Darwin driver, the MachO driver doesn't add any framework search paths, +// only the normal header ones. +// RUN: %clang -x c -t

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

@@ -290,8 +290,50 @@ class LLVM_LIBRARY_VISIBILITY MachO : public ToolChain { /// } }; +/// Apple specific MachO extensions +class LLVM_LIBRARY_VISIBILITY AppleMachO : public MachO { +public: + AppleMachO(const Driver &D, const llvm::Triple &Triple, + const llvm

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

@@ -290,8 +290,50 @@ class LLVM_LIBRARY_VISIBILITY MachO : public ToolChain { /// } }; +/// Apple specific MachO extensions +class LLVM_LIBRARY_VISIBILITY AppleMachO : public MachO { +public: + AppleMachO(const Driver &D, const llvm::Triple &Triple, + const llvm

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/120507 >From 0370e1ed0a58e6ee171bd2ea020092098aec5c82 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Wed, 18 Dec 2024 16:31:19 -0800 Subject: [PATCH] [Darwin][Driver][clang] apple-none-macho orders the res

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/120507 >From 06e5fd1dcf4409b8da12ecf28a2a6899b5ba783e Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Wed, 18 Dec 2024 16:31:19 -0800 Subject: [PATCH] [Darwin][Driver][clang] apple-none-macho orders the res

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

https://github.com/ian-twilightcoder edited https://github.com/llvm/llvm-project/pull/120507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/120507 >From 3a651d6ff0b2435ee058b06a1da235b8b3bfdaed Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Wed, 18 Dec 2024 16:31:19 -0800 Subject: [PATCH] [Darwin][Driver][clang] apple-none-macho orders the res

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

@@ -8265,6 +8265,11 @@ def internal_externc_isystem : Separate<["-"], "internal-externc-isystem">, "implicit extern \"C\" semantics; these are assumed to not be " "user-provided and are used to model system and standard headers' " "paths.">; +d

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

@@ -1018,13 +1018,19 @@ bool Darwin::hasBlocksRuntime() const { } } -void Darwin::AddCudaIncludeArgs(const ArgList &DriverArgs, -ArgStringList &CC1Args) const { +void MachO::AddCudaIncludeArgs(const ArgList &DriverArgs, +

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

@@ -1018,13 +1018,19 @@ bool Darwin::hasBlocksRuntime() const { } } -void Darwin::AddCudaIncludeArgs(const ArgList &DriverArgs, -ArgStringList &CC1Args) const { +void MachO::AddCudaIncludeArgs(const ArgList &DriverArgs, +

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

@@ -0,0 +1,26 @@ +// UNSUPPORTED: system-windows +// Windows is unsupported because we use the Unix path separator `/` in the test. + +// Add default directories before running clang to check default +// search paths. +// RUN: rm -rf %t && mkdir -p %t +// RUN: cp -R %S/Inputs/M

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

@@ -0,0 +1,55 @@ +// UNSUPPORTED: system-windows +// Windows is unsupported because we use the Unix path separator `/` in the test. + +// Add default directories before running clang to check default +// search paths. +// RUN: rm -rf %t && mkdir -p %t +// RUN: cp -R %S/Inputs/M

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

@@ -0,0 +1,55 @@ +// UNSUPPORTED: system-windows +// Windows is unsupported because we use the Unix path separator `/` in the test. + +// Add default directories before running clang to check default +// search paths. +// RUN: rm -rf %t && mkdir -p %t +// RUN: cp -R %S/Inputs/M

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

@@ -0,0 +1,55 @@ +// UNSUPPORTED: system-windows +// Windows is unsupported because we use the Unix path separator `/` in the test. + +// Add default directories before running clang to check default +// search paths. +// RUN: rm -rf %t && mkdir -p %t +// RUN: cp -R %S/Inputs/M

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

@@ -0,0 +1,55 @@ +// UNSUPPORTED: system-windows +// Windows is unsupported because we use the Unix path separator `/` in the test. + +// Add default directories before running clang to check default +// search paths. +// RUN: rm -rf %t && mkdir -p %t +// RUN: cp -R %S/Inputs/M

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

@@ -0,0 +1,55 @@ +// UNSUPPORTED: system-windows +// Windows is unsupported because we use the Unix path separator `/` in the test. + ian-twilightcoder wrote: Also copied from clang/test/Driver/darwin-subframeworks.c, but let me look at changing these. https

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

@@ -0,0 +1,55 @@ +// UNSUPPORTED: system-windows +// Windows is unsupported because we use the Unix path separator `/` in the test. + +// Add default directories before running clang to check default +// search paths. +// RUN: rm -rf %t && mkdir -p %t +// RUN: cp -R %S/Inputs/M

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

@@ -0,0 +1,26 @@ +// UNSUPPORTED: system-windows +// Windows is unsupported because we use the Unix path separator `/` in the test. + +// Add default directories before running clang to check default +// search paths. +// RUN: rm -rf %t && mkdir -p %t +// RUN: cp -R %S/Inputs/M

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/120507 >From 1c5290e9f2ae2dfa7536097fabb0448ebd17da16 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Wed, 18 Dec 2024 16:31:19 -0800 Subject: [PATCH] [Darwin][Driver][clang] apple-none-macho orders the res

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

https://github.com/ian-twilightcoder created https://github.com/llvm/llvm-project/pull/120507 Embedded development often needs to use a different C standard library, replacing the existing one normally passed as -internal-externc-isystem. This works fine for an apple-macos target, but apple-no

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

@@ -0,0 +1,26 @@ +// UNSUPPORTED: system-windows +// Windows is unsupported because we use the Unix path separator `/` in the test. + +// Add default directories before running clang to check default +// search paths. +// RUN: rm -rf %t && mkdir -p %t +// RUN: cp -R %S/Inputs/M

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

@@ -0,0 +1,26 @@ +// UNSUPPORTED: system-windows +// Windows is unsupported because we use the Unix path separator `/` in the test. + +// Add default directories before running clang to check default +// search paths. +// RUN: rm -rf %t && mkdir -p %t +// RUN: cp -R %S/Inputs/M

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

@@ -0,0 +1,26 @@ +// UNSUPPORTED: system-windows +// Windows is unsupported because we use the Unix path separator `/` in the test. + +// Add default directories before running clang to check default +// search paths. +// RUN: rm -rf %t && mkdir -p %t +// RUN: cp -R %S/Inputs/M

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

https://github.com/ian-twilightcoder approved this pull request. https://github.com/llvm/llvm-project/pull/120149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][Darwin] Introduce `SubFrameworks` as a SDK default location (PR #115048)

ian-twilightcoder wrote: Do we also need to update `darwin::Linker::ConstructJob(...)`? https://github.com/llvm/llvm-project/pull/115048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Adjust modulemap to mark mm3dnow as textual header. (PR #107155)

https://github.com/ian-twilightcoder approved this pull request. https://github.com/llvm/llvm-project/pull/107155 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Adjust modulemap to mark mm3dnow as textual header. (PR #107155)

ian-twilightcoder wrote: That's true. Probably nobody's using this header anymore anyway so either way should be fine I think. https://github.com/llvm/llvm-project/pull/107155 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] Adjust modulemap to mark mm3dnow as textual header. (PR #107155)

ian-twilightcoder wrote: Does anything rely on the header guard? It would be good if we could remove it since textual headers are not generally expected to declare anything, even macros. https://github.com/llvm/llvm-project/pull/107155 ___ cfe-commit

[clang] [Clang][Sema] clang generates incorrect fix-its for API_AVAILABLE (PR #105855)

https://github.com/ian-twilightcoder closed https://github.com/llvm/llvm-project/pull/105855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   >