[clang] [clang][modules] Determine if the SDK supports builtin modules independent of the target (PR #134005)

2025-04-03 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: > LGTM. I was a bit worried about the fallout that other target triples using > the same sdks would now opt into this behavior but if that were the case > they'd already be running into modularization errors (e.g. > `found_incompatible_headers__check_search_paths`) Ot

[clang] [clang][modules] Determine if the SDK supports builtin modules independent of the target (PR #134005)

2025-04-03 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder closed https://github.com/llvm/llvm-project/pull/134005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Determine if the SDK supports builtin modules independent of the target (PR #134005)

2025-04-01 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder created https://github.com/llvm/llvm-project/pull/134005 Whether the SDK supports builtin modules is a property of the SDK itself, and really has nothing to do with the target. This was already worked around for Mac Catalyst, but there are some other more e

[clang] [clang][modules] Determine if the SDK supports builtin modules independent of the target (PR #134005)

2025-04-01 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/134005 >From c1af28f0af52b84938b8b06957f048bffd8104bb Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Tue, 1 Apr 2025 16:24:30 -0700 Subject: [PATCH] [clang][modules] Determine if the SDK supports builtin

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2025-01-23 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: > The next release is a few days away from branching. Is this ready or does > this still need more work? I think we need to restore `-internal-iframework`. We might want to consider how it orders against the other flags as well. https://github.com/llvm/llvm-project/pu

[clang] [Darwin][Driver][clang] arm64-apple-none-macho is missing the Apple macros from arm-apple-none-macho (PR #122427)

2025-01-10 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: > LLVM Buildbot has detected a new failure on builder > `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building > `clang` at step 7 "Add check check-offload". > > Full details are available at: > https://lab.llvm.org/buildbot/#/builders/73/builds

[clang] [Darwin][Driver][clang] arm64-apple-none-macho is missing the Apple macros from arm-apple-none-macho (PR #122427)

2025-01-10 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder closed https://github.com/llvm/llvm-project/pull/122427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Darwin][Driver][clang] arm64-apple-none-macho is missing the Apple macros from arm-apple-none-macho (PR #122427)

2025-01-10 Thread Ian Anderson via cfe-commits
@@ -243,6 +247,8 @@ std::unique_ptr AllocateTarget(const llvm::Triple &Triple, case llvm::Triple::thumbeb: ian-twilightcoder wrote: Yeah, that's why I was asking if we should just always use Darwin for MachO instead of inconsistently using Darwin for some ar

[clang] [Darwin][Driver][clang] arm64-apple-none-macho is missing the Apple macros from arm-apple-none-macho (PR #122427)

2025-01-10 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/122427 >From bda951a8a1d15d2f44ae65d8ddb39fbd68c4b7de Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Thu, 9 Jan 2025 22:50:52 -0800 Subject: [PATCH] [Darwin][Driver][clang] arm64-apple-none-macho is missin

[clang] [Darwin][Driver][clang] arm64-apple-none-macho is missing the Apple macros from arm-apple-none-macho (PR #122427)

2025-01-10 Thread Ian Anderson via cfe-commits
@@ -243,6 +247,8 @@ std::unique_ptr AllocateTarget(const llvm::Triple &Triple, case llvm::Triple::thumbeb: ian-twilightcoder wrote: We would never hit the `else` case, `isAppleMachO()` is `(getVendor() == Triple::Apple) && isOSBinFormatMachO()`. So if `isOSB

[clang] [Darwin][Driver][clang] arm64-apple-none-macho is missing the Apple macros from arm-apple-none-macho (PR #122427)

2025-01-09 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder created https://github.com/llvm/llvm-project/pull/122427 arm-apple-none-macho uses DarwinTargetInfo which provides several Apple specific macros. arm64-apple-none-macho however just uses the generic AArch64leTargetInfo and doesn't get any of those macros. I

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2025-01-09 Thread Ian Anderson via cfe-commits
@@ -8265,6 +8265,11 @@ def internal_externc_isystem : Separate<["-"], "internal-externc-isystem">, "implicit extern \"C\" semantics; these are assumed to not be " "user-provided and are used to model system and standard headers' " "paths.">; +d

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2025-01-09 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder edited https://github.com/llvm/llvm-project/pull/120149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2025-01-09 Thread Ian Anderson via cfe-commits
@@ -8265,6 +8265,11 @@ def internal_externc_isystem : Separate<["-"], "internal-externc-isystem">, "implicit extern \"C\" semantics; these are assumed to not be " "user-provided and are used to model system and standard headers' " "paths.">; +d

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2025-01-09 Thread Ian Anderson via cfe-commits
@@ -8265,6 +8265,11 @@ def internal_externc_isystem : Separate<["-"], "internal-externc-isystem">, "implicit extern \"C\" semantics; these are assumed to not be " "user-provided and are used to model system and standard headers' " "paths.">; +d

[clang] [test][Driver][clang] Fix darwin-embedded-search-paths.c when CLANG_DEFAULT_CXX_STDLIB is libc++ (PR #122145)

2025-01-08 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder closed https://github.com/llvm/llvm-project/pull/122145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [test][Driver][clang] Fix darwin-embedded-search-paths.c when CLANG_DEFAULT_CXX_STDLIB is libc++ (PR #122145)

2025-01-08 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/122145 >From 4bd9ce309935451900d7ebc13a111bedf91d12d0 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Wed, 8 Jan 2025 09:35:04 -0800 Subject: [PATCH] [test][Driver][clang] Fix darwin-embedded-search-paths.c

[clang] [test][Driver][clang] Fix darwin-embedded-search-paths.c when CLANG_DEFAULT_CXX_STDLIB is libc++ (PR #122145)

2025-01-08 Thread Ian Anderson via cfe-commits
@@ -1,3 +1,4 @@ +// REQUIRES: default-cxx-stdlib=libstdc++ ian-twilightcoder wrote: Sometimes `default-cxx-stdlib` isn't set at all, and so the `REQUIRES` doesn't always work. `REQUIRES` doesn't have a `!=`, but you can do `!(a=b)`. You can also do `!a || a=b`,

[clang] [test][Driver][clang] Fix darwin-embedded-search-paths.c when CLANG_DEFAULT_CXX_STDLIB is libc++ (PR #122145)

2025-01-08 Thread Ian Anderson via cfe-commits
@@ -1,3 +1,4 @@ +// REQUIRES: default-cxx-stdlib=libstdc++ ian-twilightcoder wrote: I guess if there was a different cxxlib we would want another version of the test to check its paths anyway https://github.com/llvm/llvm-project/pull/122145

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2025-01-08 Thread Ian Anderson via cfe-commits
@@ -8265,6 +8265,11 @@ def internal_externc_isystem : Separate<["-"], "internal-externc-isystem">, "implicit extern \"C\" semantics; these are assumed to not be " "user-provided and are used to model system and standard headers' " "paths.">; +d

[clang] [test][Driver][clang] Fix darwin-embedded-search-paths.c when CLANG_DEFAULT_CXX_STDLIB is libc++ (PR #122145)

2025-01-08 Thread Ian Anderson via cfe-commits
@@ -1,3 +1,4 @@ +// REQUIRES: default-cxx-stdlib=libstdc++ ian-twilightcoder wrote: Maybe this should be `!=libc++` instead? https://github.com/llvm/llvm-project/pull/122145 ___ cfe-commits mailing list cfe-commits@lis

[clang] [test][Driver][clang] Fix darwin-embedded-search-paths.c when CLANG_DEFAULT_CXX_STDLIB is libc++ (PR #122145)

2025-01-08 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: Does anyone know a cleaner way of testing this besides just duplicating the test? https://github.com/llvm/llvm-project/pull/122145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [test][Driver][clang] Fix darwin-embedded-search-paths.c when CLANG_DEFAULT_CXX_STDLIB is libc++ (PR #122145)

2025-01-08 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/122145 >From c37b6e3e59f024f2070b740fb91f7ad3298a61e4 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Wed, 8 Jan 2025 09:35:04 -0800 Subject: [PATCH] [test][Driver][clang] Fix darwin-embedded-search-paths.c

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #122035)

2025-01-08 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: > > LLVM Buildbot has detected a new failure on builder `fuchsia-x86_64-linux` > > running on `fuchsia-debian-64-us-central1-a-1` while building `clang,llvm` > > at step 4 "annotate". > > Full details are available at: > > https://lab.llvm.org/buildbot/#/builders/11/bu

[clang] [test][Driver][clang] Fix darwin-embedded-search-paths.c when CLANG_DEFAULT_CXX_STDLIB is libc++ (PR #122145)

2025-01-08 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder created https://github.com/llvm/llvm-project/pull/122145 Split darwin-embedded-search-paths.c into two tests for the different values of CLANG_DEFAULT_CXX_STDLIB. >From 67d75753b9d03973374e278de0ce55b537f370f2 Mon Sep 17 00:00:00 2001 From: Ian Anderson Da

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #122035)

2025-01-07 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: tools/llvm-gsymutil/ARM_AArch64/macho-merged-funcs-dwarf.yaml shouldn't be related, it didn't fail in the original patch and the only difference in this one is https://github.com/llvm/llvm-project/pull/122035/files#diff-59f998dac7c93956bd206a4998cdc2180c26e9b8116af4e45

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #122035)

2025-01-07 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder closed https://github.com/llvm/llvm-project/pull/122035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #122035)

2025-01-07 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: Same thing as https://github.com/llvm/llvm-project/pull/120507, but with the added unit test fixed to accept libc++ being in the SDK or in the build directory. https://github.com/llvm/llvm-project/pull/122035 ___ cfe-commits

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #122035)

2025-01-07 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder created https://github.com/llvm/llvm-project/pull/122035 Embedded development often needs to use a different C standard library, replacing the existing one normally passed as -internal-externc-isystem. This works fine for an apple-macos target, but apple-no

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2025-01-07 Thread Ian Anderson via cfe-commits
@@ -8265,6 +8265,11 @@ def internal_externc_isystem : Separate<["-"], "internal-externc-isystem">, "implicit extern \"C\" semantics; these are assumed to not be " "user-provided and are used to model system and standard headers' " "paths.">; +d

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2025-01-07 Thread Ian Anderson via cfe-commits
@@ -8265,6 +8265,11 @@ def internal_externc_isystem : Separate<["-"], "internal-externc-isystem">, "implicit extern \"C\" semantics; these are assumed to not be " "user-provided and are used to model system and standard headers' " "paths.">; +d

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2025-01-06 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder closed https://github.com/llvm/llvm-project/pull/120507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2025-01-06 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/120507 >From 543f1337efaa50ecc9ca4d264ba0e1ea94517ad2 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Wed, 18 Dec 2024 16:31:19 -0800 Subject: [PATCH] [Darwin][Driver][clang] apple-none-macho orders the res

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2025-01-03 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: > > > as Swift expects all MachO targets to have that defined. > > > > > > can you elaborate on that expectation? > > [shims/Visibility.h](https://github.com/swiftlang/swift/blob/main/stdlib/public/SwiftShims/swift/shims/Visibility.h#L137) > uses `__MACH__` to figure

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2025-01-03 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: > > as Swift expects all MachO targets to have that defined. > > can you elaborate on that expectation? [shims/Visibility.h](https://github.com/swiftlang/swift/blob/main/stdlib/public/SwiftShims/swift/shims/Visibility.h#L137) uses `__MACH__` to figure out how to config

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2025-01-02 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: @TNorthover do you know if there was any specific reason to make sure that apple-none-macho doesn't define `__MACH__`? All of the uses I could find contrast that with `__ELF__` and take it to mean "producing a Mach object/using the Apple linker" and not "code that will

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2025-01-02 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/120507 >From 637a7b3dafdfdba107f8d5c8193fb6e10403a1e8 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Wed, 18 Dec 2024 16:31:19 -0800 Subject: [PATCH] [Darwin][Driver][clang] apple-none-macho orders the res

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2025-01-02 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder edited https://github.com/llvm/llvm-project/pull/120507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2025-01-02 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder edited https://github.com/llvm/llvm-project/pull/120507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2025-01-02 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/120507 >From b199530988c2bc6d83cd1e35b7a914dc7f1e9af6 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Wed, 18 Dec 2024 16:31:19 -0800 Subject: [PATCH] [Darwin][Driver][clang] apple-none-macho orders the res

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2024-12-20 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder edited https://github.com/llvm/llvm-project/pull/120507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2024-12-20 Thread Ian Anderson via cfe-commits
@@ -0,0 +1,43 @@ +// UNSUPPORTED: system-windows +// Windows is unsupported because we use the Unix path separator `/` in the test. + +// Unlike the Darwin driver, the MachO driver doesn't add any framework search paths, +// only the normal header ones. +// RUN: %clang -x c -t

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2024-12-20 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/120507 >From 7aecf682c1d620d1b4f9480315f614df7473f40f Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Wed, 18 Dec 2024 16:31:19 -0800 Subject: [PATCH] [Darwin][Driver][clang] apple-none-macho orders the res

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2024-12-20 Thread Ian Anderson via cfe-commits
@@ -312,7 +312,8 @@ bool InitHeaderSearch::ShouldAddDefaultIncludePaths( break; case llvm::Triple::UnknownOS: -if (triple.isWasm()) +if (triple.isWasm() || ((triple.getVendor() == llvm::Triple::Apple) && +triple.isOSBinFormatMachO()))

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2024-12-20 Thread Ian Anderson via cfe-commits
@@ -0,0 +1,43 @@ +// UNSUPPORTED: system-windows +// Windows is unsupported because we use the Unix path separator `/` in the test. + +// Unlike the Darwin driver, the MachO driver doesn't add any framework search paths, +// only the normal header ones. +// RUN: %clang -x c -t

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2024-12-20 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/120507 >From 8a08bbd37f0350179b812d24ec686f06bcc9c152 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Wed, 18 Dec 2024 16:31:19 -0800 Subject: [PATCH] [Darwin][Driver][clang] apple-none-macho orders the res

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2024-12-20 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder edited https://github.com/llvm/llvm-project/pull/120507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2024-12-20 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/120507 >From 7b549f36fb8a26360e9f69b114ddae80b2bbabc7 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Wed, 18 Dec 2024 16:31:19 -0800 Subject: [PATCH] [Darwin][Driver][clang] apple-none-macho orders the res

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2024-12-20 Thread Ian Anderson via cfe-commits
@@ -0,0 +1,43 @@ +// UNSUPPORTED: system-windows +// Windows is unsupported because we use the Unix path separator `/` in the test. + +// Unlike the Darwin driver, the MachO driver doesn't add any framework search paths, +// only the normal header ones. +// RUN: %clang -x c -t

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2024-12-20 Thread Ian Anderson via cfe-commits
@@ -290,8 +290,50 @@ class LLVM_LIBRARY_VISIBILITY MachO : public ToolChain { /// } }; +/// Apple specific MachO extensions +class LLVM_LIBRARY_VISIBILITY AppleMachO : public MachO { +public: + AppleMachO(const Driver &D, const llvm::Triple &Triple, + const llvm

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2024-12-20 Thread Ian Anderson via cfe-commits
@@ -290,8 +290,50 @@ class LLVM_LIBRARY_VISIBILITY MachO : public ToolChain { /// } }; +/// Apple specific MachO extensions +class LLVM_LIBRARY_VISIBILITY AppleMachO : public MachO { +public: + AppleMachO(const Driver &D, const llvm::Triple &Triple, + const llvm

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2024-12-20 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/120507 >From 0370e1ed0a58e6ee171bd2ea020092098aec5c82 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Wed, 18 Dec 2024 16:31:19 -0800 Subject: [PATCH] [Darwin][Driver][clang] apple-none-macho orders the res

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2024-12-20 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/120507 >From 06e5fd1dcf4409b8da12ecf28a2a6899b5ba783e Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Wed, 18 Dec 2024 16:31:19 -0800 Subject: [PATCH] [Darwin][Driver][clang] apple-none-macho orders the res

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2024-12-20 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder edited https://github.com/llvm/llvm-project/pull/120507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2024-12-20 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/120507 >From 3a651d6ff0b2435ee058b06a1da235b8b3bfdaed Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Wed, 18 Dec 2024 16:31:19 -0800 Subject: [PATCH] [Darwin][Driver][clang] apple-none-macho orders the res

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2024-12-20 Thread Ian Anderson via cfe-commits
@@ -8265,6 +8265,11 @@ def internal_externc_isystem : Separate<["-"], "internal-externc-isystem">, "implicit extern \"C\" semantics; these are assumed to not be " "user-provided and are used to model system and standard headers' " "paths.">; +d

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2024-12-20 Thread Ian Anderson via cfe-commits
@@ -1018,13 +1018,19 @@ bool Darwin::hasBlocksRuntime() const { } } -void Darwin::AddCudaIncludeArgs(const ArgList &DriverArgs, -ArgStringList &CC1Args) const { +void MachO::AddCudaIncludeArgs(const ArgList &DriverArgs, +

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2024-12-20 Thread Ian Anderson via cfe-commits
@@ -1018,13 +1018,19 @@ bool Darwin::hasBlocksRuntime() const { } } -void Darwin::AddCudaIncludeArgs(const ArgList &DriverArgs, -ArgStringList &CC1Args) const { +void MachO::AddCudaIncludeArgs(const ArgList &DriverArgs, +

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2024-12-19 Thread Ian Anderson via cfe-commits
@@ -0,0 +1,26 @@ +// UNSUPPORTED: system-windows +// Windows is unsupported because we use the Unix path separator `/` in the test. + +// Add default directories before running clang to check default +// search paths. +// RUN: rm -rf %t && mkdir -p %t +// RUN: cp -R %S/Inputs/M

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2024-12-19 Thread Ian Anderson via cfe-commits
@@ -0,0 +1,55 @@ +// UNSUPPORTED: system-windows +// Windows is unsupported because we use the Unix path separator `/` in the test. + +// Add default directories before running clang to check default +// search paths. +// RUN: rm -rf %t && mkdir -p %t +// RUN: cp -R %S/Inputs/M

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2024-12-19 Thread Ian Anderson via cfe-commits
@@ -0,0 +1,55 @@ +// UNSUPPORTED: system-windows +// Windows is unsupported because we use the Unix path separator `/` in the test. + +// Add default directories before running clang to check default +// search paths. +// RUN: rm -rf %t && mkdir -p %t +// RUN: cp -R %S/Inputs/M

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2024-12-19 Thread Ian Anderson via cfe-commits
@@ -0,0 +1,55 @@ +// UNSUPPORTED: system-windows +// Windows is unsupported because we use the Unix path separator `/` in the test. + +// Add default directories before running clang to check default +// search paths. +// RUN: rm -rf %t && mkdir -p %t +// RUN: cp -R %S/Inputs/M

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2024-12-19 Thread Ian Anderson via cfe-commits
@@ -0,0 +1,55 @@ +// UNSUPPORTED: system-windows +// Windows is unsupported because we use the Unix path separator `/` in the test. + +// Add default directories before running clang to check default +// search paths. +// RUN: rm -rf %t && mkdir -p %t +// RUN: cp -R %S/Inputs/M

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2024-12-19 Thread Ian Anderson via cfe-commits
@@ -0,0 +1,55 @@ +// UNSUPPORTED: system-windows +// Windows is unsupported because we use the Unix path separator `/` in the test. + ian-twilightcoder wrote: Also copied from clang/test/Driver/darwin-subframeworks.c, but let me look at changing these. https

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2024-12-19 Thread Ian Anderson via cfe-commits
@@ -0,0 +1,55 @@ +// UNSUPPORTED: system-windows +// Windows is unsupported because we use the Unix path separator `/` in the test. + +// Add default directories before running clang to check default +// search paths. +// RUN: rm -rf %t && mkdir -p %t +// RUN: cp -R %S/Inputs/M

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2024-12-19 Thread Ian Anderson via cfe-commits
@@ -0,0 +1,26 @@ +// UNSUPPORTED: system-windows +// Windows is unsupported because we use the Unix path separator `/` in the test. + +// Add default directories before running clang to check default +// search paths. +// RUN: rm -rf %t && mkdir -p %t +// RUN: cp -R %S/Inputs/M

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2024-12-18 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/120507 >From 1c5290e9f2ae2dfa7536097fabb0448ebd17da16 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Wed, 18 Dec 2024 16:31:19 -0800 Subject: [PATCH] [Darwin][Driver][clang] apple-none-macho orders the res

[clang] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

2024-12-18 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder created https://github.com/llvm/llvm-project/pull/120507 Embedded development often needs to use a different C standard library, replacing the existing one normally passed as -internal-externc-isystem. This works fine for an apple-macos target, but apple-no

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2024-12-17 Thread Ian Anderson via cfe-commits
@@ -0,0 +1,26 @@ +// UNSUPPORTED: system-windows +// Windows is unsupported because we use the Unix path separator `/` in the test. + +// Add default directories before running clang to check default +// search paths. +// RUN: rm -rf %t && mkdir -p %t +// RUN: cp -R %S/Inputs/M

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2024-12-16 Thread Ian Anderson via cfe-commits
@@ -0,0 +1,26 @@ +// UNSUPPORTED: system-windows +// Windows is unsupported because we use the Unix path separator `/` in the test. + +// Add default directories before running clang to check default +// search paths. +// RUN: rm -rf %t && mkdir -p %t +// RUN: cp -R %S/Inputs/M

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2024-12-16 Thread Ian Anderson via cfe-commits
@@ -0,0 +1,26 @@ +// UNSUPPORTED: system-windows +// Windows is unsupported because we use the Unix path separator `/` in the test. + +// Add default directories before running clang to check default +// search paths. +// RUN: rm -rf %t && mkdir -p %t +// RUN: cp -R %S/Inputs/M

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2024-12-16 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder approved this pull request. https://github.com/llvm/llvm-project/pull/120149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][Darwin] Introduce `SubFrameworks` as a SDK default location (PR #115048)

2024-11-05 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: Do we also need to update `darwin::Linker::ConstructJob(...)`? https://github.com/llvm/llvm-project/pull/115048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Adjust modulemap to mark mm3dnow as textual header. (PR #107155)

2024-09-13 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder approved this pull request. https://github.com/llvm/llvm-project/pull/107155 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Adjust modulemap to mark mm3dnow as textual header. (PR #107155)

2024-09-04 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: That's true. Probably nobody's using this header anymore anyway so either way should be fine I think. https://github.com/llvm/llvm-project/pull/107155 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] Adjust modulemap to mark mm3dnow as textual header. (PR #107155)

2024-09-03 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: Does anything rely on the header guard? It would be good if we could remove it since textual headers are not generally expected to declare anything, even macros. https://github.com/llvm/llvm-project/pull/107155 ___ cfe-commit

[clang] [Clang][Sema] clang generates incorrect fix-its for API_AVAILABLE (PR #105855)

2024-09-03 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder closed https://github.com/llvm/llvm-project/pull/105855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Remove support for 3DNow!, both intrinsics and builtins. (PR #96246)

2024-09-03 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: > Do the include guard macros make it problematic to expose as a textual > header? I would not have thought that to be the case. It means that the header guard declaration would be compiled into every pcm that includes the header. Which is maybe fine for this one, but

[clang] [Clang][Sema] clang generates incorrect fix-its for API_AVAILABLE (PR #105855)

2024-09-03 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/105855 >From f54f7bf02ae2a93e9b321be181b59485e241a51a Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Fri, 23 Aug 2024 09:43:22 -0700 Subject: [PATCH] [Clang][Sema] clang generates incorrect fix-its for AP

[clang] [Clang][Sema] clang generates incorrect fix-its for API_AVAILABLE (PR #105855)

2024-09-03 Thread Ian Anderson via cfe-commits
@@ -1073,6 +1073,36 @@ static llvm::StringRef canonicalizePlatformName(llvm::StringRef Platform) { .Case("ShaderModel", "shadermodel") .Default(Platform); } +static std::vector equivalentPlatformNames(llvm::StringRef Platform) { ian-

[clang] [llvm] Remove support for 3DNow!, both intrinsics and builtins. (PR #96246)

2024-09-03 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: > I think we can just switch it to be a textual header; it no longer has any > decls. It does still have _MM3DNOW_H_INCLUDED, but we could probably remove that https://github.com/llvm/llvm-project/pull/96246 ___ cfe-commits m

[clang] [Clang][Sema] clang generates incorrect fix-its for API_AVAILABLE (PR #105855)

2024-09-03 Thread Ian Anderson via cfe-commits
@@ -1073,6 +1073,36 @@ static llvm::StringRef canonicalizePlatformName(llvm::StringRef Platform) { .Case("ShaderModel", "shadermodel") .Default(Platform); } +static std::vector equivalentPlatformNames(llvm::StringRef Platform) { ian-

[clang] [docs] Document the missing availability platforms and environments (PR #104653)

2024-08-26 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder closed https://github.com/llvm/llvm-project/pull/104653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [docs] Document the missing availability platforms and environments (PR #104653)

2024-08-26 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/104653 >From b009556b34503b85be2d9312f918f84d987a999f Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Fri, 16 Aug 2024 17:32:29 -0700 Subject: [PATCH] [docs] Document the missing availability platforms and

[clang] [docs] Document the missing availability platforms and environments (PR #104653)

2024-08-26 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder edited https://github.com/llvm/llvm-project/pull/104653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [docs] Document the missing availability platforms and environments (PR #104653)

2024-08-26 Thread Ian Anderson via cfe-commits
@@ -1637,31 +1637,42 @@ specifies availability for the current target platform, the availability attributes are ignored. Supported platforms are: ``ios`` +``ios_app_extension`` ian-twilightcoder wrote: Cyndy made that point that `-target` and -mtargetos` are

[clang] [docs] Document the missing availability platforms and environments (PR #104653)

2024-08-26 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/104653 >From 85e4dc08d5316df26247a181386ec819083ce992 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Fri, 16 Aug 2024 17:32:29 -0700 Subject: [PATCH] [docs] Document the missing availability platforms and

[clang] [docs] Document the missing availability platforms and environments (PR #104653)

2024-08-26 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder edited https://github.com/llvm/llvm-project/pull/104653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [docs] Document the missing Apple availability platforms (PR #104653)

2024-08-26 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder edited https://github.com/llvm/llvm-project/pull/104653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [docs] Document the missing Apple availability platforms (PR #104653)

2024-08-26 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/104653 >From e908672f2f9c3a8995dcc7c50fe1fb72fdd467e9 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Fri, 16 Aug 2024 17:32:29 -0700 Subject: [PATCH] [docs] Document the missing availability platforms and

[clang] [docs] Document the missing Apple availability platforms (PR #104653)

2024-08-26 Thread Ian Anderson via cfe-commits
@@ -1637,31 +1637,42 @@ specifies availability for the current target platform, the availability attributes are ignored. Supported platforms are: ``ios`` +``ios_app_extension`` ian-twilightcoder wrote: I actually feel like these don't need descriptions and w

[libunwind] [libunwind] Stop installing the mach-o module map (PR #105616)

2024-08-23 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: /cherry-pick 172c4a4a147833f1c08df1555f3170aa9ccb6cbe https://github.com/llvm/llvm-project/pull/105616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Stop installing the mach-o module map (PR #105616)

2024-08-23 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder milestoned https://github.com/llvm/llvm-project/pull/105616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] clang generates incorrect fix-its for API_AVAILABLE (PR #105855)

2024-08-23 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: > std/algorithms/alg.sorting/alg.merge/pstl.merge.pass.cpp test failure doesn't > look related. Maybe a rebase will fix it. https://github.com/llvm/llvm-project/pull/105855 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang] [Clang][Sema] clang generates incorrect fix-its for API_AVAILABLE (PR #105855)

2024-08-23 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/105855 >From 04c54cff4d480e2f3e8c9664920e5c04ab191cac Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Fri, 23 Aug 2024 09:43:22 -0700 Subject: [PATCH] [Clang][Sema] clang generates incorrect fix-its for AP

[clang] [Clang][Sema] clang generates incorrect fix-its for API_AVAILABLE (PR #105855)

2024-08-23 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/105855 >From f3359bfc29d8300e238efc328b5dfe05e26dad3f Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Fri, 23 Aug 2024 09:43:22 -0700 Subject: [PATCH] [Clang][Sema] clang generates incorrect fix-its for AP

[clang] [Clang][Sema] clang generates incorrect fix-its for API_AVAILABLE (PR #105855)

2024-08-23 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: std/algorithms/alg.sorting/alg.merge/pstl.merge.pass.cpp test failure doesn't look related. https://github.com/llvm/llvm-project/pull/105855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang] [Clang][Sema] clang generates incorrect fix-its for API_AVAILABLE (PR #105855)

2024-08-23 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/105855 >From 752ddc78b6ac1ed759b37475f06830d1eed44860 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Fri, 23 Aug 2024 09:43:22 -0700 Subject: [PATCH] [Clang][Sema] clang generates incorrect fix-its for AP

[clang] [Clang][Sema] clang generates incorrect fix-its for API_AVAILABLE (PR #105855)

2024-08-23 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/105855 >From 9c99492f0b5068ed9179dcb2637839673a671271 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Fri, 23 Aug 2024 09:43:22 -0700 Subject: [PATCH] [Clang][Sema] clang generates incorrect fix-its for AP

[clang] [Clang][Sema] clang generates incorrect fix-its for API_AVAILABLE (PR #105855)

2024-08-23 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/105855 >From 540420bb178d2e2b0b92caf1741ec71bde48184f Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Fri, 23 Aug 2024 09:43:22 -0700 Subject: [PATCH] [Clang][Sema] clang generates incorrect fix-its for AP

  1   2   3   >