[PATCH] D57655: clang-format with UseTab: Always sometimes doesn't insert the right amount of tabs.

2019-02-13 Thread Hylke Kleve via Phabricator via cfe-commits
hyklv added a comment. In D57655#1395924 , @alexfh wrote: > Seems reasonable. LG with a couple of nits. Please let me know if you need to > commit this for you. cool. could you commit the change for me? Repository: rC Clang CHANGES SINCE LAST ACTIO

[PATCH] D57655: clang-format with UseTab: Always sometimes doesn't insert the right amount of tabs.

2019-02-13 Thread Hylke Kleve via Phabricator via cfe-commits
hyklv updated this revision to Diff 186629. hyklv marked 2 inline comments as done. hyklv added a comment. Updated comment and added break; Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57655/new/ https://reviews.llvm.org/D57655 Files: D:/Format/llvm/tools/cla

[PATCH] D57655: clang-format with UseTab: Always sometimes doesn't insert the right amount of tabs.

2019-02-11 Thread Hylke Kleve via Phabricator via cfe-commits
hyklv added a comment. In D57655#1382437 , @lebedev.ri wrote: > Test? > Is this a fix, or a new formatting style? a fix. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57655/new/ https://reviews.llvm.org/D57655 _

[PATCH] D57655: clang-format with UseTab: Always sometimes doesn't insert the right amount of tabs.

2019-02-11 Thread Hylke Kleve via Phabricator via cfe-commits
hyklv added a comment. In D57655#1382855 , @MyDeveloperDay wrote: > The reviewers set a high barrier of entry, you need to at least start by > adding some unit tests (or someone will break your code in the future), if > you think it was a bug it might b

[PATCH] D57655: clang-format with UseTab: Always sometimes doesn't insert the right amount of tabs.

2019-02-11 Thread Hylke Kleve via Phabricator via cfe-commits
hyklv updated this revision to Diff 186315. hyklv marked an inline comment as done. hyklv added a comment. I removed accidental changes in the copyright notice, updated the code to insert one space instead of one tab. Added a test case for the alignment. Repository: rC Clang CHANGES SINCE LA

[PATCH] D57655: clang-format with UseTab: Always sometimes doesn't insert the right amount of tabs.

2019-02-03 Thread Hylke Kleve via Phabricator via cfe-commits
hyklv created this revision. hyklv added reviewers: alexfh, djasper. Herald added a project: clang. Herald added a subscriber: cfe-commits. Hi, I'm trying to get clang-format suited for our code layout. I've set it up to align declarations and trailing comments. Tab size is 4; UseTab is set to