[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

hyeongyukim added a comment. Thank you for your clarification. I'll change it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105169/new/ https://reviews.llvm.org/D105169 ___ cfe-commits mailing list cfe-

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

hyeongyukim added a comment. In D105169#3319773 , @dblaikie wrote: > In D105169#3315009 , @MaskRay wrote: > >> It may not be worth changing now, but I want to mention: it's more >> conventional to have a `BoolOpt

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

hyeongyukim added a comment. @nathanchance Hi, I analyzed all four warnings. Warning #1: can be handled by x86-backend. filled issue #53118 Warning #2: bug in the kernel, fixed in the next version. Warning #3: same reason with #2 Warning #4: It

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

hyeongyukim added a comment. @nathanchance You were right. I succeeded in reproducing the warning with `-fsanitize-coverage=trace-pc` However, this problem seems to be fixed in the latest version. (I used `57a551a`) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

hyeongyukim added a comment. @nathanchance I tried to reproduce the last warning (intelfbhw_validate_mode), but I failed to produce it. I think my reproducer is correct, but it does not make any warning. Can you tell me which part was wrong? clang -O2 -flto=thin -fsanitize=integer-divide-by-z

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

hyeongyukim added a comment. Great. I'll check it out. > I have a reproducer for the first two, as that is all I had time for; if you > would like them for the other two, I can get those for you tomorrow. @nathanchance I think the other two can be reproduced without difficulty. If the reproduc

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

hyeongyukim added a comment. In D105169#3211929 , @nathanchance wrote: > @hyeongyukim I am currently offline for the evening but it seems like my > reduction might have been too aggressive. It looks like this code comes from > `ravb_set_gti()` > (http

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

hyeongyukim added a comment. In D105169#3116810 , @nathanchance wrote: > Prior to the latest revert (fd9b099906c61e46574d1ea2d99b973321fe1d21 > ), the > Linux kernel's binary verifier

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

hyeongyukim added a comment. In D105169#3115814 , @erichkeane wrote: > Either this or D108453 (which were > committed together!) caused this assert according to my git-bisect: > https://godbolt.org/z/4rqYKfW7K > > NOT

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

hyeongyukim added a comment. In D105169#3115814 , @erichkeane wrote: > Either this or D108453 (which were > committed together!) caused this assert according to my git-bisect: > https://godbolt.org/z/4rqYKfW7K > > NOT

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

hyeongyukim added a comment. diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp b/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp index ea3e5bdbc754..826c6d36e1b1 100644 --- a/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp +++ b/compiler-rt/lib/sanitizer_common/s

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

hyeongyukim added a comment. I checked the reason for failure in address sanitizer tests on the 2-stage aarch64 buildbots. The buildbot failure was occured because the `internal_clone` function of the `compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp` file is being compiled incorrectly. The

[PATCH] D108453: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default (2)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8ca4b3ef19fe: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and… (authored by aqjune, committed by hyeongyukim). Reposito

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG80dba72a669b: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and… (authored by aqjune, committed by hyeongyukim). Changed

[PATCH] D108453: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default (2)

hyeongyukim updated this revision to Diff 380037. hyeongyukim added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108453/new/ https://reviews.llvm.org/D108453 Files: clang/test/CXX/except/except.spec/p14-ir.cpp clang/test/CXX

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

hyeongyukim added a comment. Thank you! In the meantime, I will rebase this patch and resolve conflicts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105169/new/ https://reviews.llvm.org/D105169 ___ cfe

[PATCH] D110230: [InstCombine] Update InstCombine to use poison instead of undef for shufflevector's placeholder (3/3)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG98e96663f6a7: [InstCombine] Update InstCombine to use poison instead of undef for… (authored by hyeongyukim). Herald added a project: clang. Herald a

[PATCH] D110226: [InstCombine] Update InstCombine to use poison instead of undef for shufflevector's placeholder (1/3)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe5aaf0332670: [InstCombine] Update InstCombine to use poison instead of undef for… (authored by hyeongyukim). Repository: rG LLVM Github Monorepo

[PATCH] D110226: [InstCombine] Update InstCombine to use poison instead of undef for shufflevector's placeholder (1/3)

hyeongyukim updated this revision to Diff 374213. hyeongyukim added a comment. Herald added subscribers: aheejin, sbc100. Correct the wrong rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110226/new/ https://reviews.llvm.org/D110226 Files:

[PATCH] D110226: [InstCombine] Update InstCombine to use poison instead of undef for shufflevector's placeholder (1/3)

hyeongyukim updated this revision to Diff 374212. hyeongyukim added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110226/new/ https://reviews.llvm.org/D110226 Files: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp llvm

[PATCH] D110226: [InstCombine] Update InstCombine to use poison instead of undef for shufflevector's placeholder (1/3)

hyeongyukim updated this revision to Diff 374210. hyeongyukim added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix comment, update test file(wasm.c) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110226/new/ ht

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

hyeongyukim added a comment. I did some experiments to confirm the benefits of adding a noundef attribute to the function parameter. (test result link ) One of the most significant advantages of this

[PATCH] D108453: [Clang/Test]: Enable enable_noundef_analysis as default(2)

hyeongyukim added a comment. This and D105169 are renewed version of the old patch (D82317 ). When pushing to the main branch, I'll commit this and D105169 as a single commit to avoid CI failur

[PATCH] D108453: [Clang/Test]: Enable enable_noundef_analysis as default(2)

hyeongyukim created this revision. Herald added subscribers: mstorsjo, frasercrmck, lxfind, jdoerfert, kerbowa, luismarques, apazos, sameer.abuasal, pengfei, s.egerton, Jim, jocewei, PkmX, jfb, arphaman, the_o, brucehoult, MartinMosbeck, rogfer01, atanasyan, edward-jones, zzheng, jrtc27, delcyph

[PATCH] D105169: [Clang/Test]: Enable enable_noundef_analysis as default

hyeongyukim updated this revision to Diff 367746. hyeongyukim added a comment. Herald added subscribers: cfe-commits, dexonsmith. Changed `disable_noundef_args` flag to `enable_noundef_args` to enable emitting `noundef` attributes on IR call arguments and return values by default. Changed test co