[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg added a comment. In https://reviews.llvm.org/D50542#1217517, @JonasToth wrote: > Committed r340928. Thanks very much! > > Will you (and your team) upstream even more abseil checks? I think it might > be reasonable to ask for commit rights. We will likely not be up streaming more in the

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg added a comment. In https://reviews.llvm.org/D50542#1217515, @JonasToth wrote: > In https://reviews.llvm.org/D50542#1217511, @hugoeg wrote: > > > nit comment fixed > > > DO you have commit rights or shall i commit for you? I do not have commit rights so I would appreciate it if you would

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg updated this revision to Diff 163083. hugoeg marked an inline comment as done. hugoeg added a comment. nit comment fixed https://reviews.llvm.org/D50542 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/NoInternalDependenciesCheck.cpp

[PATCH] D51132: [clang-tidy] abseil-redundant-strcat-calls-check

hugoeg updated this revision to Diff 162932. hugoeg added a comment. merge conflicts resolved @aaron.ballman https://reviews.llvm.org/D51132 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/RedundantStrcatCallsCheck.cpp clang-tidy/abseil/R

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg updated this revision to Diff 162921. hugoeg added a comment. renamed check as suggested https://reviews.llvm.org/D50542 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/NoInternalDependenciesCheck.cpp clang-tidy/abseil/NoInternalDe

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg updated this revision to Diff 162895. hugoeg marked 3 inline comments as done. hugoeg added a comment. fixed issues outlines in comments https://reviews.llvm.org/D50542 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/NoInternalDepsCh

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg marked an inline comment as done. hugoeg added inline comments. Comment at: test/clang-tidy/Inputs/absl/external-file.h:1 +void DirectAcess2() { absl::strings_internal::InternalFunction(); } + hokein wrote: > The file can not self-compile, and we should ma

[PATCH] D51061: [clang-tidy] abseil-str-cat-append

hugoeg added a comment. @aaron.ballman when you get the chance could you take another look at this and commit if it is ready? My internship ends rather soon and this is a tad time sensitive and I don't have commit access. Thank you for your time! https://reviews.llvm.org/D51061

[PATCH] D51132: [clang-tidy] abseil-redundant-strcat-calls-check

hugoeg added a comment. @aaron.ballman when you get the chance could you take another look at this and commit if it is ready? My internship ends rather soon and this is a tad time sensitive. Thank you for your time! https://reviews.llvm.org/D51132 ___

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg updated this revision to Diff 162864. hugoeg marked 2 inline comments as done. hugoeg added a comment. made some major updates after no-namespace landed https://reviews.llvm.org/D50542 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/

[PATCH] D51132: [clang-tidy] abseil-redundant-strcat-calls-check

hugoeg added a comment. In https://reviews.llvm.org/D51132#1212903, @Eugene.Zelenko wrote: > Indentation of example in documentation is still fixed. yea sorry about that, I caught that after i updated the diff and corrected and re updated https://reviews.llvm.org/D51132 __

[PATCH] D51132: [clang-tidy] abseil-redundant-strcat-calls-check

hugoeg updated this revision to Diff 162462. https://reviews.llvm.org/D51132 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/RedundantStrcatCallsCheck.cpp clang-tidy/abseil/RedundantStrcatCallsCheck.h docs/ReleaseNotes.rst docs/clang-ti

[PATCH] D51132: [clang-tidy] abseil-redundant-strcat-calls-check

hugoeg updated this revision to Diff 162455. https://reviews.llvm.org/D51132 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/RedundantStrcatCallsCheck.cpp clang-tidy/abseil/RedundantStrcatCallsCheck.h docs/ReleaseNotes.rst docs/clang-ti

[PATCH] D51132: [clang-tidy] abseil-redundant-strcat-calls-check

hugoeg updated this revision to Diff 162454. hugoeg marked an inline comment as done. https://reviews.llvm.org/D51132 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/RedundantStrcatCallsCheck.cpp clang-tidy/abseil/RedundantStrcatCallsCheck.

[PATCH] D51132: [clang-tidy] abseil-redundant-strcat-calls-check

hugoeg updated this revision to Diff 162438. hugoeg marked 2 inline comments as done. hugoeg added a comment. added corrections https://reviews.llvm.org/D51132 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/RedundantStrcatCallsCheck.cpp

[PATCH] D51132: [clang-tidy] abseil-redundant-strcat-calls-check

hugoeg updated this revision to Diff 162405. hugoeg marked an inline comment as done. hugoeg added a comment. minor updates https://reviews.llvm.org/D51132 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/RedundantStrcatCallsCheck.cpp clan

[PATCH] D51061: [clang-tidy] abseil-str-cat-append

hugoeg updated this revision to Diff 162403. hugoeg marked an inline comment as done. https://reviews.llvm.org/D51061 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/StrCatAppendCheck.cpp clang-tidy/abseil/StrCatAppendCheck.h docs/Release

[PATCH] D51061: [clang-tidy] abseil-str-cat-append

hugoeg updated this revision to Diff 162395. hugoeg added a comment. ran svn update https://reviews.llvm.org/D51061 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/StrCatAppendCheck.cpp clang-tidy/abseil/StrCatAppendCheck.h docs/Release

[PATCH] D51061: [clang-tidy] abseil-str-cat-append

hugoeg updated this revision to Diff 162390. hugoeg marked 9 inline comments as done. hugoeg added a comment. applied corrections from comments https://reviews.llvm.org/D51061 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/StrCatAppendChec

[PATCH] D51132: [clang-tidy] abseil-redundant-strcat-calls-check

hugoeg added inline comments. Comment at: clang-tidy/abseil/RedundantStrcatCallsCheck.cpp:37-38 + // Those are handled on the ancestor call. + const auto CallToEither = callExpr( + callee(functionDecl(hasAnyName("::absl::StrCat", "::absl::StrAppend"; + Finder->addMatc

[PATCH] D51132: [clang-tidy] abseil-redundant-strcat-calls-check

hugoeg updated this revision to Diff 162382. hugoeg marked 7 inline comments as done. hugoeg added a comment. applied corrections form comments https://reviews.llvm.org/D51132 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/RedundantStrcatC

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg added inline comments. Comment at: test/clang-tidy/abseil-no-internal-deps.cpp:8 +#include "absl/external-file.h" +// CHECK: absl/external-file.h:1:23: warning: do not reference any 'internal' namespaces; those implementation details are reserved to Abseil [abseil-no-int

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg updated this revision to Diff 162379. hugoeg marked 2 inline comments as done. hugoeg added a comment. fixed comments https://reviews.llvm.org/D50542 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/NoInternalDepsCheck.cpp clang-tid

[PATCH] D51132: [clang-tidy] abseil-redundant-strcat-calls-check

hugoeg updated this revision to Diff 162256. hugoeg added a comment. minor fixes and style improvement https://reviews.llvm.org/D51132 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/RedundantStrcatCallsCheck.cpp clang-tidy/abseil/Redunda

[PATCH] D51061: [clang-tidy] abseil-str-cat-append

hugoeg updated this revision to Diff 162253. hugoeg added a comment. minor fixes, style improvements https://reviews.llvm.org/D51061 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/StrCatAppendCheck.cpp clang-tidy/abseil/StrCatAppendCheck

[PATCH] D51061: [clang-tidy] abseil-str-cat-append

hugoeg updated this revision to Diff 162231. https://reviews.llvm.org/D51061 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/StrCatAppendCheck.cpp clang-tidy/abseil/StrCatAppendCheck.h docs/ReleaseNotes.rst docs/clang-tidy/checks/abseil

[PATCH] D51061: [clang-tidy] abseil-str-cat-append

hugoeg added a comment. Let me know if there's anything else I can fix to move the process along. https://reviews.llvm.org/D51061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51132: [clang-tidy] abseil-redundant-strcat-calls-check

hugoeg updated this revision to Diff 162223. https://reviews.llvm.org/D51132 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/RedundantStrcatCallsCheck.cpp clang-tidy/abseil/RedundantStrcatCallsCheck.h docs/ReleaseNotes.rst docs/clang-ti

[PATCH] D51132: [clang-tidy] abseil-redundant-strcat-calls-check

hugoeg updated this revision to Diff 162219. https://reviews.llvm.org/D51132 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/RedundantStrcatCallsCheck.cpp clang-tidy/abseil/RedundantStrcatCallsCheck.h docs/ReleaseNotes.rst docs/clang-ti

[PATCH] D51132: [clang-tidy] abseil-redundant-strcat-calls-check

hugoeg updated this revision to Diff 162174. hugoeg added a comment. corrections applied https://reviews.llvm.org/D51132 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/RedundantStrcatCallsCheck.cpp clang-tidy/abseil/RedundantStrcatCallsC

[PATCH] D51132: [clang-tidy] abseil-redundant-strcat-calls-check

hugoeg marked 7 inline comments as done. hugoeg added a comment. If the fix-it can be implemented, I certainly do not know how. As mentioned above, I am not the original author for this check. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51132 _

[PATCH] D51061: [clang-tidy] abseil-str-cat-append

hugoeg updated this revision to Diff 161995. hugoeg marked 2 inline comments as done. https://reviews.llvm.org/D51061 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/StrCatAppendCheck.cpp clang-tidy/abseil/StrCatAppendCheck.h docs/Release

[PATCH] D51061: [clang-tidy] abseil-str-cat-append

hugoeg updated this revision to Diff 161982. https://reviews.llvm.org/D51061 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/StrCatAppendCheck.cpp clang-tidy/abseil/StrCatAppendCheck.h docs/ReleaseNotes.rst docs/clang-tidy/checks/abseil

[PATCH] D51061: [clang-tidy] abseil-str-cat-append

hugoeg updated this revision to Diff 161974. hugoeg added a comment. minor fixes https://reviews.llvm.org/D51061 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/StrCatAppendCheck.cpp clang-tidy/abseil/StrCatAppendCheck.h docs/ReleaseNot

[PATCH] D51061: [clang-tidy] abseil-str-cat-append

hugoeg added inline comments. Comment at: test/clang-tidy/abseil-str-cat-append.cpp:91 + +void bar() { + std::string a, b; JonasToth wrote: > What happens if `StrCat` is used e.g. in an `std::accumulate` call as the > binary operator? (https://en.cppreference.c

[PATCH] D51061: [clang-tidy] abseil-str-cat-append

hugoeg updated this revision to Diff 161970. hugoeg marked 11 inline comments as done. hugoeg added a comment. applied corrections from comments https://reviews.llvm.org/D51061 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/StrCatAppendChe

[PATCH] D50580: [clang-tidy] Abseil: no namespace check

hugoeg added inline comments. Comment at: clang-tidy/abseil/AbseilMatcher.h:32 + auto Filename = FileEntry->getName(); + llvm::Regex RE("absl/(base|container|debugging|memory|meta|numeric|strings|" + "synchronization|types|utiliy)"); deannagarci

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg added a comment. Ok , so I've clean some stuff up, I'm currently working with @deannagarcia to get https://reviews.llvm.org/D50580 submitted with the match I implemented for us first, then will adjust this as necessary https://reviews.llvm.org/D50542 _

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg updated this revision to Diff 161714. hugoeg marked an inline comment as done. hugoeg added a comment. All comments have been address and documentation has been added to matcher https://reviews.llvm.org/D50542 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg updated this revision to Diff 161550. hugoeg added a comment. refined test to include some more cases as a result of the new matcher https://reviews.llvm.org/D50542 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/NoInternalDepsCheck.

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg marked an inline comment as done. hugoeg added inline comments. Comment at: clang-tidy/abseil/NoInternalDepsCheck.cpp:20 + +bool IsInAbseilFile(const SourceManager& manager, SourceLocation loc){ + if (loc.isInvalid()) { hokein wrote: > hugoeg wrote: > > h

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg updated this revision to Diff 161494. hugoeg marked 5 inline comments as done. hugoeg added a comment. corrections applied https://reviews.llvm.org/D50542 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/NoInternalDepsCheck.cpp clan

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg updated this revision to Diff 161485. hugoeg added a comment. fixed some minor things in the test https://reviews.llvm.org/D50542 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/NoInternalDepsCheck.cpp clang-tidy/abseil/NoInternalD

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg added a comment. Anymore changes I should make or issues I should be aware of? https://reviews.llvm.org/D50542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg added inline comments. Comment at: clang-tidy/abseil/NoInternalDepsCheck.cpp:20 + +bool IsInAbseilFile(const SourceManager& manager, SourceLocation loc){ + if (loc.isInvalid()) { hokein wrote: > I think we can make it as an ASTMatcher instead of a functio

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg updated this revision to Diff 161263. hugoeg marked 5 inline comments as done. hugoeg added a comment. applied corrections form comments https://reviews.llvm.org/D50542 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/NoInternalDepsCh

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg updated this revision to Diff 161130. hugoeg added a comment. added IsInAbseilFile Matcher https://reviews.llvm.org/D50542 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/NoInternalDepsCheck.cpp clang-tidy/abseil/NoInternalDepsChec

[PATCH] D50852: abseil-auto-make-unique

hugoeg added a comment. In https://reviews.llvm.org/D50852#1202774, @lebedev.ri wrote: > 1. Please always upload all patches with full context. > 2. There already is `modernize-use-auto`. Does it handle this case? Then this > should be just an alias to that check. Else, i think it would be best

[PATCH] D50852: abseil-auto-make-unique

hugoeg added a comment. what do you mean by "with full context"? https://reviews.llvm.org/D50852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50852: abseil-auto-make-unique

hugoeg created this revision. hugoeg added reviewers: alexfh, hokein. hugoeg added a project: clang-tools-extra. Herald added a subscriber: mgorny. warns to use 'auto' to avoid repeating the type name and fixes the issue Replace: std::unique_ptr x = make_unique(...); with: auto x = make_uniqu

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg added inline comments. Comment at: test/clang-tidy/abseil-fake-declarations.h:1 +namespace std { +struct string { hokein wrote: > I'd expect this header file is used as as a real absl library file: > > * create an `absl` directory in `test/clang-tidy/Inpu

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg updated this revision to Diff 160562. hugoeg marked an inline comment as done. https://reviews.llvm.org/D50542 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/NoInternalDepsCheck.cpp clang-tidy/abseil/NoInternalDepsCheck.h docs/Rel

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg updated this revision to Diff 160432. hugoeg marked an inline comment as done. hugoeg added a comment. applied corrections from comments https://reviews.llvm.org/D50542 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/NoInternalDepsCh

[PATCH] D50580: [clang-tidy] Abseil: no namespace check

hugoeg added inline comments. Comment at: clang-tidy/abseil/NoNamespaceCheck.cpp:23 + + Finder->addMatcher(namespaceDecl(hasName("absl")).bind("absl_namespace"), + this); deannagarcia wrote: > aaron.ballman wrote: > > hokein wrote: > > > aaro

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg updated this revision to Diff 160380. hugoeg marked 3 inline comments as done. https://reviews.llvm.org/D50542 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/NoInternalDepsCheck.cpp clang-tidy/abseil/NoInternalDepsCheck.h docs/Rel

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg added inline comments. Comment at: test/clang-tidy/abseil-no-internal-deps.cpp:2 +// RUN: %check_clang_tidy %s abseil-no-internal-deps %t + + JonasToth wrote: > hugoeg wrote: > > hokein wrote: > > > nit: please make sure the code follow LLVM code style, ev

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg updated this revision to Diff 160371. https://reviews.llvm.org/D50542 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/NoInternalDepsCheck.cpp clang-tidy/abseil/NoInternalDepsCheck.h docs/ReleaseNotes.rst docs/clang-tidy/checks/ab

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg updated this revision to Diff 160363. hugoeg added a comment. most corrections from comments have been applied https://reviews.llvm.org/D50542 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/NoInternalDepsCheck.cpp clang-tidy/absei

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg marked 8 inline comments as done. hugoeg added inline comments. Comment at: test/clang-tidy/abseil-no-internal-deps.cpp:2 +// RUN: %check_clang_tidy %s abseil-no-internal-deps %t + + hokein wrote: > nit: please make sure the code follow LLVM code style, ev

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg updated this revision to Diff 160168. hugoeg added a comment. corrections from comments applied https://reviews.llvm.org/D50542 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/NoInternalDepsCheck.cpp clang-tidy/abseil/NoInternalDep

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg updated this revision to Diff 160124. https://reviews.llvm.org/D50542 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/NoInternalDepsCheck.cpp clang-tidy/abseil/NoInternalDepsCheck.h docs/ReleaseNotes.rst docs/clang-tidy/checks/ab

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg added inline comments. Comment at: clang-tidy/abseil/NoInternalDepsCheck.cpp:24 + + Finder->addMatcher( + nestedNameSpecifierLoc(loc(specifiesNamespace(namespaceDecl( JonasToth wrote: > Actually that one is generally useful. Accessing the `foo::inter

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg updated this revision to Diff 160112. hugoeg marked 10 inline comments as done. hugoeg added a comment. Applied corrections from first round comments https://reviews.llvm.org/D50542 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/NoI