[PATCH] D45812: Fix __attribute__((force_align_arg_pointer)) misalignment bug

2018-04-19 Thread Henrik Gramner via Phabricator via cfe-commits
Gramner added a comment. In https://reviews.llvm.org/D45812#1072128, @erichkeane wrote: > LGTM, Do you have commit access, or do you want me to commit it for you? I do not have commit access, so please do. Thanks for the review. https://reviews.llvm.org/D45812 _

[PATCH] D45812: Fix __attribute__((force_align_arg_pointer)) misalignment bug

2018-04-19 Thread Henrik Gramner via Phabricator via cfe-commits
Gramner added a comment. In https://reviews.llvm.org/D45812#1072066, @erichkeane wrote: > Can you make sure that this doesn't cause stackrealign to happen 2x if using > -mstackrealign? Additionally, please provide the diff with full-context (see > https://llvm.org/docs/Phabricator.html#request

[PATCH] D45812: Fix __attribute__((force_align_arg_pointer)) misalignment bug

2018-04-19 Thread Henrik Gramner via Phabricator via cfe-commits
Gramner updated this revision to Diff 143083. Gramner added a comment. Full context. https://reviews.llvm.org/D45812 Files: lib/CodeGen/TargetInfo.cpp test/CodeGen/function-attributes.c Index: test/CodeGen/function-attributes.c =

[PATCH] D45812: Fix __attribute__((force_align_arg_pointer)) misalignment bug

2018-04-19 Thread Henrik Gramner via Phabricator via cfe-commits
Gramner created this revision. Gramner added a reviewer: erichkeane. Gramner added a project: clang. Herald added a subscriber: javed.absar. The force_align_arg_pointer attribute was using a hardcoded 16-byte alignment value which in combination with -mstack-alignment=32 (or larger) would produce