[PATCH] D158763: [flang][driver] Mark -L as visible in Flang

2023-08-25 Thread Hao Jin via Phabricator via cfe-commits
erjin added inline comments. Comment at: clang/include/clang/Driver/Options.td:821 def L : JoinedOrSeparate<["-"], "L">, Flags<[RenderJoined]>, Group, +Visibility<[ClangOption, FlangOption]>, MetaVarName<"">, HelpText<"Add directory to library search path">; ---

[PATCH] D158763: [flang][driver] Mark -L as visible in Flang

2023-08-25 Thread Hao Jin via Phabricator via cfe-commits
erjin added a comment. In D158763#4616664 , @awarzynski wrote: > LGTM, thank you! Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158763/new/ https://reviews.llvm.org/D158763 __

[PATCH] D158763: [flang][driver] Mark -L as visible in Flang

2023-08-25 Thread Hao Jin via Phabricator via cfe-commits
erjin updated this revision to Diff 553488. erjin added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158763/new/ https://reviews.llvm.org/D158763 Files: clang/include/clang/Driver/Options.td flang/test/Driver/driver-help-hid

[PATCH] D158763: [flang][driver] Mark -L as visible in Flang

2023-08-24 Thread Hao Jin via Phabricator via cfe-commits
erjin updated this revision to Diff 553217. erjin added a comment. update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158763/new/ https://reviews.llvm.org/D158763 Files: clang/include/clang/Driver/Options.td flang/test/Driver/driver-hel

[PATCH] D158763: [flang][driver] Mark -L as visible in Flang

2023-08-24 Thread Hao Jin via Phabricator via cfe-commits
erjin created this revision. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added projects: Flang, All. erjin requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D158430: [flang][driver] Mark -fuse-ld as visible in Flang

2023-08-22 Thread Hao Jin via Phabricator via cfe-commits
erjin updated this revision to Diff 552498. erjin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158430/new/ https://reviews.llvm.org/D158430 Files: clang/include/clang/Driver/Options.td flang/test/Driver/misc-flags.f90

[PATCH] D158430: [flang][driver] Mark -fuse-ld as visible in Flang

2023-08-21 Thread Hao Jin via Phabricator via cfe-commits
erjin updated this revision to Diff 552091. erjin added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158430/new/ https://reviews.llvm.org/D158430 Files: clang/include/clang/Driver/Options.td flang/test/Driver/misc-flags.f90

[PATCH] D158430: [flang][driver] Mark -fuse-ld as visible in Flang

2023-08-21 Thread Hao Jin via Phabricator via cfe-commits
erjin added a comment. In D158430#4603925 , @kiranchandramohan wrote: > Thanks. Thank you for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158430/new/ https://reviews.llvm.org/D158430 _

[PATCH] D158430: [flang][driver] Mark -fuse-ld as visible in Flang

2023-08-21 Thread Hao Jin via Phabricator via cfe-commits
erjin updated this revision to Diff 552068. erjin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158430/new/ https://reviews.llvm.org/D158430 Files: clang/include/clang/Driver/Options.td flang/test/Driver/misc-flags.f90

[PATCH] D158430: [flang][driver] Mark -fuse-ld as visible in Flang

2023-08-21 Thread Hao Jin via Phabricator via cfe-commits
erjin created this revision. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added projects: Flang, All. erjin requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D157040: [OpenMP][IR] Set correct alignment for internal variables

2023-08-10 Thread Hao Jin via Phabricator via cfe-commits
erjin added a comment. Ping. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157040/new/ https://reviews.llvm.org/D157040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D157040: [OpenMP][IR] Set correct alignment for internal variables

2023-08-08 Thread Hao Jin via Phabricator via cfe-commits
erjin updated this revision to Diff 548344. erjin added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. se Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157040/new/ https://reviews.llvm.org/D157040 Files: clang/