[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

abidh accepted this revision. abidh added a comment. The BareMetal.cpp part looks ok to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 ___ cfe-commits mail

[PATCH] D136712: Define _GNU_SOURCE for arm baremetal in C++ mode.

abidh added a comment. In D136712#3892986 , @manojgupta wrote: > @tomhughes has more details on this but if we do not define it in clang > itself, we'll need to define it for every package manually at build time > since the usage goes deep inside newli

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

abidh added a comment. In D131225#3706239 , @barannikov88 wrote: > In D131225#3706207 , @abidh wrote: > >> I think this patch is moving the things in the right direction. But please >> wait for some other review

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

abidh added a comment. I think this patch is moving the things in the right direction. But please wait for some other reviewers to chime in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131225/new/ https://reviews.llvm.org/D131225 __

[PATCH] D93138: Add initial support for multilibs in Baremetal toolchain.

abidh added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:177 if (!getDriver().SysRoot.empty()) -return getDriver().SysRoot; +return getDriver().SysRoot + SelectedMultilib.osSuffix(); zixuan-wu wrote: > I think the multilib o

[PATCH] D119837: [RISCV] Fix the include search path order between sysroot and resource folder

abidh added a comment. In D119837#3326179 , @asb wrote: > Thanks Kito. This LGTM, but I'd appreciate someone else reviewing and > approving as well. Looks ok to me too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D105414: Add x86 and x86_64 to the BareMetal toolchain

abidh added a comment. You need to add some tests that check the functionality that you are adding. Look at clang/test/Driver/baremetal.cpp for an example. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105414/new/ https://reviews.llvm.org/D105414

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

abidh added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5216-5220 +if (toolchains::RISCVToolChain::hasGCCToolchain(*this, Args)) + TC = + std::make_unique(*this, Target, Args); +else + TC = std::make_unique(*this, Targe

[PATCH] D102049: [BareMetal] Ensure that sysroot always comes after library paths

abidh accepted this revision. abidh added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102049/new/ https://reviews.llvm.org/D102049 ___ c

[PATCH] D92677: Provide default location of sysroot for Baremetal toolchain.

abidh added a comment. If gcc and clang based toolchains are installed in the same prefix then having sysroot at same location can cause one installation to overwrite parts of other. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92677/new/ https:/

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

abidh added a comment. In D98113#2609027 , @jrtc27 wrote: > One thing that is currently rather ugly about BareMetal is that it ignores > the AddArch argument. Once you have a sysroot, the architecture suffix is > rather unnecessary, and given compiler-rt

[PATCH] D93023: Replace deprecated %T in 2 tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rG60bed4ab57d5: Replace deprecated %T in 2 tests. (authored by abidh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93023/new/ https://reviews.llvm.org/D9302

[PATCH] D93023: Replace deprecated %T in 2 tests.

abidh updated this revision to Diff 322970. abidh added a comment. Changes in this version. 1. Added an explicit --sysroot argument. 2. Shortened "testroot-riscv{len}-baremetal-nogcc" string As pointed out by @MaskRay that some tests were failing when gcc-10-riscv64-linux-gnu was installed. Th

[PATCH] D93138: Add initial support for multilibs in Baremetal toolchain.

This revision was automatically updated to reflect the committed changes. abidh marked 3 inline comments as done. Closed by commit rG670686ad8ecc: Add initial support for multilibs in Baremetal toolchain. (authored by abidh). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D93023: Replace deprecated %T in 2 tests.

abidh added a comment. It seems that testcase I added has brought to surface a hidden issue. If you look at the end of Generic_GCC::GCCInstallationDetector::AddDefaultGCCPrefixes, it adds sysroot/usr to the Prefixes. If the sysroot is empty, this will end up using the toolchain that you installed

[PATCH] D93023: Replace deprecated %T in 2 tests.

abidh added a comment. In D93023#2446757 , @MaskRay wrote: > If you do this, `testroot-riscv64-baremetal-nogcc/` is probably also not > useful (or you can replace it with a shorter string`. > > Can you fix the tests when gcc-riscv64-linux-gnu is installed

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

abidh added a comment. In D91442#2444399 , @MaskRay wrote: > This change has been failing on my machine for the past two weeks. > > `riscv32-toolchain-extra.c` and `riscv64-toolchain-extra.c` are not hermit. I > have installed `/usr/lib/gcc-cross/riscv64-

[PATCH] D93023: Replace deprecated %T in 2 tests.

abidh created this revision. abidh added a reviewer: MaskRay. abidh added a project: clang. Herald added subscribers: frasercrmck, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD,

[PATCH] D92677: Provide default location of sysroot for Baremetal toolchain.

This revision was automatically updated to reflect the committed changes. Closed by commit rG275592e71413: Provide default location of sysroot for Baremetal toolchain. (authored by abidh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92677/new/ ht

[PATCH] D92677: Provide default location of sysroot for Baremetal toolchain.

abidh marked an inline comment as done. abidh added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:108 + + return std::string(SysRootDir.str()); +} jroelofs wrote: > Small string has an implicit conversion to std::string, so you can just

[PATCH] D92677: Provide default location of sysroot for Baremetal toolchain.

abidh updated this revision to Diff 309637. abidh added a comment. Handled review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92677/new/ https://reviews.llvm.org/D92677 Files: clang/lib/Driver/ToolChains/BareMetal.cpp clang/lib/Driver/ToolChains/BareMetal.h clang/test

[PATCH] D92677: Provide default location of sysroot for Baremetal toolchain.

abidh created this revision. abidh added reviewers: mcarrasco, jroelofs. abidh added a project: clang. Herald added subscribers: s.egerton, PkmX, simoncook, kristof.beyls. abidh requested review of this revision. Herald added a subscriber: cfe-commits. Currently, Baremetal toolchain requires user

[PATCH] D92176: Don't use sysroot/include when sysroot is empty.

This revision was automatically updated to reflect the committed changes. Closed by commit rGca2888310b24: Don't use sysroot/include when sysroot is empty. (authored by abidh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92176/new/ https://reviews

[PATCH] D92176: Don't use sysroot/include when sysroot is empty.

abidh added a comment. @jroelofs Do you have any comments on this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92176/new/ https://reviews.llvm.org/D92176 ___ cfe-commits mailing list cfe-commits@

[PATCH] D92176: Don't use sysroot/include when sysroot is empty.

abidh created this revision. abidh added reviewers: jroelofs, manojgupta, cjdb. abidh added a project: clang. Herald added a subscriber: cfe-commits. abidh requested review of this revision. Baremetal toolchain add Driver.SysRoot/include to the system include paths without checking if Driver.SysRo

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

This revision was automatically updated to reflect the committed changes. Closed by commit rG45ba2392d7e0: [clang][Driver] Handle risvc in Baremetal.cpp. (authored by abidh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91442/new/ https://reviews.l

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

abidh added a comment. Hi @lenary, Do you any more comments on the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91442/new/ https://reviews.llvm.org/D91442 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

abidh updated this revision to Diff 306180. abidh added a comment. Herald added a subscriber: MaskRay. This update contains following changes. 1. Address issue raised by lenary. I have introduced a static function that checks for the presence of gcc toolchain first by --gcc-toolchain argument or

[PATCH] D91559: Add sysroot/lib to library search path of baremetal toolchain.

This revision was automatically updated to reflect the committed changes. abidh marked an inline comment as done. Closed by commit rG8cdc53887387: Add sysroot/lib to library search path of baremetal toolchain. (authored by abidh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91559: Add sysroot/lib to library search path of baremetal toolchain.

abidh marked an inline comment as done. abidh added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:39 +llvm::sys::path::append(SysRoot, "lib"); +getFilePaths().push_back(std::string(SysRoot.str())); + } jroelofs wrote: > Is the ex

[PATCH] D91559: Add sysroot/lib to library search path of baremetal toolchain.

abidh updated this revision to Diff 306036. abidh added a comment. Handle review comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91559/new/ https://reviews.llvm.org/D91559 Files: clang/lib/Driver/ToolChains/BareMetal.cpp clang/test/Driver/baremetal.cpp Index: clang/test/Dr

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

abidh added a comment. In D91442#2399772 , @lenary wrote: > I recall that there is also https://reviews.llvm.org/D68407 which iirc hoped > to address using `RISCVToolchain` with Compiler-rt and libunwind - presumably > it is not a complete solution, but

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

abidh added a comment. In D91442#2399753 , @jrtc27 wrote: > In D91442#2399750 , @abidh wrote: > >> In D91442#2399402 , @lenary wrote: >> >>> In D91442#2399341

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

abidh added a comment. In D91442#2399402 , @lenary wrote: > In D91442#2399341 , @abidh wrote: > >> In D91442#2399200 , @lenary wrote: >> >>> I'm worried about this change - I

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

abidh added a comment. In D91442#2399200 , @lenary wrote: > I'm worried about this change - I *think* it doesn't cover the existing > behaviour of a baremetal GCC toolchain being installed into the same prefix > as clang, and clang automatically picking

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

abidh marked an inline comment as done. abidh added a comment. In D91442#2394501 , @jroelofs wrote: > Seems reasonable. > > I could see someone wanting to use `--gcc-toolchain` to point at the > baremetal toolchain for their target, but that's unlikely to

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

abidh updated this revision to Diff 305573. abidh added a comment. Made the condition consistent in both places where Baremetal toolchain is instantiated as suggested in review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91442/new/ https://reviews.llvm.org/D91442 Files: clang/lib

[PATCH] D91559: Add sysroot/lib to library search path of baremetal toolchain.

abidh created this revision. abidh added reviewers: jroelofs, clang. Herald added a project: clang. Herald added a subscriber: cfe-commits. abidh requested review of this revision. Baremetal toolchain is not adding sysroot/lib to the library search path. This is forcing the user to do it manually.

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

abidh added a comment. In D91442#2394513 , @jrtc27 wrote: > We use pure LLVM toolchains so improving support for that out of the box is > good in my books. However, I do worry this is going to cause friction for a > lot of people using LLVM for RISC-V; m

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

abidh created this revision. abidh added reviewers: asb, jroelofs, manojgupta, clang. Herald added subscribers: cfe-commits, frasercrmck, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, n

[PATCH] D68362: [libunwind][RISCV] Add 64-bit RISC-V support

abidh added inline comments. Comment at: libunwind/src/Registers.hpp:3765 +inline void Registers_riscv::setFloatRegister(int regNum, double value) { +#ifdef __riscv_flen == 64 + assert(validFloatRegister(regNum)); I am building these changes and get the followin