o.gyorgy added a comment.
In https://reviews.llvm.org/D24040#530546, @mehdi_amini wrote:
> > This looks like a fairly large tool. Should it get its own "subproject
> > level" directory in the SVN instead of being nested within clang?
>
>
> I'd add that the clang-tools-extra are more closely tied
o.gyorgy added a comment.
In https://reviews.llvm.org/D24040#530293, @rizsotto.mailinglist wrote:
> Gyorgy and the ericsson team, thanks for doing this. very good job! good
> targeted functionality. i don't want to underestimate the complexity it
> requires, but to me this is a giant code. i do
o.gyorgy added a subscriber: o.gyorgy.
o.gyorgy marked an inline comment as done.
o.gyorgy added a comment.
I did not create a test checker for the NormalizeLine error in the patch.
Should I add a test checker for this? Do you have any suggestions
where to put it if required?
GetEnclosingDeclCont
o.gyorgy updated this revision to Diff 41024.
o.gyorgy added a comment.
Some small format changes. Based on the review.
http://reviews.llvm.org/D14919
Files:
include/clang/StaticAnalyzer/Core/IssueHash.h
lib/Basic/SourceManager.cpp
lib/StaticAnalyzer/Checkers/DebugCheckers.cpp
lib/Stati
o.gyorgy updated this revision to Diff 40920.
o.gyorgy added a comment.
Regenerate patch with context and clang format HTMLDiagnostics.cpp.
http://reviews.llvm.org/D14919
Files:
include/clang/StaticAnalyzer/Core/IssueHash.h
lib/Basic/SourceManager.cpp
lib/StaticAnalyzer/Checkers/DebugChec
o.gyorgy created this revision.
o.gyorgy added reviewers: zaks.anna, xazax.hun, dcoughlin, jordan_rose.
o.gyorgy added a subscriber: cfe-commits.
Fixing IssueHash generation.
There were some problems with the current version.
If the Decl *D pointer is nullptr the NormalizeLine would crash while g
o.gyorgy added a comment.
Hi,
Sorry for my late answer.
We fixed the plist parser for the CodeChecker it shoud process the
plist generated by the current trunk clang with the issue hash tags.
Right now CodeChecker does not support forwarding additional options
directly to clang (uses only the co
o.gyorgy added a comment.
Hi,
You are right the diff is is based on the hash. We already tried to
use an earlier hash generator (before the patch was introduced), which
generates a slightly different plist, that is why the current version
does not work with the patch.
We will fix CodeChecker to u
