[PATCH] D3976: -Wcomma, a new warning for questionable uses of the comma operator

2022-08-15 Thread Gregory PAKOSZ via Phabricator via cfe-commits
gpakosz added a comment. >> Should I open a bug? > > I think opening a bug is appropriate, good catch! Thanks for the reply Aaron. Here's the report: https://github.com/llvm/llvm-project/issues/57151 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D3976/new/ https:/

[PATCH] D3976: -Wcomma, a new warning for questionable uses of the comma operator

2022-08-13 Thread Gregory PAKOSZ via Phabricator via cfe-commits
gpakosz added a comment. Herald added a project: All. Hello, As of today, `-Wcomma` is not really documented: https://clang.llvm.org/docs/DiagnosticsReference.html#wcomma > The current whitelisted expressions are increments, decrements, assignments, > compound assignments, overloaded versions