[PATCH] D132711: [HLSL] add sqrt library function

pow2clk added a comment. A very minor suggestion. This looks pretty straightforward. Comment at: clang/test/CodeGenHLSL/builtins/sqrt.hlsl:6 +// RUN: dxil-pc-shadermodel6.3-library %s -emit-llvm -disable-llvm-passes \ +// RUN: -o - | FileCheck %s --check-prefix=NO_HALF + --

[PATCH] D124751: [HLSL] Support -E option for HLSL.

pow2clk added a comment. Looks to me that all the comments were responded to. I see nothing else worth commenting on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124751/new/ https://reviews.llvm.org/D124751 _

[PATCH] D125655: [HLSL] add -P option for dxc mode.

pow2clk added a comment. Mostly just some comments on user output Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:684 +def warn_drv_dxc_ignore_output_for_preprocess : Warning< + "output compiler options like -Fo ignored with Preprocess">, + InGroup; ---

[PATCH] D128462: [HLSL] add -I option for dxc mode.

pow2clk added a comment. I'm confused by the ways this option is allowed to be specified Comment at: clang/include/clang/Driver/Options.td:6824 +class DXCJoinedOrSeparateConflict : Option<["--", "/", "-"], name, + KIND_JOINED_OR_SEPARATE>, Group, Flags<[DXCOption, NoXarchOpti

[PATCH] D128845: [HLSL]Add -O and -Od option for dxc mode.

pow2clk added a comment. Looks good apart from my uncertainty as to what -fcgl should or shouldn't imply Comment at: clang/test/Driver/dxc_O.hlsl:9 +// CHECK: "-O0" +// CHECK-SAME: "-dxc-opt-disable" + It looks to me that these are added when -Od is specified,

[PATCH] D122627: [HLSL] Fix MSFT Attribute parsing, add numthreads

pow2clk added a comment. Looks good. I made a comment about the CS 4.0 thing, but that can be addressed when more thorough examination of the requested shader models comes around. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6857 + uint32_t ThreadMax = 1024; + if (SMVersion.g