[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis added a comment. In D102107#3417452 , @dhruvachak wrote: > I added https://github.com/llvm/llvm-project/issues/54654 documenting what I > found when testing this patch on amdgpu. > > @ggeorgakoudis Can you please rebase this patch on top o

[PATCH] D120573: [OpenMP] Support runtime user conditions in metadirective

ggeorgakoudis added a comment. In D120573#3415517 , @abidmalikwaterloo wrote: > Are you going to work on it? Just confirming. I am working on D122255 > . The code generation part for the dynamic > condition is useful.

[PATCH] D120573: [OpenMP] Support runtime user conditions in metadirective

ggeorgakoudis added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1793 +void CodeGenFunction::EmitOMPMetaDirective(const OMPMetaDirective &D) { + llvm::BasicBlock *AfterBlock = + createBasicBlock("omp.meta.user.condition.after"); abidmalik

[PATCH] D120573: [OpenMP] Support runtime user conditions in metadirective

ggeorgakoudis updated this revision to Diff 414139. ggeorgakoudis added a comment. Herald added subscribers: kbarton, nemanjai. Fix tentative parsing reverting Fix device codegen for metadirectives Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12057

[PATCH] D120573: [OpenMP] Support runtime user conditions in metadirective

ggeorgakoudis created this revision. Herald added subscribers: arphaman, guansong, yaxunl. ggeorgakoudis requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. Repository: rG LLVM G

[PATCH] D102555: [libclang] Enhance support for source-to-source rewriting

ggeorgakoudis added a comment. I'm not expert on this to review but I'm interested as a user. @samvv are you still working on this? Do you have any input from the community? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102555/new/ https://reviews

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis updated this revision to Diff 391099. ggeorgakoudis added a comment. Rebase, address comment, update few tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 Files: clang/lib/CodeGen/CGOp

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis updated this revision to Diff 386594. ggeorgakoudis added a comment. Herald added subscribers: asavonic, ormris. Update tests Fix for attributes to kmpc_alloc_aggregate_arg Do not emit allocations if there are no arguments in the aggregate Repository: rG LLVM Github Monorepo CHA

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis added a comment. TODO update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis updated this revision to Diff 385818. ggeorgakoudis added a comment. Update the interface for allocating/sharing the struct aggregate Simplify invoking tasks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.ll

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis added a comment. In D102107#3029825 , @pdhaliwal wrote: > Apologies for late reply. Most of the tests now do not try to call malloc, so > no page fault errors. But all of them are producing wrong results. For e.g. > declare_mapper_target.c

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis added a comment. In D102107#3028386 , @ronlieb wrote: > i backed up to your reverted patch, and applied this one. > I see some new errors > > libomptarget :: amdgcn-amd-amdhsa :: mapping/declare_mapper_target.cpp > libomptarget :: amdgcn

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis added a comment. @pdhaliwal @JonChesterfield @ronlieb I updated the aggregate argument memory allocation to use an alloca instead of malloc'ing in SPMD mode, which should resolve your issue. Could someone please test the updated patch and give me feedback before landing? Reposit

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis updated this revision to Diff 375634. ggeorgakoudis added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Update memory allocation for aggregate argument. Introduce runtime interface to allocate from local memory, when in SPMD mode, or heap, when i

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis added a comment. In D102107#3013233 , @ronlieb wrote: > seeing buildbot failures after this patch landed > https://lab.llvm.org/staging/#/builders/183/builds/1598 Looking it at @ronlieb, thanks for reporting Repository: rG LLVM Github

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d66649adf28: [OpenMP] Codegen aggregate for outlined function captures (authored by ggeorgakoudis). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis updated this revision to Diff 373982. ggeorgakoudis added a comment. Rebase and update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis updated this revision to Diff 373755. ggeorgakoudis added a comment. Fix for clang-tidy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis updated this revision to Diff 373107. ggeorgakoudis added a comment. Remove unnecessary comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 Files: clang/lib/CodeGen/CGOpenMPRuntime.c

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis updated this revision to Diff 373105. ggeorgakoudis added a comment. Add previous, upper bound to aggregate for combined distributed directives. Update tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.l

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis updated this revision to Diff 362305. ggeorgakoudis added a comment. Rebase, update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp cla

[PATCH] D106746: [OpenMPOpt] Expand SPMDization with guarding

ggeorgakoudis updated this revision to Diff 361468. ggeorgakoudis added a comment. Code cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106746/new/ https://reviews.llvm.org/D106746 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp llvm/inc

[PATCH] D106746: [OpenMPOpt][WIP] Expand SPMDization with guarding

ggeorgakoudis updated this revision to Diff 361456. ggeorgakoudis added a comment. Update for sensible access to __kmpc_is_spmd_guarded_exec_mode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106746/new/ https://reviews.llvm.org/D106746 Files: c

[PATCH] D106746: [OpenMPOpt][WIP] Expand SPMDIzation with guarding

ggeorgakoudis created this revision. Herald added subscribers: ormris, guansong, hiraditya, yaxunl. ggeorgakoudis requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a reviewer: jdoerfert. Herald added a reviewer: sstefan1. Herald added subscribers: llvm-commits, ope

[PATCH] D102105: [OpenMP][NFC] Refactor cc tests for implicit simd check

ggeorgakoudis abandoned this revision. ggeorgakoudis added a comment. Fixed in another revision (see description) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102105/new/ https://reviews.llvm.org/D102105 __

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis added a comment. Thanks for spotting. Test are auto-gened through update scripts so it should be easy to compare. I'll fix and ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe9c7291cb25f: [OpenMP] Codegen aggregate for outlined function captures (authored by ggeorgakoudis). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis updated this revision to Diff 359507. ggeorgakoudis added a comment. Herald added a subscriber: zzheng. Rebase, update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 Files: clang/li

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

ggeorgakoudis added a comment. LGMT too! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104714/new/ https://reviews.llvm.org/D104714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis updated this revision to Diff 352268. ggeorgakoudis added a comment. Update non-remark tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis added a comment. In D102107#2819869 , @lebedev.ri wrote: > (This is not offload-specific, right?) > This does not bring any compatibility issues, right? It's not offload-specific, so the patch applies to host OpenMP too. The patch, as is,

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis updated this revision to Diff 352178. ggeorgakoudis added a comment. Herald added a project: OpenMP. Herald added a subscriber: openmp-commits. Rebase to NewGlobalization and amend Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/n

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis added a comment. In D102107#2776237 , @jdoerfert wrote: > This allows us to remove the switch in the device runtime, right? Yes, with a complication: for combined directives of worksharing loops (distributed parallel for) clang emits the l

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis updated this revision to Diff 347230. ggeorgakoudis added a comment. Use non-aggregate captured args and outlining for ordered codegen Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 Files:

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis updated this revision to Diff 347206. ggeorgakoudis added a comment. Herald added a subscriber: jfb. Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 Files: clang/lib/CodeGen/CGOp

[PATCH] D102105: [OpenMP][NFC] Refactor cc tests for implicit simd check

ggeorgakoudis updated this revision to Diff 346255. ggeorgakoudis added a comment. Update for correct implicit checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102105/new/ https://reviews.llvm.org/D102105 Files: clang/test/OpenMP/cancel_code

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

ggeorgakoudis added a comment. In D101849#2766411 , @mikerice wrote: > In D101849#2764825 , @ABataev wrote: > >> No, it is not required. Most probably, needed to simplify test checks, >> nothing else. > > Thanks.

[PATCH] D101974: [Utils][WIP] Refactor script for cc tests

ggeorgakoudis updated this revision to Diff 346235. ggeorgakoudis added a comment. Update correction for implicit simd checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101974/new/ https://reviews.llvm.org/D101974 Files: clang/utils/refactor_

[PATCH] D102558: [Utils] Check for generated functions inline if possible

ggeorgakoudis added inline comments. Comment at: clang/test/utils/update_cc_test_checks/Inputs/generated-funcs.c.generated.expected:100 + } +} The checks for the outlined function are missing? Comment at: clang/test/utils/update_cc_test_chec

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis created this revision. Herald added subscribers: guansong, yaxunl. ggeorgakoudis requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://revie

[PATCH] D102105: [OpenMP][NFC] Refactor cc tests for implicit simd check

ggeorgakoudis created this revision. Herald added subscribers: jfb, guansong, yaxunl. ggeorgakoudis requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://

[PATCH] D101974: [Utils][WIP] Refactor script for cc tests

ggeorgakoudis updated this revision to Diff 343839. ggeorgakoudis added a comment. Update fopenmp-simd handling to avoid duplicate implicit checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101974/new/ https://reviews.llvm.org/D101974 Files:

[PATCH] D101974: [Utils][WIP] Refactor script for cc tests

ggeorgakoudis updated this revision to Diff 343438. ggeorgakoudis added a comment. Update regex for removing old checklines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101974/new/ https://reviews.llvm.org/D101974 Files: clang/utils/refactor_cc

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

ggeorgakoudis added a comment. In D101849#2741980 , @DavidSpickett wrote: > I've required X86 target for this test to get our bots green again. Thanks David for the workaround. I agree with Johannes's comments below. It looks like a bug. Repository:

[PATCH] D101974: [Utils][WIP] Refactor script for cc tests

ggeorgakoudis created this revision. ggeorgakoudis requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D101974 Files: clang/utils/re

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG207b08a9130b: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks (authored by ggeorgakoudis). Repository: rG LLVM Github Monore

[PATCH] D101952: [OpenMP] Fix non-determinism in clang copyin codegen

This revision was automatically updated to reflect the committed changes. Closed by commit rGf97b843d8819: [OpenMP] Fix non-determinism in clang copyin codegen (authored by ggeorgakoudis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101952/new/ ht

[PATCH] D101952: [OpenMP] Fix non-determinism in clang copyin codegen

ggeorgakoudis updated this revision to Diff 343262. ggeorgakoudis added a comment. Update for comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101952/new/ https://reviews.llvm.org/D101952 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp Index:

[PATCH] D101952: [OpenMP] Fix non-determinism in clang copyin codegen

ggeorgakoudis updated this revision to Diff 343256. ggeorgakoudis added a comment. Update by Johanne's correction on the source of non-determinism Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101952/new/ https://reviews.llvm.org/D101952 Files:

[PATCH] D101952: [OpenMP] Fix non-determinism in clang copyin codegen

ggeorgakoudis created this revision. Herald added subscribers: mgrang, guansong, yaxunl. ggeorgakoudis requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repository: rG LLVM Github Monorepo https

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

ggeorgakoudis updated this revision to Diff 343210. ggeorgakoudis added a comment. More updates to tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101849/new/ https://reviews.llvm.org/D101849 Files: clang/test/OpenMP/cancel_codegen.cpp cla

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

ggeorgakoudis updated this revision to Diff 343197. ggeorgakoudis added a comment. Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101849/new/ https://reviews.llvm.org/D101849 Files: clang/test/OpenMP/cancel_codegen.cpp clang/test/O

[PATCH] D101934: [Utils][NFC] Rename replace-function-regex in update_cc_test_checks

This revision was automatically updated to reflect the committed changes. Closed by commit rG78a7d8c4dd10: [Utils][NFC] Rename replace-function-regex in update_cc_test_checks (authored by ggeorgakoudis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D101934: [Utils][NFC] Rename replace-function-regex in update_cc_test_checks

ggeorgakoudis created this revision. Herald added a subscriber: arichardson. ggeorgakoudis requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG956cae2f09b2: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks (authored by ggeorgakoudis). Repository: rG LLVM Github Monore

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

ggeorgakoudis created this revision. Herald added subscribers: jfb, guansong, yaxunl. ggeorgakoudis requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://

[PATCH] D101683: [Utils] Run non-filecheck runlines in-order in update_cc_test_checks

This revision was automatically updated to reflect the committed changes. Closed by commit rG92f2c39f915a: [Utils] Run non-filecheck runlines in-order in update_cc_test_checks (authored by ggeorgakoudis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D101800: [OpenMP] Fix non-determinism in clang task codegen (lastprivates)

This revision was automatically updated to reflect the committed changes. Closed by commit rG313ee609e16b: [OpenMP] Fix non-determinism in clang task codegen (lastprivates) (authored by ggeorgakoudis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10

[PATCH] D101800: [OpenMP] Fix non-determinism in clang task codegen (lastprivates)

ggeorgakoudis created this revision. Herald added subscribers: mgrang, guansong, yaxunl. ggeorgakoudis requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repository: rG LLVM Github Monorepo https

[PATCH] D101739: [OpenMP] Fix non-determinism in clang task codegen

This revision was automatically updated to reflect the committed changes. Closed by commit rGa27ca15dd083: [OpenMP] Fix non-determinism in clang task codegen (authored by ggeorgakoudis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101739/new/ http

[PATCH] D101739: [OpenMP] Fix non-determinism in clang task codegen

ggeorgakoudis created this revision. Herald added subscribers: mgrang, guansong, yaxunl. ggeorgakoudis requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repository: rG LLVM Github Monorepo https

[PATCH] D101683: [Utils] Run non-filecheck runlines in-order in update_cc_test_checks

ggeorgakoudis created this revision. ggeorgakoudis requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D101683 File

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis added a comment. In D95976#2725027 , @protze.joachim wrote: > Please update the test with a NFC commit. Thanks, @protze.joachim. The changes look good. I'll get that NFC commit in soon-ish, unless you would like to take over. Repository:

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa2dbfb6b72db: [OpenMP] Simplify offloading parallel call codegen (authored by ggeorgakoudis). Changed prior to commit: https://reviews.llvm.org/D9

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis updated this revision to Diff 339334. ggeorgakoudis added a comment. Fix clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95976/new/ https://reviews.llvm.org/D95976 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis updated this revision to Diff 339265. ggeorgakoudis added a comment. Add tests, reduce microtask cases to avoid stack problems Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95976/new/ https://reviews.llvm.org/D95976 Files: clang/li

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis updated this revision to Diff 338554. ggeorgakoudis marked 2 inline comments as done. ggeorgakoudis added a comment. Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95976/new/ https://reviews.llvm.org/D95976 Files: clang/lib/Code

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis marked 4 inline comments as done. ggeorgakoudis added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1150 llvm::Value *IsMaster = Bld.CreateICmpEQ(RT.getGPUThreadID(CGF), getMasterThreadID(CGF)); Bld.CreateCondBr(IsMaster, MasterB

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis updated this revision to Diff 338441. ggeorgakoudis marked 2 inline comments as done. ggeorgakoudis added a comment. Update for comments, fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95976/new/ https://reviews.llvm.org/D95976

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis marked 4 inline comments as done. ggeorgakoudis added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:2192 RCG(CGF); } } jdoerfert wrote: > Can we remove SeqGen while we are here please. We need to check in the > runt

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis updated this revision to Diff 338246. ggeorgakoudis added a comment. Update for comments, fix for windows fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95976/new/ https://reviews.llvm.org/D95976 Files: clang/lib/CodeGen/CGOpenM

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis updated this revision to Diff 338102. ggeorgakoudis added a comment. Fix for getThreadsLimit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95976/new/ https://reviews.llvm.org/D95976 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis added a comment. Hi @Meinersbur (got word you are a windows user), @jdoerfert, could I ask your help in detecting why the clang tests on windows are failing? There are two failures I'm spotting, one is that calls to llvm.nvvm intrinsics seem transposed (https://reviews.llvm.org/ha

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis updated this revision to Diff 337556. ggeorgakoudis added a comment. Fix llvm test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95976/new/ https://reviews.llvm.org/D95976 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/tes

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis updated this revision to Diff 337183. ggeorgakoudis added a comment. Add aux-triple to one test, check unit test builder on windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95976/new/ https://reviews.llvm.org/D95976 Files: cla

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis updated this revision to Diff 337141. ggeorgakoudis added a comment. Herald added a subscriber: hiraditya. Add tests, update OpenMPOpt, rebase to main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95976/new/ https://reviews.llvm.org/D

[PATCH] D99415: [Utils] Add prefix parameter in update test checks to avoid FileCheck conflicts

This revision was automatically updated to reflect the committed changes. Closed by commit rG8bc2c662d9c0: [Utils] Add prefix parameter in update test checks to avoid FileCheck conflicts (authored by ggeorgakoudis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D99415: [Utils] Add prefix parameter in update test checks to avoid FileCheck conflicts

ggeorgakoudis updated this revision to Diff 333584. ggeorgakoudis marked an inline comment as done. ggeorgakoudis added a comment. Update for comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99415/new/ https://reviews.llvm.org/D99415 Files:

[PATCH] D99415: [Utils] Add prefix parameter in update test checks to avoid FileCheck conflicts

ggeorgakoudis created this revision. Herald added a subscriber: arichardson. ggeorgakoudis requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D99415 Files: cl

[PATCH] D98712: [Utils] Support lit-like substitutions in update_cc_test_checks

ggeorgakoudis added inline comments. Comment at: llvm/utils/update_cc_test_checks.py:228 + '%t' : tempfile.NamedTemporaryFile().name, + '%S' : os.getcwd(), +} arichardson wrote: > Shouldn't this be the directory containing the test? You are right,

[PATCH] D98712: [Utils] Support lit-like substitutions in update_cc_test_checks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa80a33e8b553: [Utils] Support lit-like substitutions in update_cc_test_checks (authored by ggeorgakoudis). Repository: rG LLVM Github Monorepo CH

[PATCH] D98712: [Utils] Support lit-like substitutions in update_cc_test_checks

ggeorgakoudis updated this revision to Diff 331037. ggeorgakoudis added a comment. Update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98712/new/ https://reviews.llvm.org/D98712 Files: clang/test/utils/update_cc_test_checks/Inputs/exec-all

[PATCH] D98712: [Utils] Support lit-like substitutions in update_cc_test_checks

ggeorgakoudis updated this revision to Diff 331035. ggeorgakoudis added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98712/new/ https://reviews.llvm.org/D98

[PATCH] D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel

ggeorgakoudis added a comment. In D91556#2620928 , @jdoerfert wrote: > In D91556#2617144 , > @kiranchandramohan wrote: > >> Ping @llitchev. Would you have time to take this forward? > > I think @ggeorgakoudis is wo

[PATCH] D97107: Replace func name with regex for update test scripts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1ce846be04f8: Replace func name with regex for update test scripts (authored by ggeorgakoudis). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D97107: Replace func name with regex for update test scripts

ggeorgakoudis updated this revision to Diff 330407. ggeorgakoudis added a comment. Fix for upstreaming Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97107/new/ https://reviews.llvm.org/D97107 Files: clang/test/utils/update_cc_test_checks/Inputs/

[PATCH] D97107: Replace func name with regex for update test scripts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5eaf70afb5f8: Replace func name with regex for update test scripts (authored by ggeorgakoudis). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D97107: Replace func name with regex in update_cc_test_checks

ggeorgakoudis updated this revision to Diff 330399. ggeorgakoudis added a comment. NFC change in update_llc_test_checks for compatibility Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97107/new/ https://reviews.llvm.org/D97107 Files: clang/test/

[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

ggeorgakoudis added a comment. In D97068#2617751 , @jroelofs wrote: > In D97068#2617642 , @ggeorgakoudis > wrote: > >> Add triple to avoid spurious failures in tests > > They're not really spurious, right... Doesn'

[PATCH] D97107: Replace func name with regex in update_cc_test_checks

ggeorgakoudis added a comment. In D97107#2617897 , @thakis wrote: > This breaks check-llvm on linux and mac: > http://45.33.8.238/linux/41398/step_12.txt > http://45.33.8.238/macm1/5291/step_10.txt > http://lab.llvm.org:8011/#/builders/109 > (and on my loc

[PATCH] D97107: Replace func name with regex in update_cc_test_checks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbf58d6a1f922: Replace func name with regex in update_cc_test_checks (authored by ggeorgakoudis). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D97107: Replace func name with regex in update_cc_test_checks

ggeorgakoudis updated this revision to Diff 329747. ggeorgakoudis added a comment. Add triple in test to avoid spurious failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97107/new/ https://reviews.llvm.org/D97107 Files: clang/test/utils/upd

[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa2abe2259c2d: Run non-filechecked commands in update_cc_test_checks.py (authored by ggeorgakoudis). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

ggeorgakoudis updated this revision to Diff 329734. ggeorgakoudis added a comment. Add triple to avoid spurious failures in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97068/new/ https://reviews.llvm.org/D97068 Files: clang/test/utils/up

[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

ggeorgakoudis added a comment. @jroelofs, thank you very much for the much useful information. I will try to replicate the problem with the apple triple and fix it, if possible, or otherwise use your patch to avoid the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

ggeorgakoudis added a comment. In D97068#2611269 , @thakis wrote: > Looks like this breaks tests on mac: http://45.33.8.238/macm1/5075/step_6.txt > > Please take a look, and revert for now if it takes a while to fix. Hey @thakis, it should be an easy fix.

[PATCH] D97107: Replace func name with regex in update_cc_test_checks

ggeorgakoudis updated this revision to Diff 329008. ggeorgakoudis added a comment. Change regex to avoid failing windows test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97107/new/ https://reviews.llvm.org/D97107 Files: clang/test/utils/update

[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG60d4c73b30a0: Run non-filechecked commands in update_cc_test_checks.py (authored by ggeorgakoudis). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

ggeorgakoudis updated this revision to Diff 328887. ggeorgakoudis added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update implementation to support running non-clang runlines, add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

  1   2   >