Gerolf added a comment.
Nice! This is a straightforward extension with minor code clean-up.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97857/new/
https://reviews.llvm.org/D97857
___
cfe-commits mailin
Gerolf accepted this revision.
Gerolf added a comment.
This revision is now accepted and ready to land.
LGTM.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91147/new/
https://reviews.llvm.org/D91147
___
cfe-commits mailing list
cfe-commits@li
Gerolf added reviewers: ahatanak, qcolombet.
Gerolf added a comment.
+ Akira, Quentin for their driver / x86_64h experience for a quick double
check. Fwiw, LGTM.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55775/new/
https://reviews.llvm.org/D55775
Gerolf added reviewers: dexonsmith, ahatanak, MatzeB.
Gerolf added a comment.
It looks pretty straightforward, but I'd ask (at least) Duncan or Akira, and
Matthias to review this more carefully.
-Gerolf
Repository:
rC Clang
https://reviews.llvm.org/D40864