[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

gergap updated this revision to Diff 349269. gergap added a comment. add new test for checking pointer alignment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103245/new/ https://reviews.llvm.org/D103245 Files: clang/docs/ReleaseNotes.rst clan

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

gergap added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14921 + verifyFormat("unsigned int *a;\n" + "int*b;\n" "unsigned int Const *c;\n" curdeius wrote: > HazardyKnusperkeks wrote: > >

[PATCH] D103286: [clang-format] Add PPIndentWidth option

gergap updated this revision to Diff 348955. gergap added a comment. trigger build again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103286/new/ https://reviews.llvm.org/D103286 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/Releas

[PATCH] D103286: [clang-format] Add PPIndentWidth option

gergap added a comment. @HazardyKnusperkeks could you please land this for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103286/new/ https://reviews.llvm.org/D103286 ___ cfe-commits mailing list cfe-

[PATCH] D103286: [clang-format] Add PPIndentWidth option

gergap updated this revision to Diff 348794. gergap added a comment. changed wording as requested and updated release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103286/new/ https://reviews.llvm.org/D103286 Files: clang/docs/ClangFormatS

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

gergap added a comment. In D103245#2789423 , @HazardyKnusperkeks wrote: > Thank you very much. :) > Do you have commit access, or do you need someone to land it? If the latter > please state name and email for the commit. I started working on this just

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

gergap updated this revision to Diff 348791. gergap added a comment. update release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103245/new/ https://reviews.llvm.org/D103245 Files: clang/docs/ReleaseNotes.rst clang/lib/Format/Whitespace

[PATCH] D103286: [clang-format] Add PPIndentWidth option

gergap updated this revision to Diff 348753. gergap marked an inline comment as done. gergap added a comment. fix review findings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103286/new/ https://reviews.llvm.org/D103286 Files: clang/docs/ClangF

[PATCH] D103286: [clang-format] Add PPIndentWidth option

gergap marked 3 inline comments as done. gergap added a comment. I fixed the review findings and changed the behavior to be better backwards compatible by using PPIndentWidth=-1 by default. This value defaults to IndentWidth now. Comment at: clang/unittests/Format/FormatTest.c

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

gergap updated this revision to Diff 348736. gergap added a comment. remove `continue` statement from AlignTokenSequence as requested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103245/new/ https://reviews.llvm.org/D103245 Files: clang/lib/For

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

gergap updated this revision to Diff 348625. gergap added a comment. fix review findings - fix case of comments - rename for loop variable name - use preincrement instead of postincrement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103245/new/ h

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

gergap added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:15045 + // PAS_RIGHT EXPECT_EQ("void SomeFunction(int parameter = 0) {\n" " int const i = 1;\n" gergap wrote: > gergap wrote: > > HazardyKnusperkeks wrote: > > > I

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

gergap marked an inline comment as done. gergap added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:15045 + // PAS_RIGHT EXPECT_EQ("void SomeFunction(int parameter = 0) {\n" " int const i = 1;\n" gergap wrote: > HazardyKnu

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

gergap marked 4 inline comments as done. gergap added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:369 assert(Shift >= 0); +if (Shift == 0) + continue; HazardyKnusperkeks wrote: > This is unrelated, isn't it? > > If it is, I

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

gergap updated this revision to Diff 348463. gergap added a comment. rebased on latest main and squashed the two commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103245/new/ https://reviews.llvm.org/D103245 Files: clang/lib/Format/Whitespac

[PATCH] D103286: [clang-format] Add PPIndentWidth option

gergap updated this revision to Diff 348453. gergap added a comment. fixing test issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103286/new/ https://reviews.llvm.org/D103286 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clan

[PATCH] D103286: [clang-format] Add PPIndentWidth option

gergap created this revision. gergap added reviewers: klimek, Richard. Herald added a subscriber: krytarowski. gergap requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This allows to set a different indent width for preprocessor statements.

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

gergap updated this revision to Diff 348257. gergap added a comment. arc diff again because previous diff didn't contain all changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103245/new/ https://reviews.llvm.org/D103245 Files: clang/lib/Form

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

gergap updated this revision to Diff 348248. gergap added a comment. fixing some tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103245/new/ https://reviews.llvm.org/D103245 Files: clang/unittests/Format/FormatTest.cpp Index: clang/unittes

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

gergap created this revision. gergap added reviewers: djasper, berenm. gergap requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This re-applies the old patch D27651 , which was never landed, into the latest "