This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
jubnzv marked an inline comment as done.
Closed by commit rG3697f2683695: [docs] Fix linking issues in LibASTMatchers
tutorial (authored by jubnzv).
Herald added a proj
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc558b1fca735: [analyzer] Fix calculating offset for fields
with an empty type (authored by jubnzv).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104097/new/
jubnzv updated this revision to Diff 352361.
jubnzv added a comment.
Added two tests that check whether we still calculate padding correctly for
structs with `[[no_unique_address]]` on two consecutive fields
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104097/new/
https://reviews.llvm
jubnzv updated this revision to Diff 351423.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104097/new/
https://reviews.llvm.org/D104097
Files:
clang/lib/StaticAnalyzer/Checkers/PaddingChecker.cpp
clang/test/Analysis/padding_no_unique_address.cpp
Index: clang/test/Analysis/padding_n
jubnzv created this revision.
jubnzv added reviewers: steakhal, NoQ, vsavchenko, Szelethus, xazax.hun,
balazske.
jubnzv added a project: clang.
Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, donat.nagy,
mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware.
jubnzv req
This revision was automatically updated to reflect the committed changes.
Closed by commit rGab92a4c26f54: [clang-tidy] Fix altera-struct-pack-align
crash for struct fields with… (authored by jubnzv).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102
jubnzv created this revision.
jubnzv added reviewers: aaron.ballman, njames93.
jubnzv added a project: clang-tools-extra.
Herald added a subscriber: xazax.hun.
jubnzv requested review of this revision.
We can only use `ASTContext::getTypeInfo` for complete types.
This fixes the following bugzilla
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe07753c8814d: [clang-tidy] Fix test that requires Windows
platofrm (authored by jubnzv).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102337/new/
https://r
jubnzv abandoned this revision.
jubnzv added a comment.
Thank you, I didn't know that it is possible to set the target triple using
`--extra-arg`. I created a new revision with this fix:
https://reviews.llvm.org/D102337.
For some reasons, the `--target=unknown-windows` doesn't work for me with t
jubnzv created this revision.
jubnzv added reviewers: aaron.ballman, njames93.
jubnzv added a project: clang-tools-extra.
Herald added subscribers: kbarton, xazax.hun, nemanjai.
jubnzv requested review of this revision.
This commit fixes the `cppcoreguidelines-pro-type-vararg` test when it runs o
jubnzv updated this revision to Diff 344758.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102322/new/
https://reviews.llvm.org/D102322
Files:
clang-tools-extra/clang-tidy/ClangTidy.cpp
clang-tools-extra/clang-tidy/ClangTidy.h
clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp
jubnzv created this revision.
jubnzv added a project: clang-tools-extra.
Herald added subscribers: kbarton, xazax.hun, nemanjai.
jubnzv requested review of this revision.
The added option allows the user to specify the target for which //clang-tidy//
checks will be executed. This is necessary for
jubnzv added inline comments.
Comment at:
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-vararg-ms.cpp:7
+
+// RUN: %check_clang_tidy %s cppcoreguidelines-pro-type-vararg %t
+
dyung wrote:
> jubnzv wrote:
> > probinson wrote:
> > > probins
jubnzv added inline comments.
Comment at:
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-vararg-ms.cpp:7
+
+// RUN: %check_clang_tidy %s cppcoreguidelines-pro-type-vararg %t
+
probinson wrote:
> probinson wrote:
> > TWeaver wrote:
> > > nj
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc2e9baf2e8da: [clang-tidy] Fix
cppcoreguidelines-pro-type-vararg false positives with… (authored by jubnzv).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D10
jubnzv updated this revision to Diff 342155.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101259/new/
https://reviews.llvm.org/D101259
Files:
clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-
jubnzv updated this revision to Diff 341079.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101259/new/
https://reviews.llvm.org/D101259
Files:
clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-
jubnzv added a comment.
Thanks, I updated my patch and now CI is happy.
I also found a few additional cases that can lead to false positives on the
platforms which implements `__builtin_va_list` as `void *` or `char *`, and
added additional checks for this.
CHANGES SINCE LAST ACTION
https://
jubnzv updated this revision to Diff 340757.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101259/new/
https://reviews.llvm.org/D101259
Files:
clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-
jubnzv updated this revision to Diff 340738.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101259/new/
https://reviews.llvm.org/D101259
Files:
clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-
jubnzv updated this revision to Diff 340724.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101259/new/
https://reviews.llvm.org/D101259
Files:
clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-
jubnzv created this revision.
jubnzv added reviewers: njames93, aaron.ballman.
jubnzv added a project: clang-tools-extra.
Herald added subscribers: shchenz, kbarton, xazax.hun, nemanjai.
jubnzv requested review of this revision.
This commit fixes `cppcoreguidelines-pro-type-vararg` false positives
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9a930aa5bd2f: [clang-tidy] Avoid bugprone-macro-parentheses
warnings after goto argument (authored by jubnzv).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D
23 matches
Mail list logo