[PATCH] D141175: [test] Split out Annotations from `TestingSupport`

GMNGeoffrey accepted this revision. GMNGeoffrey added a comment. This revision is now accepted and ready to land. LGTM (+/- nits), but maybe good to get review from someone more closely associated with the TestingSupport library Comment at: utils/bazel/llvm-project-overlay/llv

[PATCH] D112353: [bazel] fixes for windows build

GMNGeoffrey added a comment. If you'd like to rebase this and see what's still outstanding, I can take another look :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112353/new/ https://reviews.llvm.org/D112353 ___

[PATCH] D112883: [bazel] Re-introduce `copts` hacks for lib/AST includes.

GMNGeoffrey added a comment. In D112883#3101685 , @GMNGeoffrey wrote: > In D112883#3101665 , @chandlerc > wrote: > >> However, I thought with Bazel having a consistent repo name was important to >> allow cross-

[PATCH] D112883: [bazel] Re-introduce `copts` hacks for lib/AST includes.

GMNGeoffrey added a comment. In D112883#3101665 , @chandlerc wrote: > In D112883#3101645 , @GMNGeoffrey > wrote: > >> :-( Did you try the separate library with `strip_include_prefix`? > > I can add a separate

[PATCH] D112883: [bazel] Re-introduce `copts` hacks for lib/AST includes.

GMNGeoffrey added inline comments. Comment at: utils/bazel/llvm-project-overlay/clang/BUILD.bazel:711 +# headers such as `CXXABI.h`. +"-I$(GENDIR)/external/llvm-project/clang/lib/AST", +"-I$(GENDIR)/external/llvm-project/clang/lib/AST/Interp",

[PATCH] D112883: [bazel] Re-introduce `copts` hacks for lib/AST includes.

GMNGeoffrey added a comment. :-( Did you try the separate library with `strip_include_prefix`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112883/new/ https://reviews.llvm.org/D112883 ___ cfe-commi

[PATCH] D112399: Get Bazel building `//clang` on Windows with clang-cl.

GMNGeoffrey accepted this revision. GMNGeoffrey added inline comments. This revision is now accepted and ready to land. Comment at: utils/bazel/llvm-project-overlay/clang/BUILD.bazel:364 +# Clang-specific define on non-Windows platforms. +"CLANG_HAVE_RLIMI

[PATCH] D112399: Get Bazel building `//clang` on Windows with clang-cl.

GMNGeoffrey added inline comments. Comment at: utils/bazel/llvm-project-overlay/clang/include/clang/Config/config.h:81 /* The LLVM product name and version */ #define BACKEND_PACKAGE_STRING "LLVM 12.0.0git" rnk wrote: > Unrelated to your change, but is this

[PATCH] D112399: Get Bazel building `//clang` on Windows with clang-cl.

GMNGeoffrey added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:1059 +#undef strcasecmp +#undef strncasecmp + chandlerc wrote: > thakis wrote: > > Why do we need this with bazel but not with other windows builds? > I don't know how this neve

[PATCH] D112353: [bazel] fixes for windows build

GMNGeoffrey added a subscriber: chandlerc. GMNGeoffrey added a comment. Thanks for upstreaming your fixes :-) It looks like this has some overlap with https://reviews.llvm.org/D112399 and https://reviews.llvm.org/D111930. Let's let those land and then see what's still necessary here =

[PATCH] D112399: Get Bazel building `//clang` on Windows with clang-cl.

GMNGeoffrey accepted this revision. GMNGeoffrey added inline comments. This revision is now accepted and ready to land. Comment at: utils/bazel/llvm-project-overlay/clang/include/clang/Config/config.h:78 /* Define if we have sys/resource.h (rlimits) */ -#define CLANG_HAVE_RLIMI

[PATCH] D109181: Reland "Try to unbreak Win build differently after 973519826edb76""

GMNGeoffrey added a comment. I can't repro the failure locally and it appears to also be broken at head Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109181/new/ https://reviews.llvm.org/D109181 ___ cfe-

[PATCH] D109181: Reland "Try to unbreak Win build differently after 973519826edb76""

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcc2d4dc3e0cc: Reland "Try to unbreak Win build differently after 973519826edb76"" (authored by thakis, committed by GMNGeoffrey). Repository: rG

[PATCH] D109181: Reland "Try to unbreak Win build differently after 973519826edb76""

GMNGeoffrey added a comment. Hmmm so pre-merge checks on Linux are failing https://buildkite.com/llvm-project/premerge-checks/builds/54955#8fea4a06-e971-48ad-a6d7-31173315d83d FAIL: libomp :: lock/omp_init_lock.c (84929 of 87948) TEST 'libomp :: lock/omp_init_lock.c' FAI

[PATCH] D109167: Try to unbreak Win build differently after 973519826edb76

GMNGeoffrey added subscribers: goncharov, mehdi_amini. GMNGeoffrey added a comment. In D109167#2980604 , @GMNGeoffrey wrote: >> I had fixed this in >> https://github.com/llvm/llvm-project/commit/9d227543890e721b95303430ee1427ce5aa7292f >> . Precommit b

[PATCH] D109167: Try to unbreak Win build differently after 973519826edb76

GMNGeoffrey added a comment. > I had fixed this in > https://github.com/llvm/llvm-project/commit/9d227543890e721b95303430ee1427ce5aa7292f > . Precommit bot on this change was green though as far as I can tell. Harbormaster comments with a green check mark that build has completed, but if you l

[PATCH] D109181: Reland "Try to unbreak Win build differently after 973519826edb76""

GMNGeoffrey created this revision. Herald added subscribers: dexonsmith, mgrang. GMNGeoffrey requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Build should be fixed by https://github.com/llvm/llvm-project/commit/9d22754389

[PATCH] D109167: Try to unbreak Win build differently after 973519826edb76

GMNGeoffrey added a comment. I'm seeing a build failure coming out of this: > llvm-project/lld/wasm/Writer.cpp:521:16: error: non-const lvalue reference to > type 'llvm::StringRef' cannot bind to a temporary of type 'llvm::StringRef' > > for (auto &feature : used.keys()) { Looks like pre-merg