[PATCH] D88949: DeferredDiagnosticsEmitter crashes

2020-10-08 Thread Geoff Levner via Phabricator via cfe-commits
glevner added a comment. Good enough for us... Thanks, @hans and @yaxunl! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88949/new/ https://reviews.llvm.org/D88949 ___ cfe-commits mailing list cfe-commits

[PATCH] D88949: DeferredDiagnosticsEmitter crashes

2020-10-08 Thread Geoff Levner via Phabricator via cfe-commits
glevner added a comment. Great. I don't have commit access though. If I did, I would love to commit it to the release branch, which is what we use... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88949/new/ https://reviews.llvm.org/D88949 ___

[PATCH] D88949: DeferredDiagnosticsEmitter crashes

2020-10-07 Thread Geoff Levner via Phabricator via cfe-commits
glevner added a comment. I'm sorry, but I don't know how to reproduce the problem in isolation. We are JIT-compiling fairly complex C++ code, and the crash //sometimes// occurs when, for example, an included header file is not found... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D88949: DeferredDiagnosticsEmitter crashes

2020-10-07 Thread Geoff Levner via Phabricator via cfe-commits
glevner added a comment. See https://bugs.llvm.org/show_bug.cgi?id=47742 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88949/new/ https://reviews.llvm.org/D88949 ___ cfe-commits mailing list cfe-commits@

[PATCH] D88949: DeferredDiagnosticsEmitter crashes

2020-10-07 Thread Geoff Levner via Phabricator via cfe-commits
glevner created this revision. glevner added reviewers: lhames, yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. glevner requested review of this revision. Patch VisitCXXDeleteExpr() in clang::UsedDeclVisitor to avoid it crashing when the expression's destroyed type