rogeeff marked 3 inline comments as done.
rogeeff added inline comments.
Comment at:
clang-tools-extra/clang-tidy/abseil/NoInternalDependenciesCheck.cpp:43-44
+
+ if (!LocAtFault.isValid())
+return;
+
aaron.ballman wrote:
> rogeeff wrote:
> > lebedev.ri wro
rogeeff marked 2 inline comments as done.
rogeeff added inline comments.
Comment at:
clang-tools-extra/clang-tidy/abseil/NoInternalDependenciesCheck.cpp:43-44
+
+ if (!LocAtFault.isValid())
+return;
+
lebedev.ri wrote:
> Is there test coverage for this? Whe
rogeeff added a comment.
It is my first time submitting clang-tidy change. So I'm not sure of the
procedure exactly. Do we wait for something from me?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72484/new/
https://reviews.llvm.org/D72484
___
rogeeff updated this revision to Diff 237225.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72484/new/
https://reviews.llvm.org/D72484
Files:
clang-tools-extra/clang-tidy/abseil/NoInternalDependenciesCheck.cpp
clang-tools-extra/test/clang-tidy/checkers/Inputs/absl/strings/internal-fi
rogeeff created this revision.
Herald added a subscriber: mgehre.
Herald added a project: clang.
rogeeff added a reviewer: EricWF.
This change makes following modifications:
- If reference originated from macro expansion, we report location inside of
the macro instead of location where macro is
