https://github.com/quic-garvgupt edited
https://github.com/llvm/llvm-project/pull/147589
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/quic-garvgupt updated
https://github.com/llvm/llvm-project/pull/147589
>From c6420bc64c2745c49400408ba93afa34eea194e3 Mon Sep 17 00:00:00 2001
From: Garvit Gupta
Date: Tue, 8 Jul 2025 12:44:44 -0700
Subject: [PATCH] Propogate linker flags when `-static-pie` is enabled in
Bar
https://github.com/quic-garvgupt created
https://github.com/llvm/llvm-project/pull/147589
None
>From 6f96fc844751a95ee18b69ddb850ddd2fe76a89c Mon Sep 17 00:00:00 2001
From: Garvit Gupta
Date: Tue, 8 Jul 2025 07:21:37 -0700
Subject: [PATCH 1/2] Propogate appropriate linker flags for `-static-pi
https://github.com/quic-garvgupt updated
https://github.com/llvm/llvm-project/pull/147589
>From a1f3797d0acb93e66959c5163aeb49213d2d32a1 Mon Sep 17 00:00:00 2001
From: Garvit Gupta
Date: Tue, 8 Jul 2025 12:44:44 -0700
Subject: [PATCH] Propogate linker flags when `-static-pie` is enabled in
Bar
https://github.com/quic-garvgupt updated
https://github.com/llvm/llvm-project/pull/147589
>From 6f96fc844751a95ee18b69ddb850ddd2fe76a89c Mon Sep 17 00:00:00 2001
From: Garvit Gupta
Date: Tue, 8 Jul 2025 07:21:37 -0700
Subject: [PATCH 1/2] Propogate appropriate linker flags for `-static-pie` in
https://github.com/quic-garvgupt closed
https://github.com/llvm/llvm-project/pull/146849
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -206,6 +206,15 @@ std::string BareMetal::computeSysRoot() const {
return computeClangRuntimesSysRoot(D, /*IncludeTriple*/ true);
}
+std::string BareMetal::getCompilerRTPath() const {
+ if (IsGCCInstallationValid || detectGCCToolchainAdjacent(getDriver())) {
+SmallStr
https://github.com/quic-garvgupt updated
https://github.com/llvm/llvm-project/pull/146849
>From 3d0220ecce368a481981c414f789d9dbbfc49c81 Mon Sep 17 00:00:00 2001
From: Garvit Gupta
Date: Thu, 3 Jul 2025 02:56:01 -0700
Subject: [PATCH] [Driver][RISCV] Fix and print appropriate compiler-rt path
https://github.com/quic-garvgupt edited
https://github.com/llvm/llvm-project/pull/146849
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/quic-garvgupt edited
https://github.com/llvm/llvm-project/pull/146849
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/quic-garvgupt edited
https://github.com/llvm/llvm-project/pull/146849
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/quic-garvgupt created
https://github.com/llvm/llvm-project/pull/146849
Baremetal and RISCVToolchain used different paths for clangrt builtins
relative to resource-dir before RISCVToolChain got removed in commit f8cb798
This created a discrepancy in behavior for riscv target wh
@@ -59,3 +118,39 @@
// CXX-AARCH64-BAREMETAL-NOSYSROOT-LIBCXX: "-internal-isystem"
"{{.*}}/Inputs/basic_aarch64_gcc_tree/lib/gcc/aarch64-none-elf/8.2.1/../../../../aarch64-none-elf/include/c++/v1"
// CXX-AARCH64-BAREMETAL-NOSYSROOT-LIBCXX: "-internal-isystem"
"{{.*}}/Inputs/
quic-garvgupt wrote:
> > Moreover, this patch makes gnuld the default linker for baremetal
> > toolchain object. User need to pass -fuse-ld=lld explicitly to driver to
> > select
> > lld
>
> This seems like an unrelated change, it was not mentioned in the RFC, and it
> breaks things: baremetal
https://github.com/quic-garvgupt closed
https://github.com/llvm/llvm-project/pull/121831
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -336,6 +336,26 @@ BareMetal::OrderedMultilibs
BareMetal::getOrderedMultilibs() const {
return llvm::reverse(Default);
}
+ToolChain::CXXStdlibType BareMetal::GetDefaultCXXStdlibType() const {
+ if (getTriple().isRISCV() && GCCInstallation.isValid())
+return ToolChain
@@ -336,6 +336,26 @@ BareMetal::OrderedMultilibs
BareMetal::getOrderedMultilibs() const {
return llvm::reverse(Default);
}
+ToolChain::CXXStdlibType BareMetal::GetDefaultCXXStdlibType() const {
+ if (getTriple().isRISCV() && GCCInstallation.isValid())
+return ToolChain
https://github.com/quic-garvgupt updated
https://github.com/llvm/llvm-project/pull/121831
>From b9e1db372117d9d418d0812a09874526e88efad4 Mon Sep 17 00:00:00 2001
From: Garvit Gupta
Date: Mon, 6 Jan 2025 10:05:08 -0800
Subject: [PATCH] [RISCV] Integrate RISCV target in baremetal toolchain object
https://github.com/quic-garvgupt edited
https://github.com/llvm/llvm-project/pull/121831
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/quic-garvgupt closed
https://github.com/llvm/llvm-project/pull/134442
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/quic-garvgupt updated
https://github.com/llvm/llvm-project/pull/134442
>From 9d48ea76ef90ac9e76ade4af77667e44652e3408 Mon Sep 17 00:00:00 2001
From: Garvit Gupta
Date: Fri, 4 Apr 2025 12:51:19 -0700
Subject: [PATCH] [RISCV][Driver] Add support for `-m` flag to linker job of
https://github.com/quic-garvgupt edited
https://github.com/llvm/llvm-project/pull/134442
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/quic-garvgupt closed
https://github.com/llvm/llvm-project/pull/132808
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/quic-garvgupt updated
https://github.com/llvm/llvm-project/pull/132808
>From e302490b6e6350951e75bd68578606aa7909692e Mon Sep 17 00:00:00 2001
From: Garvit Gupta
Date: Mon, 24 Mar 2025 07:04:59 -0700
Subject: [PATCH] [Driver] Forward sysroot from Driver to linker in BareMetal
https://github.com/quic-garvgupt closed
https://github.com/llvm/llvm-project/pull/146304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/quic-garvgupt created
https://github.com/llvm/llvm-project/pull/146304
Add support for `-u` option to force defined symbols. This option is supported
by both lld and gnuld.
This is done as a part of the effort to merge RISCVToolchain object into
BareMetal toolchain object.
https://github.com/quic-garvgupt closed
https://github.com/llvm/llvm-project/pull/146291
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/quic-garvgupt created
https://github.com/llvm/llvm-project/pull/146291
The linker job in BareMetal toolchain object will be used by GNU ld and lld
both.
However, gnuld process the arguments in the order in which they appear on
command
line, whereas there is no such restricti
https://github.com/quic-garvgupt closed
https://github.com/llvm/llvm-project/pull/144649
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/quic-garvgupt updated
https://github.com/llvm/llvm-project/pull/144649
>From 14a2bb5dead7fa0e3d442e04ba73ad5f98d2e90e Mon Sep 17 00:00:00 2001
From: Garvit Gupta
Date: Tue, 17 Jun 2025 22:49:55 +0530
Subject: [PATCH] [Driver] Add support for crtbegin.o, crtend.o and libgloss
https://github.com/quic-garvgupt closed
https://github.com/llvm/llvm-project/pull/118809
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/quic-garvgupt closed
https://github.com/llvm/llvm-project/pull/145390
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
quic-garvgupt wrote:
> > Triggering a force build will help verify that the fix is effective and
> > does not cause any further buildbot failures. Please ensure that PR #145390
> > and PR #144649 are applied in sequence to avoid any merge conflicts
>
> I couldn't apply the patch for 144649 aft
https://github.com/quic-garvgupt updated
https://github.com/llvm/llvm-project/pull/144649
>From 296df79cb9e9696daa926267c8a9a853930fdc46 Mon Sep 17 00:00:00 2001
From: Garvit Gupta
Date: Tue, 17 Jun 2025 21:43:17 +0530
Subject: [PATCH 1/2] Reland [Driver] Add support for GCC installation
detec
https://github.com/quic-garvgupt updated
https://github.com/llvm/llvm-project/pull/144649
>From 296df79cb9e9696daa926267c8a9a853930fdc46 Mon Sep 17 00:00:00 2001
From: Garvit Gupta
Date: Tue, 17 Jun 2025 21:43:17 +0530
Subject: [PATCH 1/2] Reland [Driver] Add support for GCC installation
detec
https://github.com/quic-garvgupt updated
https://github.com/llvm/llvm-project/pull/144649
>From e22e920750fa4c5ca98172c2f390640bc42d16ea Mon Sep 17 00:00:00 2001
From: Garvit Gupta
Date: Tue, 17 Jun 2025 21:43:17 +0530
Subject: [PATCH 1/2] Reland [Driver] Add support for GCC installation
detec
https://github.com/quic-garvgupt updated
https://github.com/llvm/llvm-project/pull/144649
>From e22e920750fa4c5ca98172c2f390640bc42d16ea Mon Sep 17 00:00:00 2001
From: Garvit Gupta
Date: Tue, 17 Jun 2025 21:43:17 +0530
Subject: [PATCH 1/2] Reland [Driver] Add support for GCC installation
detec
https://github.com/quic-garvgupt updated
https://github.com/llvm/llvm-project/pull/144649
>From 22fca1c6a0a9fd26509720800a0244e824effc41 Mon Sep 17 00:00:00 2001
From: Garvit Gupta
Date: Tue, 17 Jun 2025 22:49:55 +0530
Subject: [PATCH] [Driver] Add support for crtbegin.o, crtend.o and libgloss
https://github.com/quic-garvgupt updated
https://github.com/llvm/llvm-project/pull/144649
>From 36f8e160dfad059fdada0a00b5cdc20dde0076c0 Mon Sep 17 00:00:00 2001
From: Garvit Gupta
Date: Tue, 17 Jun 2025 22:49:55 +0530
Subject: [PATCH] [Driver] Add support for crtbegin.o, crtend.o and libgloss
https://github.com/quic-garvgupt updated
https://github.com/llvm/llvm-project/pull/145390
>From 296df79cb9e9696daa926267c8a9a853930fdc46 Mon Sep 17 00:00:00 2001
From: Garvit Gupta
Date: Tue, 17 Jun 2025 21:43:17 +0530
Subject: [PATCH] Reland [Driver] Add support for GCC installation detection
https://github.com/quic-garvgupt updated
https://github.com/llvm/llvm-project/pull/145390
>From 20b2dca466710dc44afacd91ea691f3b02137736 Mon Sep 17 00:00:00 2001
From: Garvit Gupta
Date: Tue, 17 Jun 2025 21:43:17 +0530
Subject: [PATCH] Reland [Driver] Add support for GCC installation detection
quic-garvgupt wrote:
Hi @mysterymath, could you please initiate a build for this PR (#145390) along
with PR #144649 on the Fuchsia buildbot? These two PRs contain the necessary
fixes to resolve the failure previously encountered on the [fuchsia
buildbots](https://luci-milo.appspot.com/ui/p/fuc
https://github.com/quic-garvgupt created
https://github.com/llvm/llvm-project/pull/145390
This patch introduces enhancements to the Baremetal toolchain to support GCC
toolchain detection.
- If the --gcc-install-dir or --gcc-toolchain options are provided and point to
valid paths, the sysroot i
quic-garvgupt wrote:
Fix for tests failing on https://lab.llvm.org/buildbot/#/builders/11 -
https://github.com/llvm/llvm-project/pull/144655
https://github.com/llvm/llvm-project/pull/144640
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https
https://github.com/quic-garvgupt created
https://github.com/llvm/llvm-project/pull/144655
Fuchsia sets CLANG_DEFAULT_UNWINDLIB to libunwind. As a result, when rtlib is
set to libgcc and unwindlib is not explicitly specified, tests using Fuchsia as
the default platform will fail. To address thi
https://github.com/quic-garvgupt created
https://github.com/llvm/llvm-project/pull/144649
This patch conditionalise the addition of crt{begin,end}.o object files
along with addition of -lgloss lib based on whether libc selected is newlib or
llvm libc. Since there is no way a user can specify whi
https://github.com/quic-garvgupt closed
https://github.com/llvm/llvm-project/pull/144640
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/quic-garvgupt edited
https://github.com/llvm/llvm-project/pull/144640
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
quic-garvgupt wrote:
> > Do the fuchsia builders actually produce output on a failure? We seem to
> > just get exit code 1, but no indication of what filecheck had problems with.
>
> They do; here's a link! Let me know if you have an problems with the Web UI;
> I can paste things here if so.
https://github.com/quic-garvgupt created
https://github.com/llvm/llvm-project/pull/144640
This patch introduces enhancements to the Baremetal toolchain to support
GCC toolchain detection.
- If the --gcc-install-dir or --gcc-toolchain options are provided and
point to valid paths, the sysroot is
quic-garvgupt wrote:
> `ToolChain::UnwindLibType ToolChain::GetUnwindLibType( const ArgList &Args)
> const { if (unwindLibType) return *unwindLibType;
>
> const Arg *A = Args.getLastArg(options::OPT_unwindlib_EQ); StringRef LibName
> = A ? A->getValue() : CLANG_DEFAULT_UNWINDLIB;`
>
> If --un
quic-garvgupt wrote:
`ToolChain::UnwindLibType ToolChain::GetUnwindLibType(
const ArgList &Args) const {
if (unwindLibType)
return *unwindLibType;
const Arg *A = Args.getLastArg(options::OPT_unwindlib_EQ);
StringRef LibName = A ? A->getValue() : CLANG_DEFAULT_UNWINDLIB;`
I
quic-garvgupt wrote:
`ToolChain::UnwindLibType ToolChain::GetUnwindLibType(
const ArgList &Args) const {
if (unwindLibType)
return *unwindLibType;
const Arg *A = Args.getLastArg(options::OPT_unwindlib_EQ);
StringRef LibName = A ? A->getValue() : CLANG_DEFAULT_UNWINDLIB;`
If the
https://github.com/quic-garvgupt updated
https://github.com/llvm/llvm-project/pull/132808
>From f4a5757a8abf6ff7ba3e064533f3993a0ed0198e Mon Sep 17 00:00:00 2001
From: Garvit Gupta
Date: Mon, 24 Mar 2025 07:04:59 -0700
Subject: [PATCH] [Driver] Forward sysroot from Driver to linker in BareMetal
https://github.com/quic-garvgupt edited
https://github.com/llvm/llvm-project/pull/132808
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/quic-garvgupt closed
https://github.com/llvm/llvm-project/pull/132807
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/quic-garvgupt updated
https://github.com/llvm/llvm-project/pull/132807
>From 7f26ac995e18f71ec8bccdb5b39be95bf629da19 Mon Sep 17 00:00:00 2001
From: Garvit Gupta
Date: Mon, 24 Mar 2025 06:49:09 -0700
Subject: [PATCH] [Driver] Add option to force udnefined symbols during linki
https://github.com/quic-garvgupt edited
https://github.com/llvm/llvm-project/pull/132807
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/quic-garvgupt closed
https://github.com/llvm/llvm-project/pull/132806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/quic-garvgupt updated
https://github.com/llvm/llvm-project/pull/132806
>From fa8aad1e9df9b21696fea33de4678a809a13367c Mon Sep 17 00:00:00 2001
From: Garvit Gupta
Date: Mon, 24 Mar 2025 06:17:42 -0700
Subject: [PATCH] [Driver] Fix link order of BareMetal toolchain object
The
https://github.com/quic-garvgupt edited
https://github.com/llvm/llvm-project/pull/132806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/quic-garvgupt closed
https://github.com/llvm/llvm-project/pull/121830
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/quic-garvgupt updated
https://github.com/llvm/llvm-project/pull/121830
>From c490d1f4f1d1c3a65ad722d46b87fe49ade11c21 Mon Sep 17 00:00:00 2001
From: Garvit Gupta
Date: Mon, 24 Mar 2025 04:58:57 -0700
Subject: [PATCH] [Driver] Add support for crtbegin.o, crtend.o and libgloss
https://github.com/quic-garvgupt edited
https://github.com/llvm/llvm-project/pull/121830
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/quic-garvgupt closed
https://github.com/llvm/llvm-project/pull/121829
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
quic-garvgupt wrote:
Gentle Ping!
https://github.com/llvm/llvm-project/pull/143692
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -110,56 +145,113 @@ static std::string computeBaseSysRoot(const Driver &D,
bool IncludeTriple) {
return std::string(SysRootDir);
}
-BareMetal::BareMetal(const Driver &D, const llvm::Triple &Triple,
- const ArgList &Args)
-: ToolChain(D, Triple, Ar
https://github.com/quic-garvgupt updated
https://github.com/llvm/llvm-project/pull/121829
>From f19e2e0abc5e6ad2144772cb654e7b86d28f0efd Mon Sep 17 00:00:00 2001
From: Garvit Gupta
Date: Fri, 13 Dec 2024 05:31:56 -0800
Subject: [PATCH] [Driver] Teach Barmetal toolchain about GCC installation
T
https://github.com/quic-garvgupt updated
https://github.com/llvm/llvm-project/pull/143692
>From e4902f765b0ef58e015195f2b4974d1f44c6b0c1 Mon Sep 17 00:00:00 2001
From: Garvit Gupta
Date: Mon, 26 May 2025 10:45:37 -0700
Subject: [PATCH] Pass TargetMachine from from Clang to `BitcodeWriter`and
`
https://github.com/quic-garvgupt edited
https://github.com/llvm/llvm-project/pull/143692
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
quic-garvgupt wrote:
@smithp35 , could you pls parallely also review PR -
https://github.com/llvm/llvm-project/pull/121831? I added you as reviewer there
as well in the beginning and will appreciate your comments/feedback. Thanks!
https://github.com/llvm/llvm-project/pull/121829
__
https://github.com/quic-garvgupt edited
https://github.com/llvm/llvm-project/pull/121829
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/quic-garvgupt edited
https://github.com/llvm/llvm-project/pull/121829
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
quic-garvgupt wrote:
Hi @petrhosek, while petrsmith is reviewing this PR, if you don’t have any
further suggestions, comments, or feedback, could you please provide an LGTM?
That would help us proceed with merging the PR promptly once petr approves it.
Thanks so much!
https://github.com/llvm/
https://github.com/quic-garvgupt updated
https://github.com/llvm/llvm-project/pull/121829
>From c4d61f3eafe108d705a67a9b8b7ca640119afe78 Mon Sep 17 00:00:00 2001
From: Garvit Gupta
Date: Fri, 13 Dec 2024 05:31:56 -0800
Subject: [PATCH] [Driver] Teach Barmetal toolchain about GCC installation
T
@@ -110,56 +144,99 @@ static std::string computeBaseSysRoot(const Driver &D,
bool IncludeTriple) {
return std::string(SysRootDir);
}
-BareMetal::BareMetal(const Driver &D, const llvm::Triple &Triple,
- const ArgList &Args)
-: ToolChain(D, Triple, Arg
@@ -110,56 +144,99 @@ static std::string computeBaseSysRoot(const Driver &D,
bool IncludeTriple) {
return std::string(SysRootDir);
}
-BareMetal::BareMetal(const Driver &D, const llvm::Triple &Triple,
- const ArgList &Args)
-: ToolChain(D, Triple, Arg
quic-garvgupt wrote:
> I've done another review pass. Mostly some small stylistic comments.
>
> I'm finding it difficult to follow the code with the various different
> code-paths with similar names. I've made some suggestions on renaming. We may
> also be able to add some more comments to mak
@@ -110,56 +144,99 @@ static std::string computeBaseSysRoot(const Driver &D,
bool IncludeTriple) {
return std::string(SysRootDir);
}
-BareMetal::BareMetal(const Driver &D, const llvm::Triple &Triple,
- const ArgList &Args)
-: ToolChain(D, Triple, Arg
@@ -110,56 +144,99 @@ static std::string computeBaseSysRoot(const Driver &D,
bool IncludeTriple) {
return std::string(SysRootDir);
}
-BareMetal::BareMetal(const Driver &D, const llvm::Triple &Triple,
- const ArgList &Args)
-: ToolChain(D, Triple, Arg
@@ -110,56 +144,99 @@ static std::string computeBaseSysRoot(const Driver &D,
bool IncludeTriple) {
return std::string(SysRootDir);
}
-BareMetal::BareMetal(const Driver &D, const llvm::Triple &Triple,
- const ArgList &Args)
-: ToolChain(D, Triple, Arg
@@ -110,56 +144,99 @@ static std::string computeBaseSysRoot(const Driver &D,
bool IncludeTriple) {
return std::string(SysRootDir);
}
-BareMetal::BareMetal(const Driver &D, const llvm::Triple &Triple,
- const ArgList &Args)
-: ToolChain(D, Triple, Arg
@@ -110,20 +110,81 @@ static std::string computeBaseSysRoot(const Driver &D,
bool IncludeTriple) {
return std::string(SysRootDir);
}
+static bool hasGCCToolChainAlongSideClang(const Driver &D) {
+ SmallString<128> GCCDir;
+ llvm::sys::path::append(GCCDir, D.Dir, "..", D.g
https://github.com/quic-garvgupt updated
https://github.com/llvm/llvm-project/pull/121829
>From 0ffc48d7367a37a9a02333456a9dbfc20ab9e71f Mon Sep 17 00:00:00 2001
From: Garvit Gupta
Date: Fri, 13 Dec 2024 05:31:56 -0800
Subject: [PATCH] [Driver] Teach Barmetal toolchain about GCC installation
T
quic-garvgupt wrote:
Hi @smithp35, can you pls review the latest changes and approve this PR if
everything looks fine?
https://github.com/llvm/llvm-project/pull/121829
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-
https://github.com/quic-garvgupt updated
https://github.com/llvm/llvm-project/pull/121829
>From 63eaf99ffe04d8c66bf11ec3bad6b04b83de3c96 Mon Sep 17 00:00:00 2001
From: Garvit Gupta
Date: Fri, 13 Dec 2024 05:31:56 -0800
Subject: [PATCH] [Driver] Teach Barmetal toolchain about GCC installation
T
@@ -110,20 +110,81 @@ static std::string computeBaseSysRoot(const Driver &D,
bool IncludeTriple) {
return std::string(SysRootDir);
}
+static bool hasGCCToolChainAlongSideClang(const Driver &D) {
+ SmallString<128> GCCDir;
+ llvm::sys::path::append(GCCDir, D.Dir, "..", D.g
https://github.com/quic-garvgupt updated
https://github.com/llvm/llvm-project/pull/121829
>From 8d6d2e0f1eaa0b81613a786dbe003ddf7d0a2983 Mon Sep 17 00:00:00 2001
From: Garvit Gupta
Date: Fri, 13 Dec 2024 05:31:56 -0800
Subject: [PATCH] [Driver] Teach Barmetal toolchain about GCC installation
T
@@ -110,20 +110,81 @@ static std::string computeBaseSysRoot(const Driver &D,
bool IncludeTriple) {
return std::string(SysRootDir);
}
+static bool hasGCCToolChainAlongSideClang(const Driver &D) {
+ SmallString<128> GCCDir;
+ llvm::sys::path::append(GCCDir, D.Dir, "..", D.g
@@ -110,20 +110,81 @@ static std::string computeBaseSysRoot(const Driver &D,
bool IncludeTriple) {
return std::string(SysRootDir);
}
+static bool hasGCCToolChainAlongSideClang(const Driver &D) {
+ SmallString<128> GCCDir;
+ llvm::sys::path::append(GCCDir, D.Dir, "..", D.g
quic-garvgupt wrote:
> I'm looking at this patch in isolation, so its possible that the comments
> here are addressed elasewhere.
>
> It looks like useful functionality to add to the bare metal driver.
>
> It also looks like there is some scope for some documentation, for users and
> for tool
https://github.com/quic-garvgupt updated
https://github.com/llvm/llvm-project/pull/121829
>From 1d0db96afab52903a267d600cab02c24900101af Mon Sep 17 00:00:00 2001
From: Garvit Gupta
Date: Fri, 13 Dec 2024 05:31:56 -0800
Subject: [PATCH] [Driver] Teach Barmetal toolchain about GCC installation
T
https://github.com/quic-garvgupt edited
https://github.com/llvm/llvm-project/pull/121829
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
quic-garvgupt wrote:
Hi @petrhosek, I've addressed all your comments. Please review the changes and
approve the PR if everything looks good.
https://github.com/llvm/llvm-project/pull/121829
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https
@@ -79,7 +87,6 @@ class LLVM_LIBRARY_VISIBILITY BareMetal : public ToolChain {
OrderedMultilibs getOrderedMultilibs() const;
std::string SysRoot;
quic-garvgupt wrote:
Removing this private variable was making the code messy because there have
been update
@@ -110,20 +110,76 @@ static std::string computeBaseSysRoot(const Driver &D,
bool IncludeTriple) {
return std::string(SysRootDir);
}
+std::string BareMetal::computeSysRoot() const {
+ if (!SysRoot.empty())
+return SysRoot;
+
+ std::string SysRoot = getDriver().SysRoot
https://github.com/quic-garvgupt edited
https://github.com/llvm/llvm-project/pull/121829
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/quic-garvgupt updated
https://github.com/llvm/llvm-project/pull/121829
>From e07a4cd4e0ff77f74b66695923bc998904c14746 Mon Sep 17 00:00:00 2001
From: Garvit Gupta
Date: Fri, 13 Dec 2024 05:31:56 -0800
Subject: [PATCH] [Driver] Teach Barmetal toolchain about GCC installation
T
quic-garvgupt wrote:
Hi @petrhosek, I've addressed all your comments. Please review the changes and
approve the PR if everything looks good.
https://github.com/llvm/llvm-project/pull/121829
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https
https://github.com/quic-garvgupt updated
https://github.com/llvm/llvm-project/pull/121829
>From 9bb78235d2ba008dc49dc4746edbd9978a92396b Mon Sep 17 00:00:00 2001
From: Garvit Gupta
Date: Fri, 13 Dec 2024 05:31:56 -0800
Subject: [PATCH] [RISCV] Teach Barmetal toolchain about GCC installation(1/3
1 - 100 of 142 matches
Mail list logo
