[clang] [NFC][Clang] Don't check hardcode op num (PR #135375)

https://github.com/cmc-rep approved this pull request. https://github.com/llvm/llvm-project/pull/135375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] modify named barrier builtins and intrinsics (PR #114550)

https://github.com/cmc-rep closed https://github.com/llvm/llvm-project/pull/114550 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] modify named barrier builtins and intrinsics (PR #114550)

cmc-rep wrote: Also, I added the piece in AMDGPULowerModuleLDS during internal review because other reviewers want to see the functional completeness. https://github.com/llvm/llvm-project/pull/114550 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] [llvm] [AMDGPU] modify named barrier builtins and intrinsics (PR #114550)

@@ -920,6 +920,124 @@ class AMDGPULowerModuleLDS { return KernelToCreatedDynamicLDS; } + static GlobalVariable *uniquifyGVPerKernel(Module &M, GlobalVariable *GV, cmc-rep wrote: This goes together with the change in AMDGPUMachineFunction.cpp https://g

[clang] [llvm] [AMDGPU] modify named barrier builtins and intrinsics (PR #114550)

@@ -920,6 +920,124 @@ class AMDGPULowerModuleLDS { return KernelToCreatedDynamicLDS; } + static GlobalVariable *uniquifyGVPerKernel(Module &M, GlobalVariable *GV, cmc-rep wrote: This is where the local pointer address is assigned for a named barrier be

[clang] [llvm] [AMDGPU] modify named barrier builtins and intrinsics (PR #114550)

@@ -920,6 +920,124 @@ class AMDGPULowerModuleLDS { return KernelToCreatedDynamicLDS; } + static GlobalVariable *uniquifyGVPerKernel(Module &M, GlobalVariable *GV, cmc-rep wrote: I will add you to the internal review link. So you can see the review hist

[clang] [llvm] [AMDGPU] modify named barrier builtins and intrinsics (PR #114550)

https://github.com/cmc-rep edited https://github.com/llvm/llvm-project/pull/114550 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CLANG] bump NUM_PREDEF_TYPE_IDS (PR #113728)

cmc-rep wrote: Duplicate https://github.com/llvm/llvm-project/pull/113728 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Add a type for the named barrier (PR #113614)

cmc-rep wrote: fix to the test no-external-type-id.cppm: https://github.com/llvm/llvm-project/pull/113738 https://github.com/llvm/llvm-project/pull/113614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[clang] [clang] update the number in no-external-type-id.cppm (PR #113738)

https://github.com/cmc-rep closed https://github.com/llvm/llvm-project/pull/113738 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] update the number in no-external-type-id.cppm (PR #113738)

https://github.com/cmc-rep edited https://github.com/llvm/llvm-project/pull/113738 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] update the number in no-external-type-id.cppm (PR #113738)

https://github.com/cmc-rep updated https://github.com/llvm/llvm-project/pull/113738 >From 3315b2857de4d16a8ea1bfec5437296719fc4845 Mon Sep 17 00:00:00 2001 From: gangc Date: Fri, 25 Oct 2024 13:54:12 -0700 Subject: [PATCH] [clang] update the number in no-external-type-id.cppm --- clang/test/M

[clang] [clang] update the number in no-external-type-id.cppm (PR #113738)

https://github.com/cmc-rep created https://github.com/llvm/llvm-project/pull/113738 None >From 3315b2857de4d16a8ea1bfec5437296719fc4845 Mon Sep 17 00:00:00 2001 From: gangc Date: Fri, 25 Oct 2024 13:54:12 -0700 Subject: [PATCH] [clang] update the number in no-external-type-id.cppm --- clang/

[clang] [llvm] [AMDGPU] Add a type for the named barrier (PR #113614)

cmc-rep wrote: Looks like I also need to fix the number in that test https://github.com/llvm/llvm-project/pull/113614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CLANG] bump NUM_PREDEF_TYPE_IDS (PR #113728)

https://github.com/cmc-rep closed https://github.com/llvm/llvm-project/pull/113728 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CLANG] bump NUM_PREDEF_TYPE_IDS (PR #113728)

https://github.com/cmc-rep created https://github.com/llvm/llvm-project/pull/113728 Fix assertion problem >From 1a67accc27c4bf69e91548cf552cbd69566cb42f Mon Sep 17 00:00:00 2001 From: gangc Date: Fri, 25 Oct 2024 11:53:34 -0700 Subject: [PATCH] [CLANG] bump NUM_PREDEF_TYPE_IDS Fix assertion p

[clang] [llvm] [AMDGPU] Add a type for the named barrier (PR #113614)

https://github.com/cmc-rep closed https://github.com/llvm/llvm-project/pull/113614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Add a type for the named barrier (PR #113614)

https://github.com/cmc-rep updated https://github.com/llvm/llvm-project/pull/113614 >From 166a4aec8a8ee813be0ee3045563cd45efd944c0 Mon Sep 17 00:00:00 2001 From: gangc Date: Thu, 24 Oct 2024 11:18:22 -0700 Subject: [PATCH 1/5] [AMDGPU] Add a type for the named barrier --- clang/include/clang/

[clang] [llvm] [AMDGPU] Add a type for the named barrier (PR #113614)

https://github.com/cmc-rep updated https://github.com/llvm/llvm-project/pull/113614 >From 166a4aec8a8ee813be0ee3045563cd45efd944c0 Mon Sep 17 00:00:00 2001 From: gangc Date: Thu, 24 Oct 2024 11:18:22 -0700 Subject: [PATCH 1/4] [AMDGPU] Add a type for the named barrier --- clang/include/clang/

[clang] [llvm] [AMDGPU] Add a type for the named barrier (PR #113614)

https://github.com/cmc-rep created https://github.com/llvm/llvm-project/pull/113614 None >From 166a4aec8a8ee813be0ee3045563cd45efd944c0 Mon Sep 17 00:00:00 2001 From: gangc Date: Thu, 24 Oct 2024 11:18:22 -0700 Subject: [PATCH] [AMDGPU] Add a type for the named barrier --- clang/include/clan

[clang] [llvm] [AMDGPU] Add a type for the named barrier (PR #113614)

https://github.com/cmc-rep updated https://github.com/llvm/llvm-project/pull/113614 >From 166a4aec8a8ee813be0ee3045563cd45efd944c0 Mon Sep 17 00:00:00 2001 From: gangc Date: Thu, 24 Oct 2024 11:18:22 -0700 Subject: [PATCH 1/3] [AMDGPU] Add a type for the named barrier --- clang/include/clang/

[clang] [llvm] [AMDGPU] Add a type for the named barrier (PR #113614)

https://github.com/cmc-rep updated https://github.com/llvm/llvm-project/pull/113614 >From 166a4aec8a8ee813be0ee3045563cd45efd944c0 Mon Sep 17 00:00:00 2001 From: gangc Date: Thu, 24 Oct 2024 11:18:22 -0700 Subject: [PATCH 1/2] [AMDGPU] Add a type for the named barrier --- clang/include/clang/

[clang] [llvm] [AMDGPU] Add a type for the named barrier (PR #113614)

https://github.com/cmc-rep updated https://github.com/llvm/llvm-project/pull/113614 >From 166a4aec8a8ee813be0ee3045563cd45efd944c0 Mon Sep 17 00:00:00 2001 From: gangc Date: Thu, 24 Oct 2024 11:18:22 -0700 Subject: [PATCH 1/2] [AMDGPU] Add a type for the named barrier --- clang/include/clang/

[clang] [llvm] [AMDGPU] Change CF intrinsics lowering to reconverge on predecessors. (PR #92809)

cmc-rep wrote: @alex-t Just curious about the status of this PR. Both this PR and the register-allocation PR by CD will have significant impact to the generated code. If we decide this is the right direction, then I feel it would be better to get it in earlier, so we can access its impact in

[clang] [llvm] [AMDGPU] Change CF intrinsics lowering to reconverge on predecessors. (PR #92809)

@@ -3172,8 +3172,8 @@ def int_amdgcn_loop : Intrinsic<[llvm_i1_ty], [llvm_anyint_ty], [IntrWillReturn, IntrNoCallback, IntrNoFree] >; -def int_amdgcn_end_cf : Intrinsic<[], [llvm_anyint_ty], - [IntrWillReturn, IntrNoCallback, IntrNoFree]>; +def int_amdgcn_wave_reconverge :

[clang] [llvm] [AMDGPU] Change CF intrinsics lowering to reconverge on predecessors. (PR #92809)

@@ -305,43 +304,43 @@ bool SIAnnotateControlFlow::handleLoop(BranchInst *Term) { } /// Close the last opened control flow -bool SIAnnotateControlFlow::closeControlFlow(BasicBlock *BB) { - llvm::Loop *L = LI->getLoopFor(BB); +bool SIAnnotateControlFlow::tryWaveReconverge(Basic