GabrielRavier added a comment.
> Do you need someone to land this on your behalf?
Yes.
> If so, what name and email address would you like used for patch attribution?
`Gabriel Ravier`, `gabrav...@gmail.com`
(By the way, is there any way to make this information part of my Phabricator
account
GabrielRavier added a comment.
Well I'm pretty sure I don't have commit rights to LLVM and it seems landing
means to push the revision onto main, so that would be nice, yes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130826/new/
https://reviews.
GabrielRavier added inline comments.
Comment at: clang/include/clang/Sema/Sema.h:4022
+ ExprResult &SrcExpr, bool DoFunctionPointerConversion = false,
+ bool Complain = false, SourceRange OpRangeForComplaining = SourceRange(),
+ QualType DestTypeForComplaining = Qu
GabrielRavier updated this revision to Diff 448858.
GabrielRavier added a comment.
Reverted reversion of `git clang-format` on `clang/include/clang/Sema/Sema.h`
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130827/new/
https://reviews.llvm.org/D130827
Files:
clang/bindings/python/cla
GabrielRavier abandoned this revision.
GabrielRavier added a comment.
Nvm I'm an idiot I thought this would update https://reviews.llvm.org/D130827
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130841/new/
https://reviews.llvm.org/D130841
GabrielRavier created this revision.
Herald added subscribers: steakhal, martong, arphaman, whisperity, mgorny.
Herald added a reviewer: aaron.ballman.
Herald added a reviewer: dang.
Herald added a reviewer: NoQ.
Herald added a reviewer: ributzka.
Herald added a project: All.
GabrielRavier requeste
GabrielRavier added inline comments.
Comment at: clang/include/clang/Sema/Sema.h:4022
+ ExprResult &SrcExpr, bool DoFunctionPointerConversion = false,
+ bool Complain = false, SourceRange OpRangeForComplaining = SourceRange(),
+ QualType DestTypeForComplaining = Qu
GabrielRavier updated this revision to Diff 448850.
GabrielRavier added a comment.
Fixed it so that it doesn't accidentally revert all the changes made since my
original diff
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130827/new/
https://review
GabrielRavier added inline comments.
Comment at: clang/lib/Headers/opencl-c.h:17856
+intel_sub_group_avc_sic_payload_t __ovld intel_sub_group_avc_sic_configure_ipe(
+uchar luma_intra_partition_mask, uchar intra_neighbour_availability,
uchar left_edge_luma_pixels, uchar u
GabrielRavier added a comment.
Ooh yeah looks like there's some damage. Shouldn't have done this at 12:30 AM
without looking at what that `git rebase` on the latest pull ended up doing...
I'll go fix this asap
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.l
GabrielRavier created this revision.
Herald added subscribers: steakhal, martong, arphaman, whisperity, mgorny.
Herald added a reviewer: aaron.ballman.
Herald added a reviewer: dang.
Herald added a reviewer: NoQ.
Herald added a reviewer: ributzka.
Herald added a project: All.
GabrielRavier requeste
GabrielRavier created this revision.
Herald added subscribers: carlosgalvezp, usaxena95, kadircet, arphaman,
javed.absar, kbarton, nemanjai.
Herald added a project: All.
GabrielRavier requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commi
GabrielRavier added a comment.
Well, I assumed if I split it up per project I would have been told to merge
all the patches into a big one to avoid having a bunch of small ones
essentially all doing the same thing, but then again this also makes sense,
I'll split it up.
Comm
13 matches
Mail list logo