Re: [PATCH] D69764: [clang-format] Add East/West Const fixer capability

It would probably be better to make the config option names for passes that may mutate whitespace be prefixed with MaybeIncorrect than fork the tool. Scary options are better than forks. On Wed, Jul 14, 2021 at 6:42 PM MyDeveloperDay via Phabricator < revi...@reviews.llvm.org> wrote: > MyDevelope

Re: [PATCH] D69764: [clang-format] Add East/West Const fixer capability

+1 for not only handling "const". I've often tried getting the various bits that appertain to a declaration (static const volatile constexpr inline consteval) sorted in a consistent order - that makes them much more greppable. Different patch, I expect, though. On Wed, Jul 14, 2021 at 1:47 PM Mar

Re: [PATCH] D69764: [clang-format] Add East/West Const fixer capability

It's very difficult to use a compile_commands database if you can't actually check out all the code and a remote service builds it for you. On Tue, Jul 13, 2021 at 6:03 PM Aaron Ballman via Phabricator < revi...@reviews.llvm.org> wrote: > aaron.ballman added a comment. > > In D69764#2874404

Re: [PATCH] D69764: [clang-format] Add East/West Const fixer capability

I prefer east/west, but I think there's a terminology that is uncontroversial (left/right) and one that is controversial. It's also clear to me that it's better to have only one set of terms (aliases are only fine for backwards compatibility). Left/Right won, I think. On Tue, May 26, 2020 at 1:55