[clang] [Sema]Use tag name lookup for class names (PR #112166)

2024-10-15 Thread Gábor Spaits via cfe-commits
https://github.com/spaits closed https://github.com/llvm/llvm-project/pull/112166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema]Use tag name lookup for class names (PR #112166)

2024-10-15 Thread Gábor Spaits via cfe-commits
spaits wrote: The windows CI passes. The linux CI fails, but it also fails on other clang fronted PRs (see https://github.com/llvm/llvm-project/pull/112289 for example). I think this failure is unrelated to this PR. I will merge this. https://github.com/llvm/llvm-project/pull/112166 __

[clang] [Sema]Use tag name lookup for class names (PR #112166)

2024-10-15 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/112166 From 4afa9c58b3e662b8acab65f8afed820c3cbf54b5 Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Mon, 14 Oct 2024 10:12:42 +0200 Subject: [PATCH] Use tag name lookup for class names This PR would fix #16855 . I

[clang] [Sema]Use tag name lookup for class names (PR #112166)

2024-10-14 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/112166 From 6935e90c94679129422cb00a7b05913b1ae83a5e Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Mon, 14 Oct 2024 10:12:42 +0200 Subject: [PATCH] Use tag name lookup for class names This PR would fix #16855 . I

[clang] [Sema]Use tag name lookup for class names (PR #112166)

2024-10-14 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/112166 From 64aa2ad0fa41ac93db311c70d4113886fd4d6ffd Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Mon, 14 Oct 2024 10:12:42 +0200 Subject: [PATCH] Use tag name lookup for class names This PR would fix #16855 . I

[clang] [Sema]Use tag name lookup for class names (PR #112166)

2024-10-14 Thread Gábor Spaits via cfe-commits
https://github.com/spaits edited https://github.com/llvm/llvm-project/pull/112166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema]Use tag name lookup for class names (PR #112166)

2024-10-14 Thread Gábor Spaits via cfe-commits
@@ -357,10 +357,13 @@ ParsedType Sema::getTypeName(const IdentifierInfo &II, SourceLocation NameLoc, return nullptr; } - // FIXME: LookupNestedNameSpecifierName isn't the right kind of - // lookup for class-names. - LookupNameKind Kind = isClassName ? LookupNestedN

[clang] [Sema]Use tag name lookup for class names (PR #112166)

2024-10-14 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/112166 From e9d43ef25b882071822cf3f16a988197c07967b1 Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Mon, 14 Oct 2024 10:12:42 +0200 Subject: [PATCH 01/11] Use tag name lookup for class names This PR would fix #16855

[clang] [Sema]Use tag name lookup for class names (PR #112166)

2024-10-14 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/112166 From e9d43ef25b882071822cf3f16a988197c07967b1 Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Mon, 14 Oct 2024 10:12:42 +0200 Subject: [PATCH 01/10] Use tag name lookup for class names This PR would fix #16855

[clang] [Sema]Use tag name lookup for class names (PR #112166)

2024-10-14 Thread Gábor Spaits via cfe-commits
@@ -357,10 +357,13 @@ ParsedType Sema::getTypeName(const IdentifierInfo &II, SourceLocation NameLoc, return nullptr; } - // FIXME: LookupNestedNameSpecifierName isn't the right kind of - // lookup for class-names. - LookupNameKind Kind = isClassName ? LookupNestedN

[clang] [Sema]Use tag name lookup for class names (PR #112166)

2024-10-14 Thread Gábor Spaits via cfe-commits
spaits wrote: Thank you @Sirraide for reviewing. I will wait a few hours if other also want to take a look at this, then I will squash the commits and merge the changes. https://github.com/llvm/llvm-project/pull/112166 ___ cfe-commits mailing list cfe

[clang] [Sema]Use tag name lookup for class names (PR #112166)

2024-10-14 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/112166 From e9d43ef25b882071822cf3f16a988197c07967b1 Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Mon, 14 Oct 2024 10:12:42 +0200 Subject: [PATCH 1/9] Use tag name lookup for class names This PR would fix #16855 .

[clang] [Sema]Use tag name lookup for class names (PR #112166)

2024-10-14 Thread Gábor Spaits via cfe-commits
@@ -151,6 +151,8 @@ C++ Language Changes - The builtin type alias ``__builtin_common_type`` has been added to improve the performance of ``std::common_type``. +- During the lookup for a base class name, non-type names are ignored. + spaits wrote: Sorry I d

[clang] [Sema]Use tag name lookup for class names (PR #112166)

2024-10-14 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/112166 From e9d43ef25b882071822cf3f16a988197c07967b1 Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Mon, 14 Oct 2024 10:12:42 +0200 Subject: [PATCH 1/8] Use tag name lookup for class names This PR would fix #16855 .

[clang] [Sema]Use tag name lookup for class names (PR #112166)

2024-10-14 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/112166 From e9d43ef25b882071822cf3f16a988197c07967b1 Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Mon, 14 Oct 2024 10:12:42 +0200 Subject: [PATCH 1/7] Use tag name lookup for class names This PR would fix #16855 .

[clang] [Sema]Use tag name lookup for class names (PR #112166)

2024-10-14 Thread Gábor Spaits via cfe-commits
spaits wrote: Thank you @Sirraide for reviewing my PR. I have added this change to the release notes and addressed the other comments. https://github.com/llvm/llvm-project/pull/112166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[clang] [Sema]Use tag name lookup for class names (PR #112166)

2024-10-14 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/112166 From e9d43ef25b882071822cf3f16a988197c07967b1 Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Mon, 14 Oct 2024 10:12:42 +0200 Subject: [PATCH 1/6] Use tag name lookup for class names This PR would fix #16855 .

[clang] [Sema]Use tag name lookup for class names (PR #112166)

2024-10-14 Thread Gábor Spaits via cfe-commits
https://github.com/spaits edited https://github.com/llvm/llvm-project/pull/112166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Use tag name lookup for class names (PR #112166)

2024-10-14 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/112166 From e9d43ef25b882071822cf3f16a988197c07967b1 Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Mon, 14 Oct 2024 10:12:42 +0200 Subject: [PATCH 1/3] Use tag name lookup for class names This PR would fix #16855 .

[clang] Use tag name lookup for class names (PR #112166)

2024-10-14 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/112166 From e9d43ef25b882071822cf3f16a988197c07967b1 Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Mon, 14 Oct 2024 10:12:42 +0200 Subject: [PATCH 1/2] Use tag name lookup for class names This PR would fix #16855 .

[clang] Use tag name lookup for class names (PR #112166)

2024-10-14 Thread Gábor Spaits via cfe-commits
https://github.com/spaits created https://github.com/llvm/llvm-project/pull/112166 This PR would fix #16855 . I think the correct lookup to use for class names is Tag name lookup, because it does not take namespaces into account. The current lookup does and because of this some valid programs

[clang] [Clang] Simplify release notes and remove irrelevant comment (PR #96407)

2024-07-06 Thread Gábor Spaits via cfe-commits
https://github.com/spaits closed https://github.com/llvm/llvm-project/pull/96407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Simplify release notes and remove irrelevant comment (PR #96407)

2024-06-22 Thread Gábor Spaits via cfe-commits
https://github.com/spaits created https://github.com/llvm/llvm-project/pull/96407 As discussed before with @cor3ntin before (https://github.com/llvm/llvm-project/pull/94752) here is the simplification of the release note written for the previously mentioned PR and the removal of a comment th

[clang] [Sema][CTAD] Allow user defined conversion for copy-list-initialization (PR #94752)

2024-06-20 Thread Gábor Spaits via cfe-commits
https://github.com/spaits edited https://github.com/llvm/llvm-project/pull/94752 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema][CTAD] Allow user defined conversion for copy-list-initialization (PR #94752)

2024-06-20 Thread Gábor Spaits via cfe-commits
@@ -199,6 +199,12 @@ C++20 Feature Support to update the ``__cpp_concepts`` macro to `202002L`. This enables from libstdc++ to work correctly with Clang. +- User defined constructors are allowed for copy-list-initialization with CTAD. + The example code for deduction

[clang] [Sema][CTAD] Allow user defined conversion for copy-list-initialization (PR #94752)

2024-06-20 Thread Gábor Spaits via cfe-commits
@@ -10892,8 +10892,6 @@ QualType Sema::DeduceTemplateSpecializationFromInitializer( // FIXME: The "second phase of [over.match.list] case can also // theoretically happen here, but it's not clear whether we can // ever have a parameter of the right type. --

[clang] [Sema][CTAD] Allow user defined conversion for copy-list-initialization (PR #94752)

2024-06-18 Thread Gábor Spaits via cfe-commits
https://github.com/spaits closed https://github.com/llvm/llvm-project/pull/94752 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema][CTAD] Allow user defined conversion for copy-list-initialization (PR #94752)

2024-06-18 Thread Gábor Spaits via cfe-commits
spaits wrote: > thanks, looks good. Thank you for reviewing. When the CI run finishes and it is successful I will merge this PR. https://github.com/llvm/llvm-project/pull/94752 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] [Sema][CTAD] Allow user defined conversion for copy-list-initialization (PR #94752)

2024-06-18 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/94752 From 8e1f3aa676b891c9566344ad2be046898df34a3a Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Fri, 7 Jun 2024 14:38:08 +0200 Subject: [PATCH 1/4] [CTAD] Allow user defined conversion --- clang/include/clang/Se

[clang] [Sema][CTAD] Allow user defined conversion for copy-list-initialization (PR #94752)

2024-06-17 Thread Gábor Spaits via cfe-commits
spaits wrote: @zyn0217 @cor3ntin Sorry to ping you. Could you please take another look at this PR? Are my assumptions about the standard correct? Are the tests good now or I should make other changes? https://github.com/llvm/llvm-project/pull/94752 _

[clang] [Sema][CTAD] Allow user defined conversion for copy-list-initialization (PR #94752)

2024-06-09 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/94752 From 8e1f3aa676b891c9566344ad2be046898df34a3a Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Fri, 7 Jun 2024 14:38:08 +0200 Subject: [PATCH 1/2] [CTAD] Allow user defined conversion --- clang/include/clang/Se

[clang] [Sema][CTAD] Allow user defined conversion for copy-list-initialization (PR #94752)

2024-06-09 Thread Gábor Spaits via cfe-commits
spaits wrote: @zyn0217 Thank you for checking my PR. I was able to simplify the `std::initializer_list` definition. I have also created two different "categories" for the test. One test contains almost the exact code as the one in the reported issue with the same class names. The other one is

[clang] [Sema][CTAD] Allow user defined conversion for copy-list-initialization (PR #94752)

2024-06-07 Thread Gábor Spaits via cfe-commits
https://github.com/spaits edited https://github.com/llvm/llvm-project/pull/94752 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema][CTAD] Allow user defined conversion for copy-list-initialization (PR #94752)

2024-06-07 Thread Gábor Spaits via cfe-commits
https://github.com/spaits created https://github.com/llvm/llvm-project/pull/94752 This PR would solve issue #62925. The following code: ```cpp #include int main() { std::map m1 = {std::pair{"foo", 2}, {"bar", 3}}; // guide #2 std::map m2(m1.begin(), m1.end()); // guide #1 } ``` Is rejec

[clang] [analyzer] Variant checker bindings (PR #87886)

2024-04-06 Thread Gábor Spaits via cfe-commits
https://github.com/spaits edited https://github.com/llvm/llvm-project/pull/87886 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Variant checker bindings (PR #87886)

2024-04-06 Thread Gábor Spaits via cfe-commits
https://github.com/spaits edited https://github.com/llvm/llvm-project/pull/87886 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Variant checker bindings (PR #87886)

2024-04-06 Thread Gábor Spaits via cfe-commits
https://github.com/spaits edited https://github.com/llvm/llvm-project/pull/87886 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Variant checker bindings (PR #87886)

2024-04-06 Thread Gábor Spaits via cfe-commits
https://github.com/spaits created https://github.com/llvm/llvm-project/pull/87886 None From b9d22d9ebc152ac0bccc7e196f8bbecc9302d833 Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Sat, 13 Jan 2024 21:06:52 +0100 Subject: [PATCH 1/2] [analyzer] Implement modeling of std::swap and bind to SV

[clang] [analyzer] Improve some comments in ArrayBoundCheckerV2 (NFC) (PR #83545)

2024-03-03 Thread Gábor Spaits via cfe-commits
https://github.com/spaits approved this pull request. https://github.com/llvm/llvm-project/pull/83545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Improve some comments in ArrayBoundCheckerV2 (NFC) (PR #83545)

2024-03-02 Thread Gábor Spaits via cfe-commits
@@ -301,21 +301,27 @@ compareValueToThreshold(ProgramStateRef State, NonLoc Value, NonLoc Threshold, // calling `evalBinOpNN`: if (isNegative(SVB, State, Value) && isUnsigned(SVB, Threshold)) { if (CheckEquality) { - // negative_value == unsigned_value is always f

[clang] [analyzer] Improve some comments in ArrayBoundCheckerV2 (NFC) (PR #83545)

2024-03-01 Thread Gábor Spaits via cfe-commits
@@ -301,21 +301,27 @@ compareValueToThreshold(ProgramStateRef State, NonLoc Value, NonLoc Threshold, // calling `evalBinOpNN`: if (isNegative(SVB, State, Value) && isUnsigned(SVB, Threshold)) { if (CheckEquality) { - // negative_value == unsigned_value is always f

[clang] [analyzer] Remove superfluous #include "CallDescription.h" (NFC) (PR #82614)

2024-02-22 Thread Gábor Spaits via cfe-commits
https://github.com/spaits approved this pull request. It looks good to me. https://github.com/llvm/llvm-project/pull/82614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Restructure and extend the testing of template pack deduction (PR #79881)

2024-01-30 Thread Gábor Spaits via cfe-commits
https://github.com/spaits closed https://github.com/llvm/llvm-project/pull/79881 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Restructure and extend the testing of template pack deduction (PR #79881)

2024-01-29 Thread Gábor Spaits via cfe-commits
https://github.com/spaits created https://github.com/llvm/llvm-project/pull/79881 Previously I worked on #78449 . I added tests in my solution #79371, but I think there should be other scenarios that should be tested and these tests deserve their namespace. In this PR I would like to make thes

[clang] [Sema] Substitute parameter packs when deduced from function arguments (PR #79371)

2024-01-27 Thread Gábor Spaits via cfe-commits
https://github.com/spaits closed https://github.com/llvm/llvm-project/pull/79371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Substitute parameter packs when deduced from function arguments (PR #79371)

2024-01-27 Thread Gábor Spaits via cfe-commits
spaits wrote: > It's unrelated to your changes. Configuration issue on the CI, probably Okay. Then I will merge this. Thank you very much for reviewing my PR and helping me. https://github.com/llvm/llvm-project/pull/79371 ___ cfe-commits mailing list

[clang] [Sema] Substitute parameter packs when deduced from function arguments (PR #79371)

2024-01-27 Thread Gábor Spaits via cfe-commits
spaits wrote: @cor3ntin I see that you have CI runs that fail with exactly the same reason as my runs: https://buildkite.com/llvm-project/clang-ci/builds/10874#018d49c2-1224-4939-9430-0e5a2be796a9 . https://github.com/llvm/llvm-project/pull/79371 __

[clang] [Sema] Substitute parameter packs when deduced from function arguments (PR #79371)

2024-01-27 Thread Gábor Spaits via cfe-commits
spaits wrote: Thank you for reviewing. Before merge we should take a look at the CI. It still fails for libc++ 26 suite, with the same reason as before. I wanted to reproduce the issue. I built libc++ with the clang++ I compiled: ``` cmake -S "../runtimes" -GNinja \ -DLLVM_ENABLE_RUN

[clang] [Sema] Substitute parameter packs when deduced from function arguments (PR #79371)

2024-01-27 Thread Gábor Spaits via cfe-commits
@@ -858,6 +859,27 @@ class PackDeductionScope { Info.PendingDeducedPacks[Pack.Index] = Pack.Outer; } + // Return the size of the saved packs if all of them has the same size. + std::optional getSavedPackSizeIfAllEqual() const { +if (Packs.size() == 0 || +

[clang] [Sema] Substitute parameter packs when deduced from function arguments (PR #79371)

2024-01-26 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/79371 From 3e0c3db0d8500e5f2111e3603da3d8f2b1cd261d Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Wed, 24 Jan 2024 21:21:26 +0100 Subject: [PATCH 01/16] [Sema]Substitue template parameter packs when deduced from fu

[clang] [Sema] Substitute parameter packs when deduced from function arguments (PR #79371)

2024-01-26 Thread Gábor Spaits via cfe-commits
https://github.com/spaits edited https://github.com/llvm/llvm-project/pull/79371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Substitute parameter packs when deduced from function arguments (PR #79371)

2024-01-26 Thread Gábor Spaits via cfe-commits
@@ -858,6 +859,27 @@ class PackDeductionScope { Info.PendingDeducedPacks[Pack.Index] = Pack.Outer; } + // Return the size of the saved packs if all of them has the same size. + std::optional getSavedPackSizeIfAllEqual() const { +if (Packs.size() == 0 || +

[clang] [Sema] Substitute parameter packs when deduced from function arguments (PR #79371)

2024-01-26 Thread Gábor Spaits via cfe-commits
@@ -431,6 +442,17 @@ namespace deduction_after_explicit_pack { i(0, 1, 2, 3, 4, 5); // expected-error {{no match}} } + template + void bar(args_tag, type_identity_t..., int mid, type_identity_t...) {} spaits wrote: Added the test. It also works. ht

[clang] [Sema] Substitute parameter packs when deduced from function arguments (PR #79371)

2024-01-26 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/79371 From 3e0c3db0d8500e5f2111e3603da3d8f2b1cd261d Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Wed, 24 Jan 2024 21:21:26 +0100 Subject: [PATCH 01/15] [Sema]Substitue template parameter packs when deduced from fu

[clang] [Sema] Substitute parameter packs when deduced from function arguments (PR #79371)

2024-01-26 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/79371 From 3e0c3db0d8500e5f2111e3603da3d8f2b1cd261d Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Wed, 24 Jan 2024 21:21:26 +0100 Subject: [PATCH 01/14] [Sema]Substitue template parameter packs when deduced from fu

[clang] [Sema] Substitute parameter packs when deduced from function arguments (PR #79371)

2024-01-26 Thread Gábor Spaits via cfe-commits
spaits wrote: I did some more digging. I saw that the test in the CI fails with permission errors. ``` | No symbol table is loaded. Use the "file" command. | warning: opening /proc/PID/mem file for lwp 4103309.4103309 failed: Permission denied (13) | Traceback (most recent call last): | Fil

[clang] [Sema] Substitute parameter packs when deduced from function arguments (PR #79371)

2024-01-26 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/79371 From 3e0c3db0d8500e5f2111e3603da3d8f2b1cd261d Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Wed, 24 Jan 2024 21:21:26 +0100 Subject: [PATCH 01/13] [Sema]Substitue template parameter packs when deduced from fu

[clang] [Sema] Substitute parameter packs when deduced from function arguments (PR #79371)

2024-01-26 Thread Gábor Spaits via cfe-commits
spaits wrote: It looks like libc++ test suites are failing. Looking at the logs from the CI I can not really figure out what is the exact reason. I could only deduce that the failing test case is `libcxx/gdb/gdb_pretty_printer_test.sh.cpp`. This case seems to be related to `libcxx/selftest/con

[clang] [Sema] Substitute parameter packs when deduced from function arguments (PR #79371)

2024-01-25 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/79371 From 38107a96c18fc5d008873fbac5257f0f476799f3 Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Wed, 24 Jan 2024 21:21:26 +0100 Subject: [PATCH 01/13] [Sema]Substitue template parameter packs when deduced from fu

[clang] [Sema] Substitute parameter packs when deduced from function arguments (PR #79371)

2024-01-25 Thread Gábor Spaits via cfe-commits
@@ -431,6 +442,17 @@ namespace deduction_after_explicit_pack { i(0, 1, 2, 3, 4, 5); // expected-error {{no match}} } + template + void bar(args_tag, type_identity_t..., int mid, type_identity_t...) {} spaits wrote: I added a test for this. https://

[clang] [Sema] Substitute parameter packs when deduced from function arguments (PR #79371)

2024-01-25 Thread Gábor Spaits via cfe-commits
spaits wrote: > > @cor3ntin @erichkeane Thank you for checking the updates on my PR. I fixed > > the typo and added the release notes. Also rebased the branch. > > Looks like the release notes change failed CI. Not my changes. This was commited 3 hours ago: https://github.com/spaits/llvm-proj

[clang] [Sema] Substitute parameter packs when deduced from function arguments (PR #79371)

2024-01-25 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/79371 From a27fe8c4179a58a741121eec9e8368c9ab44d7cc Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Wed, 24 Jan 2024 21:21:26 +0100 Subject: [PATCH 01/13] [Sema]Substitue template parameter packs when deduced from fu

[clang] [Sema] Substitute parameter packs when deduced from function arguments (PR #79371)

2024-01-25 Thread Gábor Spaits via cfe-commits
spaits wrote: @cor3ntin @erichkeane Thank you for checking the updates on my PR. I fixed the typo and added the release notes. https://github.com/llvm/llvm-project/pull/79371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] [Sema] Substitute parameter packs when deduced from function arguments (PR #79371)

2024-01-25 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/79371 From a27fe8c4179a58a741121eec9e8368c9ab44d7cc Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Wed, 24 Jan 2024 21:21:26 +0100 Subject: [PATCH 01/12] [Sema]Substitue template parameter packs when deduced from fu

[clang] [Sema] Substitute parameter packs when deduced from function arguments (PR #79371)

2024-01-25 Thread Gábor Spaits via cfe-commits
https://github.com/spaits edited https://github.com/llvm/llvm-project/pull/79371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Substitue parameter packs when deduced from function arguments (PR #79371)

2024-01-25 Thread Gábor Spaits via cfe-commits
https://github.com/spaits edited https://github.com/llvm/llvm-project/pull/79371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema]Substitue parameter packs when deduced from function parameter (PR #79371)

2024-01-25 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/79371 From c00b8bd525b6acab45009188a7b9d1cb8c7eb30d Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Wed, 24 Jan 2024 21:21:26 +0100 Subject: [PATCH 01/12] [Sema]Substitue template parameter packs when deduced from fu

[clang] [Sema]Substitue parameter packs when deduced from function parameter (PR #79371)

2024-01-25 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/79371 From c00b8bd525b6acab45009188a7b9d1cb8c7eb30d Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Wed, 24 Jan 2024 21:21:26 +0100 Subject: [PATCH 01/11] [Sema]Substitue template parameter packs when deduced from fu

[clang] [Sema]Substitue parameter packs when deduced from function parameter (PR #79371)

2024-01-25 Thread Gábor Spaits via cfe-commits
spaits wrote: > I don't see the release note, and there is a typo in the PR entry that should > be fixed. > > Else just 1 nit. Oh sorry I forgot about the release note. I will update that. https://github.com/llvm/llvm-project/pull/79371 ___ cfe-comm

[clang] [Sema]Substitue parameter packs when deduced from function parameter (PR #79371)

2024-01-25 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/79371 From c00b8bd525b6acab45009188a7b9d1cb8c7eb30d Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Wed, 24 Jan 2024 21:21:26 +0100 Subject: [PATCH 01/10] [Sema]Substitue template parameter packs when deduced from fu

[clang] [Sema]Substitue parameter packs when deduced from function parameter (PR #79371)

2024-01-25 Thread Gábor Spaits via cfe-commits
spaits wrote: Thank you @cor3ntin for reviewing my PR. I addressed all of your comments. - I fixed the types. - I added support for deduction of non-trailing packs when there is no separator type. - Simplified the code. This simplification has affect on the code you asked about. Could you pl

[clang] [Sema]Substitue parameter packs when deduced from function parameter (PR #79371)

2024-01-25 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/79371 From d4ca5c2fcb87f424be23efc4513df491403c3811 Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Wed, 24 Jan 2024 21:21:26 +0100 Subject: [PATCH 01/10] [Sema]Substitue template parameter packs when deduced from fu

[clang] [Sema]Substitue parameter packs when deduced from function parameter (PR #79371)

2024-01-25 Thread Gábor Spaits via cfe-commits
@@ -4371,6 +4397,41 @@ Sema::TemplateDeductionResult Sema::DeduceTemplateArguments( // corresponding argument is a list? PackScope.nextPackElement(); } + } else if (!IsTrailingPack && !PackScope.isPartiallyExpanded() && + PackSc

[clang] [Sema]Substitue parameter packs when deduced from function parameter (PR #79371)

2024-01-25 Thread Gábor Spaits via cfe-commits
@@ -858,6 +859,30 @@ class PackDeductionScope { Info.PendingDeducedPacks[Pack.Index] = Pack.Outer; } + std::optional getSavedPackSize(unsigned Index, + TemplateArgument Pattern) const { + +SmallVector Unexpanded; +S.co

[clang] [Sema]Substitue parameter packs when deduced from function parameter (PR #79371)

2024-01-25 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/79371 From d4ca5c2fcb87f424be23efc4513df491403c3811 Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Wed, 24 Jan 2024 21:21:26 +0100 Subject: [PATCH 1/9] [Sema]Substitue template parameter packs when deduced from func

[clang] [Sema]Substitue parameter packs when deduced from function parameter (PR #79371)

2024-01-25 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/79371 From d4ca5c2fcb87f424be23efc4513df491403c3811 Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Wed, 24 Jan 2024 21:21:26 +0100 Subject: [PATCH 1/8] [Sema]Substitue template parameter packs when deduced from func

[clang] [Sema]Substitue parameter packs when deduced from function parameter (PR #79371)

2024-01-25 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/79371 From d4ca5c2fcb87f424be23efc4513df491403c3811 Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Wed, 24 Jan 2024 21:21:26 +0100 Subject: [PATCH 1/7] [Sema]Substitue template parameter packs when deduced from func

[clang] [Sema]Substitue parameter packs when deduced from function parameter (PR #79371)

2024-01-25 Thread Gábor Spaits via cfe-commits
@@ -431,6 +442,17 @@ namespace deduction_after_explicit_pack { i(0, 1, 2, 3, 4, 5); // expected-error {{no match}} } + template + void bar(args_tag, type_identity_t..., int mid, type_identity_t...) {} spaits wrote: It could work. It would cost only

[clang] [Sema]Substitue parameter packs when deduced from function parameter (PR #79371)

2024-01-25 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/79371 From d4ca5c2fcb87f424be23efc4513df491403c3811 Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Wed, 24 Jan 2024 21:21:26 +0100 Subject: [PATCH 1/6] [Sema]Substitue template parameter packs when deduced from func

[clang] [Sema]Substitue parameter packs when deduced from function parameter (PR #79371)

2024-01-25 Thread Gábor Spaits via cfe-commits
https://github.com/spaits edited https://github.com/llvm/llvm-project/pull/79371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema]Substitue parameter packs when deduced from function parameter (PR #79371)

2024-01-25 Thread Gábor Spaits via cfe-commits
@@ -4371,6 +4397,41 @@ Sema::TemplateDeductionResult Sema::DeduceTemplateArguments( // corresponding argument is a list? PackScope.nextPackElement(); } + } else if (!IsTrailingPack && !PackScope.isPartiallyExpanded() && + PackSc

[clang] [Sema]Substitue parameter packs when deduced from function parameter (PR #79371)

2024-01-25 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/79371 From d4ca5c2fcb87f424be23efc4513df491403c3811 Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Wed, 24 Jan 2024 21:21:26 +0100 Subject: [PATCH 1/5] [Sema]Substitue template parameter packs when deduced from func

[clang] [Sema]Substitue parameter packs when deduced from function parameter (PR #79371)

2024-01-24 Thread Gábor Spaits via cfe-commits
https://github.com/spaits edited https://github.com/llvm/llvm-project/pull/79371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema]Substitue parameter packs when deduced from function parameter (PR #79371)

2024-01-24 Thread Gábor Spaits via cfe-commits
https://github.com/spaits edited https://github.com/llvm/llvm-project/pull/79371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema]Substitue parameter packs when deduced from function parameter (PR #79371)

2024-01-24 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/79371 From d4ca5c2fcb87f424be23efc4513df491403c3811 Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Wed, 24 Jan 2024 21:21:26 +0100 Subject: [PATCH 1/4] [Sema]Substitue template parameter packs when deduced from func

[clang] [Sema]Substitue parameter packs when deduced from function parameter (PR #79371)

2024-01-24 Thread Gábor Spaits via cfe-commits
https://github.com/spaits edited https://github.com/llvm/llvm-project/pull/79371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema]Substitue parameter packs when deduced from function parameter (PR #79371)

2024-01-24 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/79371 From d4ca5c2fcb87f424be23efc4513df491403c3811 Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Wed, 24 Jan 2024 21:21:26 +0100 Subject: [PATCH 1/3] [Sema]Substitue template parameter packs when deduced from func

[clang] [Sema]Substitue parameter packs when deduced from function parameter (PR #79371)

2024-01-24 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/79371 From d4ca5c2fcb87f424be23efc4513df491403c3811 Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Wed, 24 Jan 2024 21:21:26 +0100 Subject: [PATCH 1/2] [Sema]Substitue template parameter packs when deduced from func

[clang] [Sema]Substitue parameter packs when deduced from function parameter (PR #79371)

2024-01-24 Thread Gábor Spaits via cfe-commits
https://github.com/spaits created https://github.com/llvm/llvm-project/pull/79371 This pull request would solve https://github.com/llvm/llvm-project/issues/78449 . There is also a discussion about this on stackoverflow: https://stackoverflow.com/questions/77832658/stdtype-identity-to-support-s

[clang] [analyzer] Add std::any checker (PR #76580)

2024-01-10 Thread Gábor Spaits via cfe-commits
@@ -0,0 +1,201 @@ +//===- StdAnyChecker.cpp -*- C++ -*===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [analyzer] Add std::any checker (PR #76580)

2024-01-10 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/76580 From a19329050600d4d89cc698b686d7aaa13e0c22c2 Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Fri, 29 Dec 2023 17:54:34 +0100 Subject: [PATCH 01/20] [analyzer] Add std::any checker --- clang/docs/analyzer/chec

[clang] [analyzer] Add std::any checker (PR #76580)

2024-01-10 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/76580 From a19329050600d4d89cc698b686d7aaa13e0c22c2 Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Fri, 29 Dec 2023 17:54:34 +0100 Subject: [PATCH 01/19] [analyzer] Add std::any checker --- clang/docs/analyzer/chec

[clang] [analyzer] Add std::any checker (PR #76580)

2024-01-04 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/76580 From a19329050600d4d89cc698b686d7aaa13e0c22c2 Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Fri, 29 Dec 2023 17:54:34 +0100 Subject: [PATCH 01/18] [analyzer] Add std::any checker --- clang/docs/analyzer/chec

[clang] [analyzer] Add std::any checker (PR #76580)

2024-01-04 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/76580 From 98b52eb390438402562de96a74771b0132fc71cb Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Fri, 29 Dec 2023 17:54:34 +0100 Subject: [PATCH 01/18] [analyzer] Add std::any checker --- clang/docs/analyzer/chec

[clang] [analyzer] Add std::any checker (PR #76580)

2024-01-04 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/76580 From 98b52eb390438402562de96a74771b0132fc71cb Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Fri, 29 Dec 2023 17:54:34 +0100 Subject: [PATCH 01/16] [analyzer] Add std::any checker --- clang/docs/analyzer/chec

[clang] [analyzer] Add std::any checker (PR #76580)

2024-01-04 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/76580 From 98b52eb390438402562de96a74771b0132fc71cb Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Fri, 29 Dec 2023 17:54:34 +0100 Subject: [PATCH 01/15] [analyzer] Add std::any checker --- clang/docs/analyzer/chec

[clang] [analyzer] Add std::any checker (PR #76580)

2024-01-03 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/76580 From 98b52eb390438402562de96a74771b0132fc71cb Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Fri, 29 Dec 2023 17:54:34 +0100 Subject: [PATCH 01/12] [analyzer] Add std::any checker --- clang/docs/analyzer/chec

[clang] [analyzer] Add std::any checker (PR #76580)

2024-01-03 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/76580 From 98b52eb390438402562de96a74771b0132fc71cb Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Fri, 29 Dec 2023 17:54:34 +0100 Subject: [PATCH 01/11] [analyzer] Add std::any checker --- clang/docs/analyzer/chec

[clang] [analyzer] Add std::any checker (PR #76580)

2024-01-03 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/76580 From 98b52eb390438402562de96a74771b0132fc71cb Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Fri, 29 Dec 2023 17:54:34 +0100 Subject: [PATCH 01/10] [analyzer] Add std::any checker --- clang/docs/analyzer/chec

[clang] [analyzer] Add std::any checker (PR #76580)

2024-01-03 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/76580 From 98b52eb390438402562de96a74771b0132fc71cb Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Fri, 29 Dec 2023 17:54:34 +0100 Subject: [PATCH 1/9] [analyzer] Add std::any checker --- clang/docs/analyzer/checke

  1   2   >