[PATCH] D90972: [clang-tidy] Install run-clang-tidy.py in bin/ as run-clang-tidy

2021-02-22 Thread Florian Schmaus via Phabricator via cfe-commits
Flow added a comment. In D90972#2580020 , @njames93 wrote: > In D90972#2446448 , @Flow wrote: > >> In D90972#2394516 , @JonasToth >> wrote: >> >>> LGTM! thanks for fixing. >

[PATCH] D90972: [clang-tidy] Install run-clang-tidy.py in bin/ as run-clang-tidy

2020-12-10 Thread Florian Schmaus via Phabricator via cfe-commits
Flow requested review of this revision. Flow added a comment. In D90972#2394516 , @JonasToth wrote: > LGTM! thanks for fixing. I am unable to commit this myself. The latest version of this change

[PATCH] D90972: [clang-tidy] Install run-clang-tidy.py in bin/ as run-clang-tidy

2020-11-07 Thread Florian Schmaus via Phabricator via cfe-commits
Flow updated this revision to Diff 303642. Flow added a comment. Use backticks in ReleaseNotes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90972/new/ https://reviews.llvm.org/D90972 Files: clang-tools-extra/clang-tidy/tool/CMakeLists.txt cla

[PATCH] D91001: [clang-tidy] Install run-clang-tidy.py as run-clang-tidy

2020-11-07 Thread Florian Schmaus via Phabricator via cfe-commits
Flow abandoned this revision. Flow added a comment. All changes introduced by this are now done in https://reviews.llvm.org/D90972 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91001/new/ https://reviews.llvm.org/D91001 ___

[PATCH] D90972: [clang-tidy] Install run-clang-tidy.py in bin/ as run-clang-tidy

2020-11-07 Thread Florian Schmaus via Phabricator via cfe-commits
Flow updated this revision to Diff 303638. Flow retitled this revision from "[clang-tidy] Install run-clang-tidy.py in bin/ not in share/clang/" to "[clang-tidy] Install run-clang-tidy.py in bin/ as run-clang-tidy". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D90972: [clang-tidy] Install run-clang-tidy.py in bin/ not in share/clang/

2020-11-07 Thread Florian Schmaus via Phabricator via cfe-commits
Flow added a comment. In D90972#2380640 , @sylvestre.ledru wrote: > By the way, while you are working on it, why not removing the python > extension when installing? We don't need to know that it is Python code. Thanks for the feedback. Please see https

[PATCH] D91001: [clang-tidy] Install run-clang-tidy.py as run-clang-tidy

2020-11-07 Thread Florian Schmaus via Phabricator via cfe-commits
Flow created this revision. Flow added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Herald added a project: clang. Flow requested review of this revision. Installed scripts in PATH usually do not carry a filename extension, since there is no need to know

[PATCH] D90972: [clang-tidy] Install run-clang-tidy.py in bin/ not in share/clang/

2020-11-07 Thread Florian Schmaus via Phabricator via cfe-commits
Flow added reviewers: alexfh, sylvestre.ledru, Eugene.Zelenko. Flow added a comment. Adding involved persons from https://reviews.llvm.org/D12700 as reviewers, which was the change introducing `share/clang/` as install location. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90972: [clang-tidy] Install run-clang-tidy.py in bin/ not in share/clang/

2020-11-06 Thread Florian Schmaus via Phabricator via cfe-commits
Flow created this revision. Flow added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Herald added a project: clang. Flow requested review of this revision. The run-clang-tidy.py helper script is supposed to be used by the user, hence it should be placed in