[PATCH] D157080: [clangd] Symbol search includes parameter types for (member) functions

florianhumblot abandoned this revision. florianhumblot added a comment. @sammccall I guess you're right, I'll look into getting a fix into vscode instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157080/new/ https://reviews.llvm.org/D157080 ___

[PATCH] D157080: [clangd] Symbol search includes parameter types for (member) functions

florianhumblot updated this revision to Diff 547150. florianhumblot added a comment. Forgot to update the tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157080/new/ https://reviews.llvm.org/D157080 Files: clang-tools-extra/clangd/Protocol.cpp clang-tools-extra/clangd/test/sym

[PATCH] D157080: [clangd] Symbol search includes parameter types for (member) functions

florianhumblot created this revision. florianhumblot added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. Herald added a project: All. florianhumblot requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. When using clangd as

[PATCH] D145778: [clang-tidy] Change readability-magic-numbers to allow numbers in type aliases.

florianhumblot added a comment. In D145778#4184611 , @PiotrZSL wrote: > What should I put as commit author ? > I'm asking because this is diff, and commit author looks to be attached to it. "Florian Humblot " should be good :) CHANGES SINCE LAST ACTI

[PATCH] D145778: [clang-tidy] Change readability-magic-numbers to allow numbers in type aliases.

florianhumblot added a comment. In D145778#4184530 , @PiotrZSL wrote: > LGTM Thanks for the reviews @PiotrZSL ! Is one review enough or does the second reviewer also need to approve these changes? If this one is enough, could I ask you (or someone els

[PATCH] D145778: [clang-tidy] Change readability-magic-numbers to allow numbers in type aliases.

florianhumblot updated this revision to Diff 504097. florianhumblot marked 2 inline comments as done. florianhumblot added a comment. Generate diff with full context and updated the example to use the default settings of the readabiliy-magic-numbers checker CHANGES SINCE LAST ACTION https://r

[PATCH] D145780: [clang-tidy] Introduce option to allow magic numbers in type aliases

florianhumblot abandoned this revision. florianhumblot added a comment. Accidentally opened this one with arcanist. The changes have been moved to https://reviews.llvm.org/D145778 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145780/new/ https://r

[PATCH] D145778: [clang-tidy] Change readability-magic-numbers to allow numbers in type aliases.

florianhumblot updated this revision to Diff 504089. florianhumblot edited the summary of this revision. florianhumblot added a comment. Made it so that the proposed change doesn't change the default behavior of the check. Introduce an option to allow enabling the exclusion. CHANGES SINCE LAST

[PATCH] D145780: [clang-tidy] Introduce option to allow magic numbers in type aliases

florianhumblot created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, jeroen.dobbelaere, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. florianhumblot requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscrib

[PATCH] D145778: [clang-tidy] Change readability-magic-numbers to allow numbers in type aliases.

florianhumblot created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, jeroen.dobbelaere, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. florianhumblot requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscrib