[PATCH] D158929: [clang-tidy] Add exit code support to clang-tidy-diff.py

FlashSheridan added a comment. Thank you kindly, this is looking very good on our recent changes in my manual usage. (It will take some more work before I can run it in our GitHub Action, which I’m looking forward to.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D158929: [clang-tidy] Add exit code support to clang-tidy-diff.py

FlashSheridan added a comment. A couple of low-priority suggestions from Pylint 3 at 326 and 95: Comment at: clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py:95 -def start_workers(max_tasks, tidy_caller, task_queue, lock, timeout): +def start_workers(max_tasks, tidy_calle

[PATCH] D158929: [clang-tidy] Add exit code support to clang-tidy-diff.py

FlashSheridan added a comment. Thank you, looks promising and I will test it on Monday. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158929/new/ https://reviews.llvm.org/D158929 ___ cfe-commits mailing

[PATCH] D140730: 59559 Explain code coverage with Lit in docs/SourceBasedCodeCoverage.rst

FlashSheridan added a comment. Per https://llvm.org/docs/Phabricator.html#committing-a-change, I cannot commit the patch myself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140730/new/ https://reviews.llvm.org/D140730 __

[PATCH] D140730: 59559 Explain code coverage with Lit in docs/SourceBasedCodeCoverage.rst

FlashSheridan added inline comments. Comment at: clang/docs/SourceBasedCodeCoverage.rst:133 +each invocation. The pattern strings "%p" or "%Nm" may help to avoid +corruption due to concurrency. + Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140730: 59559 Explain code coverage with Lit in docs/SourceBasedCodeCoverage.rst

FlashSheridan created this revision. Herald added a project: All. FlashSheridan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The documentation for code coverage in docs/SourceBasedCodeCoverage.rst omits a couple of crucial steps when us