https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/140294
>From 8889c7f28b29a1afc0d41da645216efeda30c991 Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Fri, 16 May 2025 17:45:24 +
Subject: [PATCH 1/3] pre-req: add keywords
---
.../clang/Lex/HLSLRootSignatureTo
https://github.com/inbelic edited
https://github.com/llvm/llvm-project/pull/140294
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic closed
https://github.com/llvm/llvm-project/pull/140293
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/140293
>From 1eabfe2fe30eaed793bdcf03f0e58d1e0c14548f Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Fri, 16 May 2025 16:38:33 +
Subject: [PATCH 1/4] pre-req: add keywords
---
.../clang/Lex/HLSLRootSignatureTo
@@ -252,6 +254,10 @@ TEST_F(ParseHLSLRootSignatureTest,
ValidParseStaticSamplerTest) {
ASSERT_TRUE(std::holds_alternative(Elem));
ASSERT_EQ(std::get(Elem).Reg.ViewType, RegisterType::SReg);
ASSERT_EQ(std::get(Elem).Reg.Number, 0u);
+ ASSERT_EQ(std::get(Elem).AddressU, T
https://github.com/inbelic edited
https://github.com/llvm/llvm-project/pull/140957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/142010
>From 34733d6f150360984a01b69ac22313f3bdf4b373 Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Mon, 26 May 2025 21:51:36 +
Subject: [PATCH 1/5] nfc: rename matches
---
clang/test/CodeGenHLSL/RootSignatur
https://github.com/inbelic created
https://github.com/llvm/llvm-project/pull/142010
Implements metadata generation of a Root Signature from its in-memory
representation.
This pr handles RootFlags, RootConstants and RootDescriptors.
The metadata follows the format described
[here](https://git
https://github.com/inbelic edited
https://github.com/llvm/llvm-project/pull/140291
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/140291
>From 4002195ce0dad1d292efc73530c7584edc1ecf7f Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Fri, 16 May 2025 16:08:36 +
Subject: [PATCH 1/9] pre-req: add keywords
---
clang/include/clang/Lex/HLSLRootS
https://github.com/inbelic closed
https://github.com/llvm/llvm-project/pull/140181
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -821,22 +873,115 @@ std::optional
RootSignatureParser::handleUIntLiteral() {
PP.getSourceManager(), PP.getLangOpts(),
PP.getTargetInfo(), PP.getDiagnostics());
if (Literal.hadError)
-return tr
https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/140181
>From 1c40e031725f1bd21c5c0d24d333781f99bd2a0a Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Thu, 15 May 2025 23:14:10 +
Subject: [PATCH 01/18] pre-req: add missing token to Lexer
---
clang/include/cla
https://github.com/inbelic edited
https://github.com/llvm/llvm-project/pull/140181
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic approved this pull request.
LGTM given we have a way of tracking making sure it will be read-only
https://github.com/llvm/llvm-project/pull/141086
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org
https://github.com/inbelic closed
https://github.com/llvm/llvm-project/pull/140180
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/140180
>From 05cd843e21cd8d93a94914d13843871886146dab Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Thu, 15 May 2025 22:35:30 +
Subject: [PATCH 1/3] [HLSL][RootSignature] Add parsing infastructure for
StaticSa
https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/140180
>From 05cd843e21cd8d93a94914d13843871886146dab Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Thu, 15 May 2025 22:35:30 +
Subject: [PATCH 1/2] [HLSL][RootSignature] Add parsing infastructure for
StaticSa
https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/140180
>From 05cd843e21cd8d93a94914d13843871886146dab Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Thu, 15 May 2025 22:35:30 +
Subject: [PATCH] [HLSL][RootSignature] Add parsing infastructure for
StaticSample
https://github.com/inbelic edited
https://github.com/llvm/llvm-project/pull/140180
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic commented:
How does this/will this handle enforcing that it is a read-only buffer?
https://github.com/llvm/llvm-project/pull/141086
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
https://github.com/inbelic closed
https://github.com/llvm/llvm-project/pull/140152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/140152
>From 3daccf83b60e2a5435097b950eaf3cf07a39b440 Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Thu, 15 May 2025 20:31:30 +
Subject: [PATCH 1/3] [HLSL][RootSignature] Add parsing of flags to RootParam
- de
https://github.com/inbelic closed
https://github.com/llvm/llvm-project/pull/140151
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/140151
>From 57d166785f06fcdb8e9c9a1b796ec89a9cc91070 Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Thu, 15 May 2025 20:07:51 +
Subject: [PATCH 1/3] [HLSL][RootSignature] Add parsing of optional parameters
for
https://github.com/inbelic edited
https://github.com/llvm/llvm-project/pull/140151
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/140151
>From 57d166785f06fcdb8e9c9a1b796ec89a9cc91070 Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Thu, 15 May 2025 20:07:51 +
Subject: [PATCH 1/2] [HLSL][RootSignature] Add parsing of optional parameters
for
https://github.com/inbelic edited
https://github.com/llvm/llvm-project/pull/140151
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic closed
https://github.com/llvm/llvm-project/pull/140148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/140148
>From ae3cffb72588f7afa5107dbd0b7d47137336273a Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Thu, 15 May 2025 19:49:44 +
Subject: [PATCH 1/3] [HLSL][RootSignature] Add parsing of Register in params
for
https://github.com/inbelic edited
https://github.com/llvm/llvm-project/pull/140148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/140148
>From ae3cffb72588f7afa5107dbd0b7d47137336273a Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Thu, 15 May 2025 19:49:44 +
Subject: [PATCH 1/2] [HLSL][RootSignature] Add parsing of Register in params
for
https://github.com/inbelic closed
https://github.com/llvm/llvm-project/pull/140147
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic edited
https://github.com/llvm/llvm-project/pull/140147
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic edited
https://github.com/llvm/llvm-project/pull/140147
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/140147
>From fc2fc60145e65a1b32542cbaf9b4bd6ce3b1509d Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Thu, 15 May 2025 17:48:07 +
Subject: [PATCH 1/2] [HLSL][RootSignature] Add parsing for empty RootParams
- def
https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/140147
>From fc2fc60145e65a1b32542cbaf9b4bd6ce3b1509d Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Thu, 15 May 2025 17:48:07 +
Subject: [PATCH 1/2] [HLSL][RootSignature] Add parsing for empty RootParams
- def
@@ -1,17 +1,19 @@
-// RUN: %clang_cc1 -finclude-default-header -triple \
-// RUN: dxil-pc-shadermodel6.3-compute %s -emit-llvm -disable-llvm-passes -o
- | \
-// RUN: FileCheck %s -DTARGET=dx
-// RUN: %clang_cc1 -finclude-default-header -triple \
-// RUN: spirv-pc-vulkan-com
https://github.com/inbelic approved this pull request.
https://github.com/llvm/llvm-project/pull/140315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic created
https://github.com/llvm/llvm-project/pull/140147
- define the RootParam in-memory struct containing its type
- add test harness for testing
First part of https://github.com/llvm/llvm-project/issues/126577
>From fc2fc60145e65a1b32542cbaf9b4bd6ce3b1509d Mon Sep
https://github.com/inbelic closed
https://github.com/llvm/llvm-project/pull/139633
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -160,6 +163,75 @@ void dumpRootElements(raw_ostream &OS,
ArrayRef Elements) {
OS << "}";
}
+static MDString *ClauseTypeToName(LLVMContext &Ctx, ClauseType Type) {
+ StringRef Name;
+ switch (Type) {
+ case ClauseType::CBuffer:
+Name = "CBV";
+break;
+ case Cl
https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/139633
>From 135e6c98f964daff5313c335fc38c5e857994366 Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Mon, 12 May 2025 21:43:57 +
Subject: [PATCH 01/14] pre-req: update attr to store reference to root
signature
https://github.com/inbelic edited
https://github.com/llvm/llvm-project/pull/139633
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic edited
https://github.com/llvm/llvm-project/pull/139633
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -160,6 +163,75 @@ void dumpRootElements(raw_ostream &OS,
ArrayRef Elements) {
OS << "}";
}
+static MDString *ClauseTypeToName(LLVMContext &Ctx, ClauseType Type) {
+ StringRef Name;
+ switch (Type) {
+ case ClauseType::CBuffer:
+Name = "CBV";
+break;
+ case Cl
@@ -160,6 +163,75 @@ void dumpRootElements(raw_ostream &OS,
ArrayRef Elements) {
OS << "}";
}
+static MDString *ClauseTypeToName(LLVMContext &Ctx, ClauseType Type) {
+ StringRef Name;
+ switch (Type) {
+ case ClauseType::CBuffer:
+Name = "CBV";
+break;
+ case Cl
https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/139633
>From 135e6c98f964daff5313c335fc38c5e857994366 Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Mon, 12 May 2025 21:43:57 +
Subject: [PATCH 01/13] pre-req: update attr to store reference to root
signature
https://github.com/inbelic approved this pull request.
https://github.com/llvm/llvm-project/pull/139842
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
inbelic wrote:
Unused variables build failures were addressed [here
](https://github.com/llvm/llvm-project/pull/139590)and
[here](https://github.com/llvm/llvm-project/commit/e74877bafebeff40f7213c199c8125bb49818fc1).
https://github.com/llvm/llvm-project/pull/137690
https://github.com/inbelic closed
https://github.com/llvm/llvm-project/pull/139590
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
inbelic wrote:
https://github.com/llvm/llvm-project/commit/e74877bafebeff40f7213c199c8125bb49818fc1
beat me to it
https://github.com/llvm/llvm-project/pull/139590
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
https://github.com/inbelic created
https://github.com/llvm/llvm-project/pull/139590
- SignatureDecl is currently unused as validation is not yet implemented
- this patch cleans-up the unused variable from when it was used during
implementation
Rate limit · GitHub
https://github.com/inbelic closed
https://github.com/llvm/llvm-project/pull/137690
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/137690
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-s
https://github.com/inbelic edited
https://github.com/llvm/llvm-project/pull/137690
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/137690
>From 87680ba4a99d35dbcc9416ab6b0710bd2f88d7bd Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Mon, 28 Apr 2025 18:42:10 +
Subject: [PATCH 01/16] [HLSL][RootSignature] Define and integrate rootsig
clang a
https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/138007
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-s
https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/138055
>From e1b21cc4d33dab2e100346443c998a678afc3dab Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Wed, 30 Apr 2025 23:14:07 +
Subject: [PATCH 1/6] pre-req: define missing lexer tokens for flags
---
.../clan
https://github.com/inbelic edited
https://github.com/llvm/llvm-project/pull/138055
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic closed
https://github.com/llvm/llvm-project/pull/138007
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic edited
https://github.com/llvm/llvm-project/pull/138007
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic closed
https://github.com/llvm/llvm-project/pull/138002
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/138002
>From 61931241a2d66161b00ea5478d02f7fe3842ae8c Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Wed, 30 Apr 2025 17:53:11 +
Subject: [PATCH 1/4] [HLSL][RootSignature] Add mandatory parameters for
RootConst
https://github.com/inbelic edited
https://github.com/llvm/llvm-project/pull/138002
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic approved this pull request.
https://github.com/llvm/llvm-project/pull/138993
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic edited
https://github.com/llvm/llvm-project/pull/138993
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic closed
https://github.com/llvm/llvm-project/pull/137999
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic approved this pull request.
https://github.com/llvm/llvm-project/pull/138964
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/137999
>From d6e88d0ced28861ed0181b2d4aa2269582f768d9 Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Wed, 30 Apr 2025 17:17:32 +
Subject: [PATCH 1/4] pre-req: add missing lexing keywords
---
clang/include/clan
@@ -252,6 +252,32 @@ TEST_F(ParseHLSLRootSignatureTest, ValidSamplerFlagsTest) {
ASSERT_TRUE(Consumer->isSatisfied());
}
+TEST_F(ParseHLSLRootSignatureTest, ValidParseRootConsantsTest) {
inbelic wrote:
Once we add the mandatory parameters then having an emp
@@ -3037,6 +3037,11 @@ void TextNodeDumper::VisitHLSLBufferDecl(const
HLSLBufferDecl *D) {
dumpName(D);
}
+void TextNodeDumper::VisitHLSLRootSignatureDecl(
+const HLSLRootSignatureDecl *D) {
+ dumpName(D);
inbelic wrote:
>From design we will block on
https://github.com/inbelic edited
https://github.com/llvm/llvm-project/pull/137690
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5209,6 +5211,97 @@ void
Parser::ParseMicrosoftUuidAttributeArgs(ParsedAttributes &Attrs) {
}
}
+void Parser::ParseMicrosoftRootSignatureAttributeArgs(ParsedAttributes &Attrs)
{
+ assert(Tok.is(tok::identifier) &&
+ "Expected an identifier to denote which MS at
https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/137690
>From 0ab73ae597164aa039be69534056edbe26e55243 Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Mon, 28 Apr 2025 18:42:10 +
Subject: [PATCH 01/11] [HLSL][RootSignature] Define and integrate rootsig
clang a
https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/137690
>From 0ab73ae597164aa039be69534056edbe26e55243 Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Mon, 28 Apr 2025 18:42:10 +
Subject: [PATCH 01/10] [HLSL][RootSignature] Define and integrate rootsig
clang a
@@ -5209,6 +5211,92 @@ void
Parser::ParseMicrosoftUuidAttributeArgs(ParsedAttributes &Attrs) {
}
}
+void Parser::ParseMicrosoftRootSignatureAttributeArgs(ParsedAttributes &Attrs)
{
+ assert(Tok.is(tok::identifier) && "Not a Microsoft attribute list");
+ IdentifierInfo *R
https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/137690
>From 0ab73ae597164aa039be69534056edbe26e55243 Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Mon, 28 Apr 2025 18:42:10 +
Subject: [PATCH 1/8] [HLSL][RootSignature] Define and integrate rootsig clang
att
https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/137999
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-s
https://github.com/inbelic created
https://github.com/llvm/llvm-project/pull/137999
- defines the empty RootConstants in-memory struct
- adds test harness for testing it
- adds missing parameter keywords to the lexer (`RootConstants`,
`num32BitConstants`)
First part of implementing: https://g
https://github.com/inbelic closed
https://github.com/llvm/llvm-project/pull/137720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic approved this pull request.
https://github.com/llvm/llvm-project/pull/137877
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic edited
https://github.com/llvm/llvm-project/pull/137690
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,11 @@
+// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -o - %s
-verify
+
+// Attr test
+
+[RootSignature()] // expected-error {{expected string literal as argument of
'RootSignature' attribute}}
+void bad_root_signature_0() {}
+
+// expected-error@+2
@@ -949,6 +950,23 @@ void SemaHLSL::emitLogicalOperatorFixIt(Expr *LHS, Expr
*RHS,
<< NewFnName << FixItHint::CreateReplacement(FullRange, OS.str());
}
+void SemaHLSL::handleRootSignatureAttr(Decl *D, const ParsedAttr &AL) {
+ if (AL.getNumArgs() != 1) {
+Diag(AL.g
@@ -3037,6 +3037,11 @@ void TextNodeDumper::VisitHLSLBufferDecl(const
HLSLBufferDecl *D) {
dumpName(D);
}
+void TextNodeDumper::VisitHLSLRootSignatureDecl(
+const HLSLRootSignatureDecl *D) {
+ dumpName(D);
inbelic wrote:
We could extend this to dump m
https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/137690
>From 0ab73ae597164aa039be69534056edbe26e55243 Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Mon, 28 Apr 2025 18:42:10 +
Subject: [PATCH 1/2] [HLSL][RootSignature] Define and integrate rootsig clang
att
https://github.com/inbelic edited
https://github.com/llvm/llvm-project/pull/137690
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic created
https://github.com/llvm/llvm-project/pull/137690
- Defines a new declaration node `HLSLRootSignature` in `DeclNodes.td` that
will hold a reference to an in-memory construction of the root signature,
namely an array of `hlsl::rootsig::RootElement`s
- Defines
https://github.com/inbelic edited
https://github.com/llvm/llvm-project/pull/137038
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/137038
>From dd004171f5777dc68b700a5bf0f96c9c703a57c9 Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Wed, 23 Apr 2025 18:37:55 +
Subject: [PATCH 1/2] pre-req: Add `unbounded` keyword to lexer
---
clang/include
https://github.com/inbelic closed
https://github.com/llvm/llvm-project/pull/136775
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -91,11 +92,19 @@ class RootSignatureParser {
/// Parsing methods of various enums
std::optional parseShaderVisibility();
+ std::optional
+ parseDescriptorRangeFlags();
inbelic wrote:
Yep, adding spaces will make clang-format complain.
https://github
inbelic wrote:
Closing as this would actually introduce a circular dependency between
clangParse and clangSema, as surprisingly, clangParse has a dependency on
clangSema. This will need to reland after we move the HLSLRootSignatureParser
into an accessible location (most likely within clangSem
https://github.com/inbelic closed
https://github.com/llvm/llvm-project/pull/134293
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic reopened
https://github.com/llvm/llvm-project/pull/136751
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/136751
>From bf4bb7a08445df8f65cbee8b98e674fbbd154965 Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Tue, 22 Apr 2025 19:42:50 +
Subject: [PATCH] [HLSL][RootSignature] Add parsing of ShaderVisibility to
Descrip
https://github.com/inbelic edited
https://github.com/llvm/llvm-project/pull/136751
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic closed
https://github.com/llvm/llvm-project/pull/136747
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -26,22 +26,14 @@
RootSignatureParser::RootSignatureParser(SmallVector &Elements,
bool RootSignatureParser::parse() {
// Iterate as many RootElements as possible
- while (tryConsumeExpectedToken(TokenKind::kw_DescriptorTable)) {
-// Dispatch onto parser method.
-
1 - 100 of 525 matches
Mail list logo
