[PATCH] D137652: Remove mandatory define of optional features macros for OpenCL C 3.0

2022-12-13 Thread Finlay Marno via Phabricator via cfe-commits
FMarno added a comment. Thank you for your comments. Unfortunately I won't be able to implement these changes because of time constraints in the current project, sorry if I've wasted your time. On the bright side I feel like I've learned something so thank you for that. I hope I can make a prop

[PATCH] D137652: Remove mandatory define of optional features macros for OpenCL C 3.0

2022-11-29 Thread Finlay Marno via Phabricator via cfe-commits
FMarno added a comment. @Anastasia I feel like I am following the guidance you quoted here. The defines I've deleted in `opencl-c-base.h` are blocking the possibility of `-cl-ext` working and would also get in the way of undefine preprocessor symbols working. If there is a problem with the addi

[PATCH] D137652: Remove mandatory define of optional features macros for OpenCL C 3.0

2022-11-08 Thread Finlay Marno via Phabricator via cfe-commits
FMarno created this revision. FMarno added a reviewer: Anastasia. Herald added subscribers: Naghasan, ldrumm, yaxunl. Herald added a project: All. FMarno requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A number of feature macros were being