fxb updated this revision to Diff 145196.
fxb added a comment.
1. Fixed the compile error caused by re-using the name
`ShowIncludesDestination`. The member variable is now named `ShowIncludesDest`.
2. Fixed `test/Frontend/print-header-includes.c` to test both cases:
- If only `--show-includes`
fxb added a comment.
I'll have a look at these issues tomorrow and submit a new patch then.
Thanks for all your help so far!
https://reviews.llvm.org/D46394
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
fxb added a comment.
@erichkeane That would be great! Thanks!
https://reviews.llvm.org/D46394
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
fxb updated this revision to Diff 145030.
fxb added a comment.
Updated the code to use an enum called `ShowIncludesDestination`
https://reviews.llvm.org/D46394
Files:
include/clang/Frontend/DependencyOutputOptions.h
lib/Driver/ToolChains/Clang.cpp
lib/Frontend/CompilerInstance.cpp
lib/F
fxb added inline comments.
Comment at: include/clang/Frontend/DependencyOutputOptions.h:31
unsigned AddMissingHeaderDeps : 1; ///< Add missing headers to dependency
list
unsigned PrintShowIncludes : 1; ///< Print cl.exe style /showIncludes info.
+ unsigned
---
fxb added a comment.
This is my first patch to clang, so any feedback regarding implementation
appreciated!
Also, let me know if you have any suggestions on how to add more extensive
tests for this.
Repository:
rC Clang
https://reviews.llvm.org/D46394
___
fxb created this revision.
fxb added reviewers: hans, erichkeane, thakis.
Herald added a subscriber: cfe-commits.
This replicates 'cl.exe' behavior and allows for both preprocessor output and
dependency information to be extraced with a single compiler invocation.
This is especially useful for co
