felipepiovezan wrote:
> @felipepiovezan @juliannagele Sorry for the delayed response. This is quite
> strange, since the issues seem to be on the x86 side...
To clarify, both x86 and aarch bots were failing on this (but they both enable
both targets in their builds)
https://github.com/llvm/ll
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/115022
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/115022
Reverts llvm/llvm-project#114431
>From d560dcabad287952024ffb0014cfcce1f4672535 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Tue, 5 Nov 2024 08:43:16 -0800
Subject: [PATCH] Revert "[XR
felipepiovezan wrote:
This is also breaking the LLDB bots:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/7291/
I'm going to revert this until the author has a chance to look these failures
https://github.com/llvm/llvm-project/pull/114431
_
felipepiovezan wrote:
> > @felipepiovezan I tested without this patch applied and was still seeing
> > crashes... could you perhaps see if
> > https://github.com/sdkrystian/llvm-project/tree/reapply-use-latest-primary
> > fixes the regression?
>
> Let me give it a try now!
Yup, that fixes th
felipepiovezan wrote:
> @felipepiovezan I tested without this patch applied and was still seeing
> crashes... could you perhaps see if
> https://github.com/sdkrystian/llvm-project/tree/reapply-use-latest-primary
> fixes the regression?
Let me give it a try now!
https://github.com/llvm/llvm-p
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/114304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/114304
Clang importer doesn't seem to work well with this change, see discussion in
the original PR.
Reverts llvm/llvm-project#114258
>From 565d18daf296b9848cf9d1b23fc82892e10eef8c Mon Sep 17 00:00:00 2001
Fro
felipepiovezan wrote:
> That said, if you get to be somewhat more sure that this is the patch that
> caused it, feel free to revert and @sdkrystian will look at it more closely
> tomorrow.
I'm going to revert it for the time being to unblock the bots
https://github.com/llvm/llvm-project/pull
felipepiovezan wrote:
I reverted locally and confirmed that it was this commit that introduced the
regression. I don't know much about clang importer to be honest, but this can
be reproed by adding `lldb` to the list of projects to build, then building the
`check-lldb` target.
You can stop th
felipepiovezan wrote:
There seems to be some kind of infinite recursion, I attached the debugger to
one such test, and stack at the time of the crash has 59,000 frames.
The top few are:
```
(lldb) bt 30
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS
(code=2, address
felipepiovezan wrote:
These types of changes touching a lot of projects at once can benefit from
multiple PRs, one per project, as it makes partial reverts a lot easier and
doesn't cause as much churn downstream (plus we can get more targeted comments
from individual project owners)
https://g
@@ -406,5 +426,13 @@ function(llvm_ExternalProject_Add name source_dir)
WORKING_DIRECTORY ${BINARY_DIR}
VERBATIM
USES_TERMINAL)
+if (ARG_FOLDER)
+ set_target_properties(${target} PROPERTIES FOLDER "${ARG_FOLDER}")
+endif ()
endforeach()
+
+ #s
felipepiovezan wrote:
> > This seems akin to running clang-format on the entire project, which last
> > time we talked about still faced opposition
>
> My impression (I admit I haven't reviewed the whole thread lately) is that
> the opposition has mostly to do with how clang-format mangles som
felipepiovezan wrote:
Juuust to make sure, was this discussed before? This seems akin to running
clang-format on the entire project, which last time we talked about still faced
opposition:
https://discourse.llvm.org/t/rfc-clang-format-all-the-things/76614/11
https://github.com/llvm/llvm-proje
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/79230
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3416,6 +3437,27 @@ llvm::DIMacroFile
*CGDebugInfo::CreateTempMacroFile(llvm::DIMacroFile *Parent,
return DBuilder.createTempMacroFile(Parent, Line, FName);
}
+llvm::DILocation *CGDebugInfo::CreateTrapFailureMessageFor(
+llvm::DebugLoc TrapLocation, StringRef Prefix,
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/79230
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3416,6 +3437,27 @@ llvm::DIMacroFile
*CGDebugInfo::CreateTempMacroFile(llvm::DIMacroFile *Parent,
return DBuilder.createTempMacroFile(Parent, Line, FName);
}
+llvm::DILocation *CGDebugInfo::CreateTrapFailureMessageFor(
+llvm::DebugLoc TrapLocation, StringRef Prefix,
https://github.com/felipepiovezan requested changes to this pull request.
Hi @jeevanghimire, thank you for the PR! I believe the original issue was not
about changing LLVM test inputs, but rather about changing clang-tidy to warn
about this kind of patterns.
Please see my rationale in a previo
@@ -34,7 +34,7 @@ namespace A {
int myfunc (int a);
int myfunc2(int a)
{
- return a + 2;
+return a + 2; //just changing tab not much
felipepiovezan wrote:
In general, we don't add diffs that are unrelated to
@@ -56,10 +56,10 @@ namespace Foo = A::B; // namespace alias
using Foo::myfunc; // using declaration
-using namespace Foo;// using directive
+//removing namespace foo; for quality naming
felipepiovezan wrote:
Hi @jeevanghimire, please note that t
felipepiovezan wrote:
If this gets reverted for some reason, please note that I had to update a
cross-project-tests test:
https://github.com/llvm/llvm-project/pull/73566
https://github.com/llvm/llvm-project/pull/71677
___
cfe-commits mailing list
cfe-
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/72415
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/felipepiovezan approved this pull request.
LGTM. If there are others waiting on the fix, and since this is a fairly
trivial change, you may want to push it soonish
https://github.com/llvm/llvm-project/pull/72415
___
cfe-commits mail
@@ -424,6 +424,7 @@ namespace llvm {
/// \param OffsetInBits Member offset.
/// \param FlagsFlags to encode member attribute, e.g. private
/// \param Elements class members.
+/// \param RunTimeLang Optional parameter, Objective-C runtime version.
--
felipepiovezan wrote:
> @felipepiovezan I don't this patch as it is has any changes that are
> testable. I haven't added any code that will emit a RuntimeLang, only added
> the option to do that so I can add those callers downstream. In retrospect I
> should've marked it as NFC.
I see. I thin
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/72011
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/72011
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -424,6 +424,7 @@ namespace llvm {
/// \param OffsetInBits Member offset.
/// \param FlagsFlags to encode member attribute, e.g. private
/// \param Elements class members.
+/// \param RunTimeLang Optional parameter, Objective-C runtime version.
--
@@ -424,6 +424,7 @@ namespace llvm {
/// \param OffsetInBits Member offset.
/// \param FlagsFlags to encode member attribute, e.g. private
/// \param Elements class members.
+/// \param RunTimeLang Optional parameter, Objective-C runtime version.
--
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/72011
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/felipepiovezan commented:
Let's add the `[DebugInfo][CGDebugInfo]` tags the commit message so that the
git log is more searchable.
I think we should have at least one test in this patch as well
https://github.com/llvm/llvm-project/pull/72011
@@ -5935,3 +5918,28 @@ llvm::DINode::DIFlags
CGDebugInfo::getCallSiteRelatedAttrs() const {
return llvm::DINode::FlagAllCallsDescribed;
}
+
+llvm::DIExpression *
+CGDebugInfo::createConstantValueExpression(clang::ValueDecl const *VD,
+
@@ -5935,3 +5918,28 @@ llvm::DINode::DIFlags
CGDebugInfo::getCallSiteRelatedAttrs() const {
return llvm::DINode::FlagAllCallsDescribed;
}
+
+llvm::DIExpression *
+CGDebugInfo::createConstantValueExpression(clang::ValueDecl const *VD,
+
https://github.com/felipepiovezan approved this pull request.
LGTM but left a couple of comments.
Thanks for breaking this into two separate PRs.
https://github.com/llvm/llvm-project/pull/70674
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/70674
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -106,14 +107,71 @@ static void findReturnsToZap(Function &F,
}
}
-static bool runIPSCCP(
-Module &M, const DataLayout &DL, FunctionAnalysisManager *FAM,
-std::function GetTLI,
-std::function GetTTI,
-std::function GetAC,
-std::function GetDT,
-std:
@@ -106,14 +107,71 @@ static void findReturnsToZap(Function &F,
}
}
-static bool runIPSCCP(
-Module &M, const DataLayout &DL, FunctionAnalysisManager *FAM,
-std::function GetTLI,
-std::function GetTTI,
-std::function GetAC,
-std::function GetDT,
-std:
@@ -106,14 +107,71 @@ static void findReturnsToZap(Function &F,
}
}
-static bool runIPSCCP(
-Module &M, const DataLayout &DL, FunctionAnalysisManager *FAM,
-std::function GetTLI,
-std::function GetTTI,
-std::function GetAC,
-std::function GetDT,
-std:
@@ -106,14 +107,71 @@ static void findReturnsToZap(Function &F,
}
}
-static bool runIPSCCP(
-Module &M, const DataLayout &DL, FunctionAnalysisManager *FAM,
-std::function GetTLI,
-std::function GetTTI,
-std::function GetAC,
-std::function GetDT,
-std:
https://github.com/felipepiovezan approved this pull request.
I've confirmed that this fixes the
`lang/objc/modules-objc-property/TestModulesObjCProperty.py` failure we see in
the matrix bot for DWARF 5!
https://github.com/llvm/llvm-project/pull/66032
__
Author: Felipe de Azevedo Piovezan
Date: 2023-03-24T14:49:47-04:00
New Revision: d820772ce17215c3e2c0f72d16b2d3f14a8745fb
URL:
https://github.com/llvm/llvm-project/commit/d820772ce17215c3e2c0f72d16b2d3f14a8745fb
DIFF:
https://github.com/llvm/llvm-project/commit/d820772ce17215c3e2c0f72d16b2d3f14
Author: Felipe de Azevedo Piovezan
Date: 2023-02-20T14:22:49-05:00
New Revision: 997dc7e00f49663b60a78e18df1dfecdf62a4172
URL:
https://github.com/llvm/llvm-project/commit/997dc7e00f49663b60a78e18df1dfecdf62a4172
DIFF:
https://github.com/llvm/llvm-project/commit/997dc7e00f49663b60a78e18df1dfecdf
Author: Felipe de Azevedo Piovezan
Date: 2023-02-01T13:07:47-05:00
New Revision: f84d30e172b1f2365b1437b931d99156a76ed8f2
URL:
https://github.com/llvm/llvm-project/commit/f84d30e172b1f2365b1437b931d99156a76ed8f2
DIFF:
https://github.com/llvm/llvm-project/commit/f84d30e172b1f2365b1437b931d99156a
Apologies, I’ll do it next time!
In the meantime, the reason was posted in D141381
> On Jan 16, 2023, at 13:59, Roman Lebedev wrote:
>
> Reminder to please always mention the reason for the revert/recommit
> in the commit message.
>
> On Mon, Jan 16, 2023 at 7:05 PM Felipe d
Author: Felipe de Azevedo Piovezan
Date: 2023-01-16T13:05:22-03:00
New Revision: f2d301fe82869f881b86b51da7b4752972c66707
URL:
https://github.com/llvm/llvm-project/commit/f2d301fe82869f881b86b51da7b4752972c66707
DIFF:
https://github.com/llvm/llvm-project/commit/f2d301fe82869f881b86b51da7b475297
Author: Felipe de Azevedo Piovezan
Date: 2023-01-16T11:14:55-03:00
New Revision: 7e4447a17db4a070f01c8f8a87505a4b2a1b0e3a
URL:
https://github.com/llvm/llvm-project/commit/7e4447a17db4a070f01c8f8a87505a4b2a1b0e3a
DIFF:
https://github.com/llvm/llvm-project/commit/7e4447a17db4a070f01c8f8a87505a4b2
48 matches
Mail list logo
