[PATCH] D96032: [flang][driver] Add support for -fopenmp and -fopenacc

2021-02-04 Thread Faris via Phabricator via cfe-commits
FarisRehman created this revision. Herald added subscribers: dang, guansong, yaxunl. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added a reviewer: jansvoboda11. FarisRehman requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscr

[PATCH] D95460: [flang][driver] Add forced form flags and -ffixed-line-length

2021-02-04 Thread Faris via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3a1513c142f4: [flang][driver] Add forced form flags and -ffixed-line-length (authored by FarisRehman). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D95460: [flang][driver] Add forced form flags and -ffixed-line-length

2021-02-02 Thread Faris via Phabricator via cfe-commits
FarisRehman updated this revision to Diff 320811. FarisRehman marked an inline comment as done. FarisRehman added a comment. Address review comment This revision addresses a review comment by @tskeith Summary of changes: - Add a new option, ffixed_line_length_EQ, that defines `-ffixed-line-leng

[PATCH] D95460: [flang][driver] Add forced form flags and -ffixed-line-length

2021-01-29 Thread Faris via Phabricator via cfe-commits
FarisRehman updated this revision to Diff 320145. FarisRehman added a comment. Remove -fno-fixed-form and -fno-free-form Remove options `-fno-fixed-form` and `-fno-free-form` allowing for help messages to be added to `-ffixed-form` and `-ffree-form`. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D95460: [flang][driver] Add forced form flags and -ffixed-line-length

2021-01-28 Thread Faris via Phabricator via cfe-commits
FarisRehman marked an inline comment as done. FarisRehman added inline comments. Comment at: flang/lib/Frontend/CompilerInstance.cpp:151-158 + if (invoc.frontendOpts().fortranForm_ == FortranForm::Unknown) { +// Switch between fixed and free form format based on the

[PATCH] D95460: [flang][driver] Add forced form flags and -ffixed-line-length

2021-01-28 Thread Faris via Phabricator via cfe-commits
FarisRehman updated this revision to Diff 319842. FarisRehman marked 12 inline comments as done. FarisRehman added a comment. Address review comment Address the review comment by @awarzynski Summary of changes: - Shorten help text - Add method AddFortranDialectOptions to Flang.cpp - Change styl

[PATCH] D95460: [flang][driver] Add forced form flags and -ffixed-line-length

2021-01-26 Thread Faris via Phabricator via cfe-commits
FarisRehman created this revision. Herald added a reviewer: sscalpone. Herald added a subscriber: dang. Herald added a reviewer: awarzynski. Herald added a reviewer: jansvoboda11. FarisRehman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D93453: [flang][driver] Add support for `-I`

2021-01-15 Thread Faris via Phabricator via cfe-commits
FarisRehman updated this revision to Diff 316908. FarisRehman marked 2 inline comments as done. FarisRehman added a comment. Add include-module test Update the regression test to check the behaviour of -I with an INCLUDE line in the source code. Also add a regression test to check the behaviour

[PATCH] D93453: [flang][driver] Add support for `-I`

2021-01-15 Thread Faris via Phabricator via cfe-commits
FarisRehman marked 2 inline comments as done. FarisRehman added inline comments. Comment at: flang/test/Flang-Driver/include-header.f90:38 +!- +! EXPECTED OUTPUT FOR /Inputs/ FOLDER SPECIFIED FIRST +!

[PATCH] D93401: [flang][driver] Add support for `-D`, `-U`

2021-01-15 Thread Faris via Phabricator via cfe-commits
FarisRehman marked an inline comment as done. FarisRehman added inline comments. Comment at: flang/test/Flang-Driver/driver-help.f90:22 ! HELP-NEXT: -### Print (but do not run) the commands to run for this compilation +! HELP-NEXT: -D = Define to (or 1 i

[PATCH] D93453: [flang][driver] Add support for `-I`

2021-01-13 Thread Faris via Phabricator via cfe-commits
FarisRehman updated this revision to Diff 316423. FarisRehman added a comment. Add a new test Update the regression test to check the behaviour of multiple `-I`'s specified. Summary of changes: - Update regression test with new checks - Fix regression tests that broke when patch D93712

[PATCH] D93401: [flang][driver] Add support for `-D`, `-U`

2021-01-11 Thread Faris via Phabricator via cfe-commits
FarisRehman added inline comments. Comment at: flang/test/Flang-Driver/driver-help.f90:22 ! HELP-NEXT: -### Print (but do not run) the commands to run for this compilation +! HELP-NEXT: -D = Define to (or 1 if omitted) ! HELP-NEXT: -E

[PATCH] D93453: [flang][driver] Add support for `-I`

2021-01-07 Thread Faris via Phabricator via cfe-commits
FarisRehman updated this revision to Diff 315090. FarisRehman added a comment. Rename test files Rename test files to use dashes instead of underscores, as other test files do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93453/new/ https://revie

[PATCH] D93453: [flang][driver] Add support for `-I`

2021-01-06 Thread Faris via Phabricator via cfe-commits
FarisRehman updated this revision to Diff 314905. FarisRehman added a comment. Address minor changes in review comments Summary of changes - Add a TODO for future search-path related options - Change the text which the driver-help tests look for, which matches the help message in #D94169 - Rena

[PATCH] D93453: [flang][driver] Add support for `-I`

2020-12-23 Thread Faris via Phabricator via cfe-commits
FarisRehman updated this revision to Diff 313536. FarisRehman added a comment. Clean up test Summary of changes: - Clean up test include_header.f90 - Rename SearchDirectoriesFromDashI to searchDirectoriesFromDashI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D93401: [flang][driver] Add support for `-D`, `-U`

2020-12-23 Thread Faris via Phabricator via cfe-commits
FarisRehman updated this revision to Diff 313532. FarisRehman marked 5 inline comments as done. FarisRehman added a comment. Address review comments This revision addresses comments by @awarzynski Summary of changes: - Update commit summary - Use Doxygen style for input/output parameters - Make

[PATCH] D93453: [flang][driver] Add support for `-I`

2020-12-22 Thread Faris via Phabricator via cfe-commits
FarisRehman updated this revision to Diff 313319. FarisRehman added a comment. Address review comments Summary of changes: - Add a regression test for -I - Move claiming of -I option to the dedicated parsing preprocessing options method - Rename SearchDirectoriesFromI to SearchDirectoriesFromDa

[PATCH] D93401: [flang][driver] Add support for `-D`, `-U`

2020-12-21 Thread Faris via Phabricator via cfe-commits
FarisRehman marked 2 inline comments as done. FarisRehman added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:205 +/// Collect the macro definitions provided by the given preprocessor +/// options into the parser options. +void collectMacroDefinitions( --

[PATCH] D93401: [flang][driver] Add support for `-D`, `-U`

2020-12-21 Thread Faris via Phabricator via cfe-commits
FarisRehman marked an inline comment as done. FarisRehman added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:228 + // Note: GCC drops anything following an end-of-line character. + llvm::StringRef::size_type End = MacroBody.find_first_of("\n\r"

[PATCH] D93401: [flang][driver] Add support for `-D`, `-U`

2020-12-21 Thread Faris via Phabricator via cfe-commits
FarisRehman updated this revision to Diff 313108. FarisRehman edited the summary of this revision. FarisRehman added a comment. Address review comments Address comments with the following changes: - Add a dedicated method to adding preprocessing options in Flang.cpp - Change preprocessorOpts to

[PATCH] D93453: [flang][driver] Add support for `-I`

2020-12-17 Thread Faris via Phabricator via cfe-commits
FarisRehman created this revision. Herald added a reviewer: sscalpone. Herald added a subscriber: dang. FarisRehman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add support for option -I in the Flang driver. This will allow for included

[PATCH] D93401: [flang][driver] Add support for `-D`, `-U`

2020-12-16 Thread Faris via Phabricator via cfe-commits
FarisRehman created this revision. Herald added a reviewer: sscalpone. Herald added a subscriber: dang. FarisRehman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add support for options -D and -U in the Flang driver along with a regressio